[improvement](fe) Set default profile level to 2 by BiteTheDDDDt · Pull Request #64378 · apache/doris

BiteTheDDDDt · 2026-06-10T09:55:23Z

What problem does this PR solve?

Issue Number: None

Related PR: None

Problem Summary: The default query profile level is 1, which only collects merged profile counters. This change sets the FE session default profile_level to 2 so detailed query profile information is collected by default.

Release note

Set the default query profile level to 2.

Check List (For Author)

Test: No need to test (only changes the default value of a session variable).
Behavior changed: Yes. The default profile_level is changed from 1 to 2.
Does this need documentation: No

### What problem does this PR solve? Issue Number: None Related PR: None Problem Summary: The default query profile level is 1, which only collects merged profile counters. This change sets the FE session default profile_level to 2 so detailed query profile information is collected by default. ### Release note Set the default query profile level to 2. ### Check List (For Author) - Test: No need to test (only changes the default value of a session variable). - Behavior changed: Yes. The default profile_level is changed from 1 to 2. - Does this need documentation: No

hello-stephen · 2026-06-10T09:55:30Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

BiteTheDDDDt · 2026-06-10T09:57:30Z

run buildall

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

hello-stephen · 2026-06-10T12:20:21Z

FE UT Coverage Report

Increment line coverage 100% (0/0) 🎉
Increment coverage report
Complete coverage report

hello-stephen · 2026-06-10T12:23:26Z

TPC-H: Total hot run time: 29290 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e2498dc5750d99f16f765b0333be3dc767581a10, data reload: false
------ Round 1 ----------------------------------
orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL ============================================
q1	17717	4255	4109	4109
q2	q3	10767	1416	833	833
q4	4709	484	345	345
q5	7706	887	607	607
q6	208	187	144	144
q7	849	862	629	629
q8	10082	1568	1615	1568
q9	6850	4546	4530	4530
q10	6686	1834	1576	1576
q11	436	270	252	252
q12	652	417	293	293
q13	18224	3401	2779	2779
q14	288	253	238	238
q15	q16	821	808	709	709
q17	3871	1115	845	845
q18	6887	5822	5679	5679
q19	1777	1337	1066	1066
q20	500	427	264	264
q21	5882	2620	2510	2510
q22	452	368	314	314
Total cold run time: 105364 ms
Total hot run time: 29290 ms
----- Round 2, with runtime_filter_mode=off -----
orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL ============================================
q1	4697	4528	4418	4418
q2	q3	4514	5084	4303	4303
q4	2101	2210	1412	1412
q5	4502	4334	5066	4334
q6	260	203	153	153
q7	1963	1926	1677	1677
q8	2478	2171	2153	2153
q9	7939	8133	7934	7934
q10	4866	4775	4304	4304
q11	595	466	427	427
q12	801	772	536	536
q13	3357	3692	2976	2976
q14	303	303	301	301
q15	q16	705	731	651	651
q17	1389	1399	1371	1371
q18	8010	7305	6900	6900
q19	1136	1096	1143	1096
q20	2236	2229	1948	1948
q21	5351	4712	4524	4524
q22	523	462	415	415
Total cold run time: 57726 ms
Total hot run time: 51833 ms

hello-stephen · 2026-06-10T12:34:21Z

TPC-DS: Total hot run time: 169600 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e2498dc5750d99f16f765b0333be3dc767581a10, data reload: false
query5	4320	638	484	484
query6	446	199	183	183
query7	4835	571	320	320
query8	368	220	210	210
query9	8794	4066	4057	4057
query10	442	324	258	258
query11	5980	2362	2137	2137
query12	158	103	99	99
query13	1265	629	432	432
query14	6404	5442	5104	5104
query14_1	4432	4433	4418	4418
query15	206	198	172	172
query16	1003	410	439	410
query17	1105	708	557	557
query18	2437	481	339	339
query19	203	183	145	145
query20	117	110	107	107
query21	222	138	119	119
query22	13657	13633	13467	13467
query23	17436	16631	16128	16128
query23_1	16311	16365	16291	16291
query24	7589	1783	1344	1344
query24_1	1323	1296	1340	1296
query25	561	452	387	387
query26	1304	332	163	163
query27	2669	545	350	350
query28	4477	2078	2042	2042
query29	1064	631	511	511
query30	313	248	203	203
query31	1125	1099	954	954
query32	101	60	59	59
query33	518	314	257	257
query34	1174	1216	648	648
query35	788	776	687	687
query36	1402	1444	1207	1207
query37	161	105	91	91
query38	3233	3149	3040	3040
query39	943	930	904	904
query39_1	908	863	907	863
query40	237	124	104	104
query41	64	67	65	65
query42	96	103	94	94
query43	326	324	275	275
query44 query45	192	187	178	178
query46	1138	1252	755	755
query47	2375	2398	2232	2232
query48	399	423	267	267
query49	645	476	359	359
query50	980	351	258	258
query51	4309	4337	4247	4247
query52	88	90	77	77
query53	250	288	197	197
query54	268	218	203	203
query55	81	76	69	69
query56	247	230	217	217
query57	1417	1414	1300	1300
query58	251	215	202	202
query59	1571	1677	1424	1424
query60	303	256	230	230
query61	157	163	158	158
query62	731	657	593	593
query63	238	193	196	193
query64	2621	853	691	691
query65 query66	1808	484	363	363
query67	29835	29722	29630	29630
query68 query69	439	323	264	264
query70	985	1016	937	937
query71	303	235	216	216
query72	3122	2680	2390	2390
query73	878	858	460	460
query74	5171	4940	4768	4768
query75	2687	2627	2249	2249
query76	2313	1216	782	782
query77	355	389	295	295
query78	12498	12466	11934	11934
query79	1453	1051	775	775
query80	601	473	422	422
query81	459	287	248	248
query82	578	153	116	116
query83	356	276	260	260
query84 query85	872	606	444	444
query86	380	299	288	288
query87	3401	3342	3213	3213
query88	3733	2809	2748	2748
query89	430	382	329	329
query90	1902	179	167	167
query91	177	162	139	139
query92	65	62	59	59
query93	1618	1520	874	874
query94	556	364	309	309
query95	688	478	352	352
query96	1046	785	362	362
query97	2709	2669	2580	2580
query98	216	208	206	206
query99	1144	1179	1056	1056
Total cold run time: 252126 ms
Total hot run time: 169600 ms

hello-stephen · 2026-06-10T15:48:55Z

FE Regression Coverage Report

Increment line coverage 100% (0/0) 🎉
Increment coverage report
Complete coverage report

BiteTheDDDDt · 2026-06-11T02:07:32Z

/review

github-actions

I found one blocking issue: the new default only applies to fresh FE metadata, while upgraded clusters keep the persisted old global session default.

Critical checkpoint conclusions:

Goal/test: fresh clusters would get profile_level=2, but upgraded clusters continue to clone the old persisted defaultSessionVariable value, so the PR does not fully accomplish the stated default-change goal. No test covers this upgrade/persistence path.
Scope: the code change is small and focused, but incomplete because this session default is persisted.
Concurrency/lifecycle: no new concurrency or lock-order risk; the relevant lifecycle concern is FE image/edit-log loading of VariableMgr.defaultSessionVariable.
Config/dynamic behavior: this is an existing session variable, not a new config item; global session defaults are persistent and need explicit migration when the intended default changes.
Compatibility/persistence: missing migration is the main problem. VariableMgr.read() restores the old value from image before new sessions are created.
Parallel paths: BE fallback/query-option defaults already use level 2 in several paths, but the FE session default remains the source for ordinary new sessions after upgrade.
Tests: a VariableMgr serialization/upgrade-style test would catch this. I did not run the full FE test suite in this review runner.
Observability/performance/data correctness/security: no additional issues found in this one-line diff.
User focus: no additional user-provided review focus was present.

hello-stephen · 2026-06-11T07:36:36Z

FE Regression Coverage Report

Increment line coverage 0.00% (0/116) 🎉
Increment coverage report
Complete coverage report

ok

### What problem does this PR solve? Issue Number: None Related PR: None Problem Summary: The default query profile level is 1, which only collects merged profile counters. This change sets the FE session default profile_level to 2 so detailed query profile information is collected by default. ### Release note Set the default query profile level to 2. ### Check List (For Author) - Test: No need to test (only changes the default value of a session variable). - Behavior changed: Yes. The default profile_level is changed from 1 to 2. - Does this need documentation: No

…64417) Cherry-picked from #64378 Co-authored-by: Pxl <xl@selectdb.com>

### What problem does this PR solve? Issue Number: None Related PR: None Problem Summary: The default query profile level is 1, which only collects merged profile counters. This change sets the FE session default profile_level to 2 so detailed query profile information is collected by default. ### Release note Set the default query profile level to 2. ### Check List (For Author) - Test: No need to test (only changes the default value of a session variable). - Behavior changed: Yes. The default profile_level is changed from 1 to 2. - Does this need documentation: No

CopilotAI review requested due to automatic review settings June 10, 2026 09:55

Copilotstarted reviewing on behalf of BiteTheDDDDt June 10, 2026 09:55 View session

CopilotAI reviewed Jun 10, 2026

github-actionsBot previously requested changes Jun 11, 2026
View reviewed changes

Comment threadfe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java

yiguolei approved these changes Jun 11, 2026
View reviewed changes

yiguolei merged commit 4ecdab5 into apache:masterJun 11, 2026
35 checks passed

yiguolei added dev/4.0.x dev/4.1.x labels Jun 11, 2026

github-actionsBot mentioned this pull request Jun 11, 2026
branch-4.1: [improvement](fe) Set default profile level to 2 #64378 #64417
Merged

github-actionsBot mentioned this pull request Jun 11, 2026
branch-4.0: [improvement](fe) Set default profile level to 2 #64378 #64418
Open

yiguolei pushed a commit that referenced this pull request Jun 16, 2026
branch-4.1: [improvement](fe) Set default profile level to 2#64378(#…
6e9f49d
…64417) Cherry-picked from #64378 Co-authored-by: Pxl <xl@selectdb.com>

yiguolei added dev/4.1.3-merged and removed dev/4.1.x labels Jun 16, 2026

yiguolei mentioned this pull request Jul 7, 2026
4.1.3 Release Note #65306
Closed

Navigation Menu

Uh oh!

[improvement](fe) Set default profile level to 2 - #64378

[improvement](fe) Set default profile level to 2#64378
yiguolei merged 1 commit into
apache:masterfrom
BiteTheDDDDt:codex/default-profile-level-2

BiteTheDDDDt commented Jun 10, 2026

Uh oh!

hello-stephen commented Jun 10, 2026

Uh oh!

BiteTheDDDDt commented Jun 10, 2026

Uh oh!

CopilotAI left a comment

Uh oh!

hello-stephen commented Jun 10, 2026

Uh oh!

hello-stephen commented Jun 10, 2026

Uh oh!

hello-stephen commented Jun 10, 2026

Uh oh!

hello-stephen commented Jun 10, 2026

Uh oh!

BiteTheDDDDt commented Jun 11, 2026

Uh oh!

github-actionsBot left a comment

Uh oh!

Uh oh!

hello-stephen commented Jun 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

BiteTheDDDDt commented Jun 10, 2026

What problem does this PR solve?

Release note

Check List (For Author)

Uh oh!

hello-stephen commented Jun 10, 2026

Uh oh!

BiteTheDDDDt commented Jun 10, 2026

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Uh oh!

hello-stephen commented Jun 10, 2026

FE UT Coverage Report

Uh oh!

hello-stephen commented Jun 10, 2026

Uh oh!

hello-stephen commented Jun 10, 2026

Uh oh!

hello-stephen commented Jun 10, 2026

FE Regression Coverage Report

Uh oh!

BiteTheDDDDt commented Jun 11, 2026

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hello-stephen commented Jun 11, 2026

FE Regression Coverage Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants