Skip to content

[branch-4.0](variant) return raw string for element_at on scalar-string variant (#64103) - #64425

Open
csun5285 wants to merge 1 commit into
apache:branch-4.0from
csun5285:cp-64103-branch-4.0
Open

[branch-4.0](variant) return raw string for element_at on scalar-string variant (#64103)#64425
csun5285 wants to merge 1 commit into
apache:branch-4.0from
csun5285:cp-64103-branch-4.0

Conversation

@csun5285

Copy link
Copy Markdown
Contributor

cherry picked from #64103

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@csun5285

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 80.00% (4/5) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage53.37% (19469/36480)
Line Coverage36.48% (181988/498835)
Region Coverage33.06% (141323/427515)
Branch Coverage33.94% (61194/180326)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 80.00% (4/5) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage71.45% (25516/35711)
Line Coverage54.30% (270372/497961)
Region Coverage51.78% (223591/431833)
Branch Coverage53.26% (96373/180959)

@csun5285csun5285 changed the title [fix](variant) return raw string for element_at on scalar-string variant (#64103)[branch-4.0](variant) return raw string for element_at on scalar-string variant (#64103)Jun 12, 2026
…ant (apache#64103)
Manual backport of apache#64103 to branch-4.0. The variant element function
still lives under be/src/vec/functions/ on this branch (namespace
doris::vectorized) and ColumnVariant has no enable_doc_mode constructor
arg, so the UT is adapted accordingly (ColumnVariant::create(0),
assume_mutable). The core fix and regression cases are unchanged.
(cherry picked from commit 98119b9)
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@morningman

Copy link
Copy Markdown
Contributor

run buildall

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Jun 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 80.00% (4/5) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage71.39% (25518/35742)
Line Coverage54.33% (270751/498363)
Region Coverage51.85% (224145/432313)
Branch Coverage53.30% (96573/181187)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@csun5285@hello-stephen@morningman