Uh oh!
There was an error while loading. Please reload this page.
branch-4.0: [improvement](filecache) limit file cache LRU replay queues(pick#64381) - #64462
Merged
morningman merged 2 commits intoJun 24, 2026
Conversation
hello-stephen
commented
Jun 12, 2026
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
gavinchou
commented
Jun 12, 2026
Contributor
run buildall |
gavinchou
commented
Jun 12, 2026
Contributor
|
freemandealerforce-pushed
the
pick-branch-4.0-pr-64381-20260612
branch
from
June 13, 2026 10:03
75308d5 to
d14b3b3Comparefreemandealer
commented
Jun 13, 2026
MemberAuthor
Fixed branch-4.0 compile compatibility for the previous BE/BE UT failure by removing the master-only run buildall |
freemandealer
commented
Jun 13, 2026
MemberAuthor
run buildall |
### What problem does this PR solve? Issue Number: None Related PR: None Problem Summary: File cache LRU log replay needs tighter default replay latency, bounded in-memory queues, and observability for pending block LRU updates and LRU log replay. This change lowers the replay interval default to 1 ms, adds hard caps for the pending block update queue and per-type LRU log queues, preserves existing LRU log backlog when tail recording is disabled, and exposes queue length plus monotonic produce/consume/idle counters. QPS bvars are not added because Prometheus can derive rates from the counters. Tests that depended on background replay timing now use a deterministic single-replay helper with a high background interval. ### Release note Add bounded file cache LRU recorder queues and replay/update queue count metrics. ### Check List (For Author) - Test: Manual test - `PATH=/mnt/disk1/zhangzhengyu/build-dep/ldb_toolchain.back/bin:$PATH build-support/clang-format.sh` - `PATH=/mnt/disk1/zhangzhengyu/build-dep/ldb_toolchain.back/bin:$PATH build-support/check-format.sh` - Focused BE UT rerun was started but stopped during compilation at reviewer request; no completed BE UT result after the latest metric cleanup. - Behavior changed: Yes. File cache LRU replay defaults to 1 ms, LRU log and block update queues are capped at 500000 by default, and disabling tail record enqueueing no longer clears existing replay backlog. - Does this need documentation: No (cherry picked from commit de23f15) Picked-from: apache#64381
freemandealerforce-pushed
the
pick-branch-4.0-pr-64381-20260612
branch
from
June 14, 2026 05:22
d14b3b3 to
2fd9b90Comparefreemandealer
commented
Jun 14, 2026
MemberAuthor
run buildall |
hello-stephen
commented
Jun 14, 2026
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
freemandealer
commented
Jun 17, 2026
MemberAuthor
run buildall |
hello-stephen
commented
Jun 17, 2026
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
freemandealer
commented
Jun 17, 2026
MemberAuthor
run nonConcurrent |
hello-stephen
commented
Jun 17, 2026
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
morningman
approved these changes
Jun 24, 2026
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pick from #64381