Skip to content

branch-4.1: [bug](cloud restore) rewrite table properties and partition info in cloud restore - #64466

Merged
yiguolei merged 1 commit into
apache:branch-4.1from
xy720:fix-restore-dnm-41
Jun 16, 2026
Merged

branch-4.1: [bug](cloud restore) rewrite table properties and partition info in cloud restore#64466
yiguolei merged 1 commit into
apache:branch-4.1from
xy720:fix-restore-dnm-41

Conversation

@xy720

@xy720xy720 commented Jun 12, 2026•
edited
Loading

Copy link
Copy Markdown
Member

What problem does this PR solve?

pick #63696

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@xy720
[bug](cloud restore) rewrite table properties and partition info in c…
5a20db0
…loud restore (apache#63696)
In cloud mode, rewrite all unsupported table properties and some
partition info from the source cluster.
These table properties (e.g., dynamic_partition.replication_num,
dynamic_partition.replication_allocation,
dynamic_partition.storage_policy, in_memory,
storage_medium,min_load_replica_num...) are not applicable in cloud
mode.
And rewrite some non-applicable partition info as well.
If kept, they would cause some critical problems.
For example, dynamic partition scheduler creates new partitions with
source cluster replication settings, leading to write failures like:
"alive replica num < 1 load required replica num 2".
@xy720
xy720 requested a review from yiguolei as a code ownerJune 12, 2026 10:46
@hello-stephen

hello-stephen commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@xy720

xy720 commented Jun 12, 2026

Copy link
Copy Markdown
MemberAuthor

run buildall

@hello-stephen

hello-stephen commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 25.00% (8/32) 🎉
Increment coverage report
Complete coverage report

@xy720

xy720 commented Jun 16, 2026

Copy link
Copy Markdown
MemberAuthor

run feut

@xy720

xy720 commented Jun 16, 2026

Copy link
Copy Markdown
MemberAuthor

run fe_ut

@yiguolei
yiguolei merged commit 6fc573b into apache:branch-4.1Jun 16, 2026
30 of 33 checks passed
@yiguoleiyiguolei mentioned this pull request Jul 7, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguoleiyiguoleiyiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xy720@hello-stephen@yiguolei