Uh oh!
There was an error while loading. Please reload this page.
branch-4.1: [fix](delta writer) Fix shared delta writer state lifetime - #64504
Merged
yiguolei merged 1 commit intoJun 16, 2026
Merged
Conversation
) ### What problem does this PR solve? Issue Number: None Problem Summary: Shared `DeltaWriterV2` instances can be reused by multiple local sinks from the same load. Before this change, the shared writer stored the `RuntimeState*` from the sink that first created it. If that creator sink finished and its `RuntimeState` was destroyed while another local sink continued to reuse the shared writer, `DeltaWriterV2::write()` could access the destroyed state in the memtable flush-limit cancellation path, causing a BE crash or ASAN use-after-free. This PR adds a BE unit test that reproduces the lifetime boundary: - one `VTabletWriterV2` creates the shared `DeltaWriterV2`; - the creator writer and its `RuntimeState` are destroyed without cancelling the shared writer; - a second writer reuses the shared writer and is forced into the `DeltaWriterV2::write()` flush-limit wait path; - the old code reads the destroyed creator state, while the fixed code observes the current writer's cancel state and exits cleanly. The fix removes the stored `RuntimeState*` from `DeltaWriterV2`. The shared writer now keeps only the stable `WorkloadGroup` shared pointer needed by `MemTableWriter` initialization, and `VTabletWriterV2` passes a per-call cancel checker into `DeltaWriterV2::write()` so cancellation is evaluated against the current sink. ### Release note Fix a possible BE crash when shared delta writers are reused by multiple local sinks. (cherry picked from commit c33e1b3)
hello-stephen
commented
Jun 15, 2026
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
bobhan1
marked this pull request as ready for review
June 15, 2026 06:14
bobhan1
commented
Jun 15, 2026
ContributorAuthor
run buildall |
hello-stephen
commented
Jun 15, 2026
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
Jun 15, 2026
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
approved these changes
Jun 16, 2026
Uh oh!
There was an error while loading. Please reload this page.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Backport #64349 to branch-4.1.
Shared
DeltaWriterV2instances can be reused by multiple local sinks from the same load. Before this change, the shared writer stored theRuntimeState*from the sink that first created it. If that creator sink finished and itsRuntimeStatewas destroyed while another local sink continued to reuse the shared writer,DeltaWriterV2::write()could access the destroyed state in the memtable flush-limit cancellation path, causing a BE crash or ASAN use-after-free.This PR removes the stored
RuntimeState*fromDeltaWriterV2. The shared writer keeps only the stableWorkloadGrouppointer needed byMemTableWriterinitialization, andVTabletWriterV2passes a per-call cancel checker intoDeltaWriterV2::write()so cancellation is evaluated against the current sink.Branch-4.1 adaptation:
VTabletWriterV2call site before passing a profile into the shared writer;Check List
git diff HEAD^ HEAD --check./run-be-ut.sh --run --filter=TestVTabletWriterV2.shared_delta_writer_should_not_access_destroyed_creator_runtime_state:DeltaWriterV2PoolTest.* -j100Release note
Fix a possible BE crash when shared delta writers are reused by multiple local sinks.