Uh oh!
There was an error while loading. Please reload this page.
branch-4.0: [fix](test) Make test_analyze_long_string Case 5 stable against sample rows randomness #64408 - #64506
Merged
Merged
Conversation
…e rows randomness (#64408) ## Problem `test_analyze_long_string` Case 5 (and potentially Case 3) can flake because after inserting data, the BE may not have reported the row count to FE yet. When `OlapAnalysisTask.doExecute()` runs with `info.rowCount == 0` and `tableSample != null`, it returns early without executing any SQL — the column finishes with `FINISHED` state but an empty message, so the expected skip reason from the `assert_true` long-string guard is never produced: ``` expected skip reason visible for col big_str, got msg= ==> expected: <true> but was: <false> ``` The audit log confirms that no sampling SQL was issued for `big_str` in the failing run — the task was short-circuited entirely. ## Fix 1. **Suite.groovy**: Add `waitRowCountReady(db, table, expectedRowCount)` that polls `SHOW DATA FROM db.table` via `sql_return_maparray` until the BE-reported row count reaches the expected value. 2. **test_analyze_long_string.groovy**: Call `waitRowCountReady` after inserts for both sample analyze cases: - Case 3 (sample percent 100) - Case 5 (sample rows 3, DUJ1 template) 3. Case 5 data uses `repeat('z', 2048)` for all rows — a secondary defense against sample randomness missing the long row even when row count is properly reported. Co-authored-by: Claude <noreply@anthropic.com>
hello-stephen
commented
Jun 15, 2026
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
hello-stephen
commented
Jun 15, 2026
Contributor
run buildall |
morningman
approved these changes
Jun 24, 2026
ContributorAuthor
PR approved by at least one committer and no changes requested. |
ContributorAuthor
PR approved by anyone and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #64408