Skip to content

branch-4.0: [fix](cloud) Recycle empty rowsets without resource id #64630 - #64642

Merged
morningman merged 1 commit into
branch-4.0from
auto-pick-64630-branch-4.0
Jun 24, 2026
Merged

branch-4.0: [fix](cloud) Recycle empty rowsets without resource id #64630#64642
morningman merged 1 commit into
branch-4.0from
auto-pick-64630-branch-4.0

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Cherry-picked from #64630

@liaoxin01Your Name
[fix](cloud) Recycle empty rowsets without resource id (#64630)
d9dcfd4
When recycling a dropped tablet, empty rowsets may have `num_segments ==
0` and an empty `resource_id`. The protobuf field can be explicitly set
to an empty string, so `has_resource_id()` returns true. The recycler
then attempts to look up an accessor for the empty ID, fails the recycle
round, and repeatedly leaves the dropped tablet/index metadata behind.
This PR skips object deletion for every rowset with zero segments
because it has no segment objects to remove. Rowsets with segments still
require a non-empty resource ID.
@hello-stephen

hello-stephen commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen

hello-stephen commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

run buildall

@hello-stephen

hello-stephen commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 100.00% (6/6) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage78.48% (1845/2351)
Line Coverage65.25% (33129/50771)
Region Coverage65.65% (16325/24866)
Branch Coverage56.28% (8699/15458)

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Jun 24, 2026
@github-actions

github-actionsBot commented Jun 24, 2026

Copy link
Copy Markdown
ContributorAuthor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Jun 24, 2026

Copy link
Copy Markdown
ContributorAuthor

PR approved by anyone and no changes requested.

@morningman
morningman merged commit 8b77d4f into branch-4.0Jun 24, 2026
28 of 31 checks passed
@github-actions
github-actionsBot deleted the auto-pick-64630-branch-4.0 branch June 24, 2026 12:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningmanmorningmanmorningman approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hello-stephen@morningman@liaoxin01