Uh oh!
There was an error while loading. Please reload this page.
branch-4.1: [fix](be) Protect tablet writer map lookup in load channel #64604 - #64752
Merged
Conversation
### What problem does this PR solve? Issue Number: None Related PR: #57133 Problem Summary: `BaseTabletsChannel::_write_block_data` can run concurrently with `incremental_open` for the same tablets channel. `_tablet_writers` is an `std::unordered_map` protected by `_tablet_writers_lock` when writers are inserted, but the tablet load rowset info lookup read the map without holding the lock. A concurrent `emplace` may rehash `_tablet_writers`, so the unlocked lookup can race with bucket reallocation. This patch protects the lookup with `_tablet_writers_lock` and avoids using unordered_map iterators after the lock is released. The actual writer operations still run outside `_tablet_writers_lock`, so the lock remains scoped to the map access.
hello-stephen
commented
Jun 23, 2026
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
hello-stephen
commented
Jun 23, 2026
Contributor
run buildall |
hello-stephen
commented
Jun 23, 2026
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
Jun 23, 2026
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
approved these changes
Jun 24, 2026
yiguolei
commented
Jun 24, 2026
Contributor
skip buildall |
ContributorAuthor
PR approved by at least one committer and no changes requested. |
ContributorAuthor
PR approved by anyone and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #64604