Uh oh!
There was an error while loading. Please reload this page.
branch-4.1: [fix](be) Stop extra operator work after cancellation (#64077) - #64816
Merged
yiguolei merged 1 commit intoJun 26, 2026
Merged
Conversation
hello-stephen
commented
Jun 25, 2026
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
zclllyybb
commented
Jun 25, 2026
ContributorAuthor
run buildall |
yiguolei
previously approved these changes
Jun 25, 2026
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
Problem Summary: Some BE operator paths could keep doing unnecessary work after query cancellation had already been observed by RuntimeState. This covers three focused cases: - Spill revoke and recovery paths could still enter spill or repartition work after cancellation. - Nested loop join build close could still process cross runtime filters after cancellation, scanning build blocks and evaluating filter expressions. - Analytic sink could advance multiple buffered output blocks in one sink call without checking cancellation between blocks. This PR adds cancellation checks at the retained public entry points or block boundaries. The analytic sink change is intentionally conservative: it stops before advancing to another buffered output block, while preserving current-block processing semantics. (cherry picked from commit 11a038d)
zclllyybbforce-pushed
the
codex-pick-64077-branch-4.1
branch
from
June 25, 2026 04:43
c22c539 to
3b5510dComparezclllyybb
commented
Jun 25, 2026
ContributorAuthor
run buildall |
hello-stephen
commented
Jun 25, 2026
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
2 similar comments
hello-stephen
commented
Jun 25, 2026
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
Jun 25, 2026
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
approved these changes
Jun 26, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pick #64077