Uh oh!
There was an error while loading. Please reload this page.
branch-4.1: [fix](scan) Avoid misleading "storage reader" wrapper for data/expression errors #64755 - #64840
Merged
Merged
Conversation
…sion errors (#64755) ## Proposed changes ### Problem When an `INSERT`/`CTAS` (or any query) hits a data-conversion error during scan — e.g. a strict `CAST(... AS BIGINT)` on an empty string produced by `regexp_extract`, which returns `INVALID_ARGUMENT parse number fail, string: ''` — the user-facing error reads: ``` [INVALID_ARGUMENT]parse number fail, string: ''failed to initialize storage reader. tablet=421411554, backend=10.228.1.18 ``` The `failed to initialize storage reader. tablet=...` suffix makes it look like the tablet/segment is corrupted or missing, when the real cause is a data/expression error. ### Root cause `OlapScanner::_open_impl` appended `failed to initialize storage reader. tablet=...` to **any** non-OK status returned by `TabletReader::init()`. But `init()` does not merely set up objects — the merge reader eagerly reads the first block of each rowset (`BlockReader::_init_collect_iter` → `VCollectIterator::build_heap` → `Level0Iterator::refresh_current_row` → `RowsetReader::next_batch`) to seed the merge heap. Pushed-down expressions (`common_expr_ctxs`) are evaluated during that first-block read, so a strict-cast failure surfaces inside `init()` and gets wrapped with the storage-reader message. ### Fix Branch on the error code: only genuine storage-level failures keep the `failed to initialize storage reader` wording. For `INVALID_ARGUMENT` (data/expression errors) the message stays neutral and explicitly notes it is a data/expression error rather than a storage failure, while still reporting tablet/backend for locating the node. This is purely a message/diagnostics change; control flow and the returned error code are unchanged. The underlying strict-cast semantics issue is tracked separately (see #64266). ## Further comments No behavior change other than the error text; no new tests added.
yiguolei
approved these changes
Jun 25, 2026
yiguolei
commented
Jun 25, 2026
Contributor
run buildall |
ContributorAuthor
PR approved by at least one committer and no changes requested. |
ContributorAuthor
PR approved by anyone and no changes requested. |
hello-stephen
commented
Jun 25, 2026
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
Jun 25, 2026
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
commented
Jun 26, 2026
Contributor
skip buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #64755