Uh oh!
There was an error while loading. Please reload this page.
branch-4.1: [fix](be) catch block serialization exceptions to avoid coredump #64852 - #65003
Merged
Conversation
) ### What problem does this PR solve? Block serialization calculated datatype serialized size and serialized column data without converting Doris exceptions to Status. When a string column exceeded the LZ4 input limit, DataTypeString threw BUFFER_OVERFLOW from get_uncompressed_serialized_bytes and the async tablet-writer send thread could terminate unexpectedly: ``` W20260625 15:10:05.374955 27425 data_type_string.cpp:92] DataTypeString serialized byte size exceeds LZ4 max input size, bytes=4245568000, LZ4_MAX_INPUT_SIZE=2113929216, rows=4000, real_need_copy_num=4000 W20260625 15:10:05.377851 27425 exception.cpp:34] meet exception, error code: -204, message: LZ4_compressBound meet invalid input size, input_size=4245568000, LZ4_MAX_INPUT_SIZE=2113929216 0# doris::Exception::Exception(int, std::basic_string_view<char, std::char_traits<char> > const&, bool) at ./be/build_RELEASE/../src/common/exception.cpp:0 1# doris::Exception::Exception(int, std::basic_string_view<char, std::char_traits<char> > const&) at /usr/local/ldb-toolchain-v0.26/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/bits/basic_string.h:239 2# doris::Exception::Exception<unsigned long&, int>(int, std::basic_string_view<char, std::char_traits<char> > const&, unsigned long&, int&&) at /usr/local/ldb-toolchain-v0.26/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/bits/basic_string.h:239 3# doris::DataTypeString::get_uncompressed_serialized_bytes(doris::IColumn const&, int) const at ./be/build_RELEASE/../src/core/data_type/data_type_string.cpp:96 4# doris::DataTypeNullable::get_uncompressed_serialized_bytes(doris::IColumn const&, int) const at ./be/build_RELEASE/../src/core/data_type/data_type_nullable.cpp:75 5# doris::Block::serialize(int, doris::PBlock*, unsigned long*, unsigned long*, long*, doris::segment_v2::CompressionTypePB, bool) const at ./be/build_RELEASE/../src/core/block/block.cpp:1022 6# doris::VNodeChannel::try_send_pending_block(doris::RuntimeState*) at ./be/build_RELEASE/../src/exec/sink/writer/vtablet_writer.cpp:940 7# doris::ThreadPool::dispatch_thread() at /usr/local/ldb-toolchain-v0.26/bin/../lib/gcc/x86_64-pc-linux-gnu/15/include/g++-v15/bits/shared_ptr_base.h:1097 8# doris::Thread::supervise_thread(void*) at /usr/local/ldb-toolchain-v0.26/bin/../usr/include/pthread.h:562 9# ? 10# ? ``` Catch datatype serialization exceptions in Block::serialize so callers receive a failed Status and cancel the load normally.
hello-stephen
commented
Jun 30, 2026
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
hello-stephen
commented
Jun 30, 2026
Contributor
run buildall |
yiguolei
commented
Jun 30, 2026
Contributor
skip buildall |
yiguolei
approved these changes
Jun 30, 2026
ContributorAuthor
PR approved by at least one committer and no changes requested. |
ContributorAuthor
PR approved by anyone and no changes requested. |
yiguolei
commented
Jun 30, 2026
Contributor
skip buildall |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #64852