[fix](agg) Normalize equivalent multi-column distinct counts

[feiniaofeiafei]

What problem does this PR solve?

Issue Number: None

Related PR: #54079

Problem Summary: NormalizeAggregate treated reordered equivalent multi-column COUNT DISTINCT expressions as different aggregate functions, which could make the multi-distinct strategy construct a join from only one aggregate and fail with an index-out-of-bounds exception. It also retained duplicate arguments even though downstream COUNT DISTINCT processing treats them as a set, and the CountIf conversion indexed the original argument list using the deduplicated size. Canonicalize multi-column distinct arguments as an ordered set during normalization and make CountIf consume that deduplicated list directly.

Release note

Fix planning and execution of equivalent multi-column COUNT DISTINCT expressions with reordered or duplicate arguments.

Check List (For Author)

• Test: Unit Test
  • ./run-fe-ut.sh --run org.apache.doris.nereids.rules.analysis.NormalizeMultiColumnDistinctCountTest
• Behavior changed: Yes, reordered and duplicate multi-column COUNT DISTINCT arguments now share the correct aggregate computation
• Does this need documentation: No

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

• Test

  • Regression test
  • Unit Test
  • Manual test (add detailed scripts or steps below)
  • No need to test or manual test. Explain why:
    • This is a refactor/code format and no logic has been changed.
    • Previous test can cover this change.
    • No code files have been changed.
    • Other reason

• Behavior changed:

  • No.
  • Yes.

• Does this need documentation?

  • No.
  • Yes.

Check List (For Reviewer who merge this PR)

• Confirm the release note
• Confirm test cases
• Confirm document
• Add branch pick label

[hello-stephen]

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
3. What features were added. Why was this function added?
4. Which code was refactored and why was this part of the code refactored?
5. Which functions were optimized and what is the difference before and after the optimization?

[feiniaofeiafei]

run buildall

[hello-stephen]

FE UT Coverage Report

Increment line coverage 100.00% (18/18) 🎉
Increment coverage report
Complete coverage report

[hello-stephen]

FE Regression Coverage Report

Increment line coverage 6.82% (3/44) 🎉
Increment coverage report
Complete coverage report

[feiniaofeiafei]

run nonConcurrent

[feiniaofeiafei]

run buildall

[hello-stephen]

FE UT Coverage Report

Increment line coverage 100.00% (18/18) 🎉
Increment coverage report
Complete coverage report

[morrySnow]

Use LinkedHashSet

[feiniaofeiafei]

run buildall

[hello-stephen]

FE UT Coverage Report

Increment line coverage 100.00% (18/18) 🎉
Increment coverage report
Complete coverage report

[hello-stephen]

TPC-H: Total hot run time: 29615 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a72867549eebef66eb39cfc77332bacc1773cbb8, data reload: false
------ Round 1 ----------------------------------
============================================
q1	17605	4134	4113	4113
q2	2084	338	201	201
q3	10253	1428	829	829
q4	4680	473	344	344
q5	7517	855	565	565
q6	182	169	137	137
q7	740	823	611	611
q8	9325	1702	1613	1613
q9	5495	4341	4295	4295
q10	6746	1722	1509	1509
q11	511	353	312	312
q12	700	547	449	449
q13	18110	3426	2720	2720
q14	271	256	239	239
q15	q16	785	777	706	706
q17	986	1008	1022	1008
q18	6934	5705	5675	5675
q19	1312	1276	1084	1084
q20	770	628	539	539
q21	5854	2558	2371	2371
q22	435	358	295	295
Total cold run time: 101295 ms
Total hot run time: 29615 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4432	4407	4362	4362
q2	285	314	216	216
q3	4565	4932	4386	4386
q4	2084	2159	1373	1373
q5	4413	4293	4259	4259
q6	227	173	125	125
q7	1773	1822	1906	1822
q8	2609	2216	2207	2207
q9	8045	8074	7761	7761
q10	4739	4655	4230	4230
q11	583	421	415	415
q12	768	766	570	570
q13	3303	3591	2920	2920
q14	296	301	273	273
q15	q16	697	741	640	640
q17	1379	1339	1404	1339
q18	8032	7341	7330	7330
q19	1159	1074	1069	1069
q20	2201	2206	1946	1946
q21	5319	4583	4547	4547
q22	539	457	403	403
Total cold run time: 57448 ms
Total hot run time: 52193 ms

[hello-stephen]

TPC-DS: Total hot run time: 178239 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a72867549eebef66eb39cfc77332bacc1773cbb8, data reload: false
query5	4309	647	491	491
query6	476	220	199	199
query7	4834	555	359	359
query8	351	187	173	173
query9	8775	4105	4103	4103
query10	476	365	295	295
query11	5793	2327	2161	2161
query12	156	98	98	98
query13	1254	579	409	409
query14	6211	5264	4884	4884
query14_1	4268	4255	4236	4236
query15	210	202	181	181
query16	1020	476	448	448
query17	914	718	570	570
query18	2428	470	341	341
query19	215	192	153	153
query20	111	106	105	105
query21	225	159	138	138
query22	13525	13523	13409	13409
query23	17397	16477	16168	16168
query23_1	16219	16183	16198	16183
query24	7451	1768	1300	1300
query24_1	1314	1297	1323	1297
query25	570	461	399	399
query26	1318	350	206	206
query27	2612	627	395	395
query28	4506	1992	2026	1992
query29	1092	622	508	508
query30	345	260	224	224
query31	1114	1106	1001	1001
query32	114	64	61	61
query33	582	348	259	259
query34	1168	1159	661	661
query35	764	791	670	670
query36	1198	1197	1056	1056
query37	151	107	96	96
query38	1874	1717	1666	1666
query39	893	863	849	849
query39_1	821	846	855	846
query40	255	167	151	151
query41	75	69	71	69
query42	95	96	91	91
query43	325	324	282	282
query44	1468	790	777	777
query45	200	183	179	179
query46	1118	1213	722	722
query47	2163	2126	2012	2012
query48	430	417	322	322
query49	610	421	319	319
query50	1078	430	349	349
query51	10742	10739	10885	10739
query52	89	88	75	75
query53	272	281	207	207
query54	295	255	236	236
query55	82	74	77	74
query56	329	314	316	314
query57	1322	1305	1210	1210
query58	298	286	271	271
query59	1588	1685	1431	1431
query60	333	278	267	267
query61	179	196	148	148
query62	540	494	433	433
query63	237	209	207	207
query64	2812	1072	846	846
query65	4684	4701	4818	4701
query66	1813	497	363	363
query67	29268	29195	29052	29052
query68	3187	1593	925	925
query69	418	304	266	266
query70	1075	981	958	958
query71	348	321	303	303
query72	3104	2774	2234	2234
query73	828	784	439	439
query74	5077	4890	4737	4737
query75	2522	2490	2131	2131
query76	2336	1191	787	787
query77	354	381	287	287
query78	12055	11808	11300	11300
query79	1360	1175	733	733
query80	1346	552	449	449
query81	533	322	275	275
query82	572	158	118	118
query83	443	317	291	291
query84	353	156	131	131
query85	985	608	510	510
query86	426	300	284	284
query87	1821	1822	1764	1764
query88	3734	2820	2785	2785
query89	454	394	325	325
query90	1913	209	201	201
query91	200	197	160	160
query92	68	64	56	56
query93	1559	1537	939	939
query94	721	359	326	326
query95	795	493	495	493
query96	1027	838	364	364
query97	2626	2617	2504	2504
query98	212	206	201	201
query99	1092	1095	975	975
Total cold run time: 263733 ms
Total hot run time: 178239 ms

[hello-stephen]

ClickBench: Total hot run time: 25.07 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a72867549eebef66eb39cfc77332bacc1773cbb8, data reload: false
query1	0.01	0.01	0.01
query2	0.10	0.05	0.05
query3	0.26	0.14	0.13
query4	1.61	0.15	0.13
query5	0.28	0.22	0.23
query6	1.22	1.08	1.10
query7	0.03	0.01	0.00
query8	0.06	0.04	0.04
query9	0.38	0.33	0.31
query10	0.56	0.55	0.55
query11	0.19	0.14	0.15
query12	0.19	0.15	0.16
query13	0.48	0.48	0.49
query14	1.03	1.01	1.01
query15	0.61	0.60	0.60
query16	0.31	0.33	0.33
query17	1.09	1.10	1.14
query18	0.23	0.22	0.22
query19	2.03	2.00	1.96
query20	0.02	0.01	0.01
query21	15.42	0.24	0.15
query22	4.65	0.05	0.05
query23	16.10	0.32	0.13
query24	2.96	0.43	0.30
query25	0.11	0.05	0.05
query26	0.74	0.22	0.16
query27	0.05	0.03	0.03
query28	3.47	0.99	0.57
query29	12.48	4.08	3.22
query30	0.28	0.16	0.15
query31	2.77	0.60	0.31
query32	3.23	0.60	0.49
query33	3.13	3.15	3.23
query34	15.74	4.19	3.50
query35	3.56	3.57	3.51
query36	0.54	0.45	0.42
query37	0.09	0.07	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.03
query40	0.17	0.15	0.15
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.05	0.04	0.03
Total cold run time: 96.44 s
Total hot run time: 25.07 s

[feiniaofeiafei]

run buildall

[hello-stephen]

TPC-H: Total hot run time: 29457 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2048602cbaea9b28ea5d6efeb78f863d22f24d21, data reload: false
------ Round 1 ----------------------------------
============================================
q1	17701	4057	4032	4032
q2	2028	316	203	203
q3	10301	1467	845	845
q4	4677	469	344	344
q5	7557	846	575	575
q6	178	168	138	138
q7	741	822	605	605
q8	9424	1478	1502	1478
q9	5592	4353	4338	4338
q10	6841	1757	1527	1527
q11	515	358	315	315
q12	711	552	439	439
q13	18117	3405	2758	2758
q14	265	269	237	237
q15	q16	793	772	712	712
q17	909	914	1023	914
q18	7178	5839	5512	5512
q19	1330	1215	1001	1001
q20	775	634	495	495
q21	6276	2831	2681	2681
q22	447	366	308	308
Total cold run time: 102356 ms
Total hot run time: 29457 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1	5382	4827	4742	4742
q2	294	337	223	223
q3	4990	5284	4717	4717
q4	2064	2153	1359	1359
q5	4773	4792	4585	4585
q6	227	177	127	127
q7	1883	1848	1537	1537
q8	2382	2167	2061	2061
q9	7574	7273	7078	7078
q10	4586	4575	4127	4127
q11	523	378	348	348
q12	734	743	530	530
q13	3059	3355	2741	2741
q14	266	280	262	262
q15	q16	673	691	598	598
q17	1267	1242	1237	1237
q18	7481	6887	6833	6833
q19	1058	1029	1075	1029
q20	2178	2190	1939	1939
q21	5219	4536	4418	4418
q22	520	466	395	395
Total cold run time: 57133 ms
Total hot run time: 50886 ms

[hello-stephen]

TPC-DS: Total hot run time: 177435 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2048602cbaea9b28ea5d6efeb78f863d22f24d21, data reload: false
query5	4319	623	488	488
query6	464	216	226	216
query7	4832	568	326	326
query8	336	182	172	172
query9	8766	4016	4027	4016
query10	466	348	322	322
query11	5904	2323	2098	2098
query12	166	108	99	99
query13	1270	599	437	437
query14	6197	5207	4933	4933
query14_1	4264	4213	4261	4213
query15	216	198	180	180
query16	984	479	438	438
query17	937	730	620	620
query18	2439	463	355	355
query19	212	193	152	152
query20	111	112	107	107
query21	237	156	132	132
query22	13440	13445	13446	13445
query23	17418	16543	16061	16061
query23_1	16155	16125	16161	16125
query24	7646	1741	1279	1279
query24_1	1323	1281	1278	1278
query25	581	460	386	386
query26	1330	357	219	219
query27	2591	582	399	399
query28	4431	2011	1961	1961
query29	1097	611	496	496
query30	340	264	232	232
query31	1124	1094	977	977
query32	108	65	61	61
query33	534	327	273	273
query34	1185	1120	661	661
query35	769	782	664	664
query36	1221	1209	1063	1063
query37	150	146	99	99
query38	1864	1700	1635	1635
query39	901	859	849	849
query39_1	844	818	824	818
query40	248	159	136	136
query41	65	61	66	61
query42	101	90	91	90
query43	320	318	275	275
query44	1404	761	775	761
query45	193	179	170	170
query46	1018	1178	706	706
query47	2136	2109	2002	2002
query48	394	413	297	297
query49	578	430	310	310
query50	1010	450	314	314
query51	10605	10829	10633	10633
query52	82	84	71	71
query53	254	276	198	198
query54	291	244	228	228
query55	75	70	67	67
query56	299	290	284	284
query57	1329	1296	1231	1231
query58	289	257	259	257
query59	1546	1643	1392	1392
query60	307	259	246	246
query61	160	149	150	149
query62	539	500	434	434
query63	240	200	198	198
query64	2832	1033	891	891
query65	4709	4631	4643	4631
query66	1851	496	371	371
query67	28788	29275	29107	29107
query68	3058	1563	946	946
query69	436	299	303	299
query70	1054	942	940	940
query71	339	302	300	300
query72	3124	2721	2519	2519
query73	822	739	410	410
query74	5048	4929	4734	4734
query75	2527	2503	2127	2127
query76	2313	1161	792	792
query77	352	385	273	273
query78	11959	11889	11346	11346
query79	1385	1139	727	727
query80	1298	535	461	461
query81	531	327	278	278
query82	607	161	125	125
query83	367	314	289	289
query84	325	161	129	129
query85	953	575	508	508
query86	419	314	263	263
query87	1824	1852	1745	1745
query88	3736	2783	2791	2783
query89	430	368	329	329
query90	1913	193	197	193
query91	201	186	164	164
query92	64	56	57	56
query93	1709	1480	953	953
query94	726	365	324	324
query95	780	470	469	469
query96	1008	835	352	352
query97	2630	2618	2487	2487
query98	212	206	196	196
query99	1079	1112	979	979
Total cold run time: 262377 ms
Total hot run time: 177435 ms

[hello-stephen]

ClickBench: Total hot run time: 24.88 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2048602cbaea9b28ea5d6efeb78f863d22f24d21, data reload: false
query1	0.01	0.01	0.00
query2	0.10	0.05	0.05
query3	0.25	0.14	0.13
query4	1.61	0.14	0.13
query5	0.24	0.22	0.23
query6	1.26	1.07	1.06
query7	0.04	0.01	0.01
query8	0.05	0.03	0.03
query9	0.41	0.31	0.30
query10	0.56	0.54	0.55
query11	0.18	0.14	0.14
query12	0.18	0.14	0.15
query13	0.47	0.47	0.46
query14	1.02	1.02	1.01
query15	0.62	0.59	0.60
query16	0.31	0.32	0.32
query17	1.08	1.12	1.12
query18	0.23	0.23	0.21
query19	2.03	1.87	1.91
query20	0.02	0.01	0.01
query21	15.46	0.21	0.15
query22	4.91	0.06	0.05
query23	16.11	0.32	0.12
query24	2.92	0.41	0.32
query25	0.10	0.06	0.04
query26	0.73	0.22	0.15
query27	0.05	0.04	0.04
query28	3.49	0.89	0.57
query29	12.54	4.05	3.17
query30	0.29	0.16	0.15
query31	2.79	0.59	0.31
query32	3.22	0.60	0.48
query33	3.23	3.17	3.16
query34	15.51	4.19	3.51
query35	3.55	3.54	3.56
query36	0.57	0.43	0.42
query37	0.09	0.06	0.06
query38	0.05	0.05	0.03
query39	0.04	0.03	0.03
query40	0.18	0.16	0.15
query41	0.08	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 96.66 s
Total hot run time: 24.88 s

[hello-stephen]

FE Regression Coverage Report

Increment line coverage 46.15% (18/39) 🎉
Increment coverage report
Complete coverage report

[feiniaofeiafei]

/review

[feiniaofeiafei]

run buildall

[hello-stephen]

FE UT Coverage Report

Increment line coverage 100.00% (20/20) 🎉
Increment coverage report
Complete coverage report

[feiniaofeiafei]

run performance

[englefly]

/review

[hello-stephen]

TPC-H: Total hot run time: 29828 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 77ef2e30111e065e92b4ce9437d627790a0d791f, data reload: false
------ Round 1 ----------------------------------
============================================
q1	17662	4113	4276	4113
q2	2003	326	203	203
q3	10287	1412	815	815
q4	4682	468	339	339
q5	7607	849	563	563
q6	177	169	138	138
q7	760	828	612	612
q8	9923	1647	1557	1557
q9	6183	4375	4401	4375
q10	6796	1769	1467	1467
q11	504	338	323	323
q12	740	587	464	464
q13	18139	3313	2772	2772
q14	271	257	238	238
q15	q16	782	772	706	706
q17	1046	904	992	904
q18	7085	5811	5792	5792
q19	1451	1322	1116	1116
q20	791	640	570	570
q21	5812	2557	2468	2468
q22	446	362	293	293
Total cold run time: 103147 ms
Total hot run time: 29828 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4455	4395	4375	4375
q2	285	311	208	208
q3	4610	4948	4396	4396
q4	2062	2167	1365	1365
q5	4435	4271	4275	4271
q6	228	184	125	125
q7	2112	1870	1652	1652
q8	2526	2170	2130	2130
q9	7939	7776	7718	7718
q10	4693	4638	4220	4220
q11	768	421	384	384
q12	760	780	545	545
q13	3294	3619	3058	3058
q14	309	308	275	275
q15	q16	703	745	656	656
q17	1356	1342	1347	1342
q18	7963	7443	6915	6915
q19	1135	1089	1094	1089
q20	2228	2219	1953	1953
q21	5255	4612	4470	4470
q22	522	453	397	397
Total cold run time: 57638 ms
Total hot run time: 51544 ms

[hello-stephen]

TPC-DS: Total hot run time: 176210 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 77ef2e30111e065e92b4ce9437d627790a0d791f, data reload: false
query5	4318	634	482	482
query6	456	221	205	205
query7	4841	583	371	371
query8	341	186	169	169
query9	8757	4052	4016	4016
query10	451	362	289	289
query11	5887	2369	2129	2129
query12	156	103	109	103
query13	1319	607	443	443
query14	6259	5213	4880	4880
query14_1	4268	4247	4241	4241
query15	217	201	178	178
query16	1028	458	432	432
query17	1106	687	570	570
query18	2468	486	337	337
query19	204	181	145	145
query20	111	106	109	106
query21	233	158	131	131
query22	13591	13580	13261	13261
query23	17357	16551	16095	16095
query23_1	16219	16279	16241	16241
query24	7521	1767	1248	1248
query24_1	1282	1287	1234	1234
query25	547	436	356	356
query26	1313	353	205	205
query27	2640	553	380	380
query28	4419	1963	1961	1961
query29	1088	600	456	456
query30	336	258	222	222
query31	1119	1080	976	976
query32	119	60	56	56
query33	511	316	237	237
query34	1165	1118	629	629
query35	760	783	668	668
query36	1222	1222	1028	1028
query37	149	105	95	95
query38	1881	1695	1676	1676
query39	874	894	870	870
query39_1	836	840	847	840
query40	248	161	143	143
query41	67	67	63	63
query42	91	90	88	88
query43	319	324	279	279
query44	1393	757	754	754
query45	192	182	175	175
query46	1062	1160	717	717
query47	2136	2141	2009	2009
query48	396	373	285	285
query49	571	412	325	325
query50	1089	408	353	353
query51	10521	10518	10423	10423
query52	86	85	79	79
query53	262	279	201	201
query54	282	228	223	223
query55	73	70	70	70
query56	298	302	287	287
query57	1321	1312	1194	1194
query58	277	251	250	250
query59	1620	1694	1418	1418
query60	321	294	264	264
query61	177	172	174	172
query62	560	507	430	430
query63	252	203	205	203
query64	2951	1163	974	974
query65	4743	4598	4614	4598
query66	1831	520	392	392
query67	29412	29317	28492	28492
query68	3058	1594	980	980
query69	419	306	285	285
query70	1081	950	901	901
query71	388	334	333	333
query72	3170	2639	2300	2300
query73	857	784	446	446
query74	5127	4913	4719	4719
query75	2528	2500	2120	2120
query76	2340	1159	737	737
query77	344	370	266	266
query78	11797	11995	11233	11233
query79	1443	1134	753	753
query80	1278	532	492	492
query81	530	329	289	289
query82	603	152	120	120
query83	370	323	294	294
query84	285	155	133	133
query85	962	600	505	505
query86	433	283	277	277
query87	1835	1831	1780	1780
query88	3718	2761	2784	2761
query89	447	381	329	329
query90	1880	201	186	186
query91	200	189	157	157
query92	62	64	53	53
query93	1692	1482	979	979
query94	724	344	272	272
query95	804	581	466	466
query96	1051	774	331	331
query97	2636	2610	2492	2492
query98	211	203	203	203
query99	1095	1116	954	954
Total cold run time: 264413 ms
Total hot run time: 176210 ms

[hello-stephen]

ClickBench: Total hot run time: 25.08 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 77ef2e30111e065e92b4ce9437d627790a0d791f, data reload: false
query1	0.01	0.01	0.01
query2	0.10	0.05	0.05
query3	0.25	0.13	0.13
query4	1.61	0.14	0.14
query5	0.24	0.22	0.22
query6	1.22	1.13	1.11
query7	0.04	0.01	0.01
query8	0.06	0.03	0.04
query9	0.40	0.30	0.31
query10	0.55	0.56	0.55
query11	0.20	0.13	0.14
query12	0.18	0.13	0.15
query13	0.47	0.48	0.48
query14	1.02	1.00	1.01
query15	0.62	0.60	0.60
query16	0.30	0.32	0.33
query17	1.11	1.06	1.04
query18	0.23	0.21	0.23
query19	2.02	1.99	1.92
query20	0.02	0.01	0.01
query21	15.42	0.22	0.13
query22	4.77	0.06	0.06
query23	16.15	0.31	0.12
query24	3.02	0.42	0.33
query25	0.12	0.06	0.05
query26	0.74	0.20	0.14
query27	0.04	0.04	0.03
query28	3.54	0.91	0.56
query29	12.48	4.06	3.28
query30	0.28	0.15	0.15
query31	2.77	0.60	0.31
query32	3.23	0.59	0.50
query33	3.12	3.21	3.28
query34	15.50	4.24	3.52
query35	3.55	3.53	3.51
query36	0.56	0.45	0.42
query37	0.09	0.07	0.07
query38	0.05	0.04	0.04
query39	0.03	0.03	0.03
query40	0.20	0.16	0.15
query41	0.08	0.03	0.02
query42	0.04	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 96.47 s
Total hot run time: 25.08 s

[github-actions]

Automated code review: request changes.

The intended scalar canonicalization is reasonable for supported ordinary grouped/global paths, but four blocking correctness or error-contract regressions remain:

1. Duplicate BITMAP/HLL arguments can become a unary union aggregate instead of preserving the unsupported multi-argument error.
2. Traversal through WindowExpression can make an unrelated grouped aggregate bypass the documented multi-argument analytic COUNT error.
3. Sharing reordered Counts newly enables a hint-supported join pushdown that assumes a sole aggregate is unary and builds an invalid Count/slot set.
4. The same sharing can make AGG_KEYS scan preaggregation depend on the retained argument order and expose partial aggregate-value rows to tuple-distinct counting.

Review convergence: incomplete under the prescribed three-round limit. Round 3 found the fourth issue; an independent downstream pass confirmed it and found no fifth issue, but a new valuable round-3 candidate means the required all-reviewer NO_NEW_VALUABLE_FINDINGS state was not reached. All four findings were independently validated and deduplicated before submission.

Critical checkpoints:

• Goal, scope, and tests: the four-file change is focused and the normal duplicate/reordered scalar paths are covered, but the new traversal, arity changes, and structural sharing escape into unsupported type, window, join-pushdown, and storage-preaggregation paths that lack regression coverage.
• Compatibility and error behavior: two established errors become accepted but semantically different operations; the other two paths can build an invalid plan or return a wrong distinct cardinality.
• Parallel paths: ordinary grouped/global and forced aggregate-phase paths use compatible canonical arguments; the window, BITMAP/HLL, hinted join, and AGG_KEYS preaggregation paths do not.
• Concurrency, lifecycle, configuration, persistence, data writes, and protocol compatibility: not involved by this FE rewrite change.
• Performance and observability: the local map/set work is bounded by aggregate output size and raises no standalone concern; no new observability surface is involved.
• User focus: no additional review focus was provided, so the full authoritative patch was reviewed.

Validation was static only because the review contract prohibited local builds/tests. At the reviewed head, COMPILE, FE UT, BE UT, Cloud UT, external/nonconcurrent/cloud/vault regressions, formatter/license, and performance are successful. P0 regression remains pending. check_coverage_fe is failed, but its TeamCity log is not accessible here, so no code-level cause could be verified.

[feiniaofeiafei]

/review

[feiniaofeiafei]

run buildall

[hello-stephen]

TPC-H: Total hot run time: 29285 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 21144268db084c2298782a6e50f75272fdf5d44b, data reload: false
------ Round 1 ----------------------------------
============================================
q1	17878	4177	4043	4043
q2	1999	317	199	199
q3	10323	1366	781	781
q4	4683	466	331	331
q5	7493	830	557	557
q6	203	169	138	138
q7	740	824	602	602
q8	10049	1490	1476	1476
q9	5805	4277	4318	4277
q10	6914	1743	1465	1465
q11	506	356	321	321
q12	740	585	451	451
q13	18128	3697	2744	2744
q14	269	263	242	242
q15	q16	783	769	704	704
q17	1181	994	1006	994
q18	6985	5694	5513	5513
q19	1630	1231	1042	1042
q20	789	691	598	598
q21	5878	2512	2530	2512
q22	416	345	295	295
Total cold run time: 103392 ms
Total hot run time: 29285 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4456	4351	4352	4351
q2	273	315	217	217
q3	4563	4963	4382	4382
q4	2048	2144	1355	1355
q5	4373	4267	4304	4267
q6	227	176	126	126
q7	1820	2065	1610	1610
q8	2569	2293	2211	2211
q9	7872	7793	7734	7734
q10	4666	4640	4204	4204
q11	577	442	378	378
q12	733	759	530	530
q13	3475	3623	2960	2960
q14	312	309	275	275
q15	q16	742	753	645	645
q17	1405	1292	1365	1292
q18	8095	7312	7109	7109
q19	1102	1065	1099	1065
q20	2228	2217	1934	1934
q21	5246	4579	4388	4388
q22	509	452	417	417
Total cold run time: 57291 ms
Total hot run time: 51450 ms

[hello-stephen]

TPC-DS: Total hot run time: 177283 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 21144268db084c2298782a6e50f75272fdf5d44b, data reload: false
query5	4325	635	489	489
query6	457	217	196	196
query7	4828	575	346	346
query8	339	198	172	172
query9	8763	3946	4063	3946
query10	478	364	304	304
query11	5909	2318	2156	2156
query12	162	105	111	105
query13	1265	603	431	431
query14	6278	5226	4875	4875
query14_1	4254	4231	4227	4227
query15	216	205	176	176
query16	1045	474	371	371
query17	1117	743	583	583
query18	2680	470	359	359
query19	211	190	174	174
query20	109	106	108	106
query21	228	156	132	132
query22	13608	13584	13308	13308
query23	17294	16447	16122	16122
query23_1	16274	16160	16167	16160
query24	7982	1720	1278	1278
query24_1	1339	1286	1281	1281
query25	530	437	346	346
query26	1324	369	206	206
query27	2570	591	383	383
query28	4409	1942	1924	1924
query29	1046	614	464	464
query30	344	270	229	229
query31	1110	1099	983	983
query32	111	59	60	59
query33	521	307	246	246
query34	1145	1150	651	651
query35	757	786	658	658
query36	1202	1183	1080	1080
query37	149	103	85	85
query38	1885	1702	1664	1664
query39	892	881	840	840
query39_1	831	831	864	831
query40	249	162	146	146
query41	65	63	64	63
query42	94	95	91	91
query43	319	331	279	279
query44	1390	777	756	756
query45	197	189	176	176
query46	1077	1182	721	721
query47	2149	2126	1973	1973
query48	423	425	285	285
query49	585	419	335	335
query50	1024	426	340	340
query51	10826	11158	10877	10877
query52	86	87	75	75
query53	255	268	195	195
query54	281	239	213	213
query55	71	69	65	65
query56	296	287	284	284
query57	1317	1287	1183	1183
query58	283	261	243	243
query59	1582	1682	1431	1431
query60	303	282	251	251
query61	155	150	149	149
query62	542	496	430	430
query63	235	201	201	201
query64	2810	1040	837	837
query65	4760	4650	4613	4613
query66	1784	497	377	377
query67	29020	29246	29152	29152
query68	3205	1608	945	945
query69	416	290	282	282
query70	1070	952	955	952
query71	389	334	303	303
query72	3031	2664	2386	2386
query73	814	743	454	454
query74	5039	4931	4778	4778
query75	2529	2599	2124	2124
query76	2332	1151	782	782
query77	356	375	284	284
query78	11817	11768	11170	11170
query79	1201	1145	758	758
query80	616	552	456	456
query81	471	345	289	289
query82	229	156	120	120
query83	315	323	297	297
query84	280	157	129	129
query85	908	627	512	512
query86	313	284	277	277
query87	1813	1820	1772	1772
query88	3706	2780	2778	2778
query89	422	399	326	326
query90	2163	197	196	196
query91	201	184	159	159
query92	61	61	54	54
query93	1510	1579	1037	1037
query94	540	341	312	312
query95	798	501	544	501
query96	1038	891	322	322
query97	2634	2605	2526	2526
query98	215	212	208	208
query99	1099	1120	962	962
Total cold run time: 261985 ms
Total hot run time: 177283 ms

[hello-stephen]

ClickBench: Total hot run time: 25.02 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 21144268db084c2298782a6e50f75272fdf5d44b, data reload: false
query1	0.01	0.01	0.01
query2	0.10	0.05	0.05
query3	0.24	0.14	0.14
query4	1.61	0.14	0.14
query5	0.24	0.23	0.21
query6	1.27	1.10	1.03
query7	0.04	0.00	0.00
query8	0.06	0.04	0.04
query9	0.41	0.33	0.31
query10	0.55	0.56	0.53
query11	0.19	0.14	0.14
query12	0.18	0.14	0.14
query13	0.47	0.47	0.48
query14	1.05	1.01	0.99
query15	0.61	0.59	0.60
query16	0.30	0.32	0.32
query17	1.10	1.13	1.10
query18	0.22	0.22	0.21
query19	1.98	1.97	1.98
query20	0.01	0.02	0.01
query21	15.42	0.21	0.13
query22	4.86	0.05	0.06
query23	16.12	0.32	0.12
query24	2.91	0.43	0.33
query25	0.11	0.06	0.04
query26	0.71	0.21	0.15
query27	0.05	0.03	0.04
query28	3.52	0.96	0.52
query29	12.50	4.18	3.27
query30	0.28	0.15	0.17
query31	2.77	0.59	0.32
query32	3.23	0.59	0.48
query33	3.16	3.19	3.18
query34	15.77	4.28	3.52
query35	3.54	3.51	3.57
query36	0.55	0.44	0.44
query37	0.09	0.07	0.06
query38	0.05	0.04	0.04
query39	0.04	0.03	0.03
query40	0.18	0.17	0.16
query41	0.08	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 96.66 s
Total hot run time: 25.02 s

[924060929]

/review

[github-actions]

Automated code review: request changes.

The current head fixes the previously reported join-pushdown invalid-arity path by requiring unary aggregates, but three blocking correctness/error-contract issues in the existing inline threads remain unresolved:

1. Duplicate BITMAP/HLL arguments can become unary union aggregates instead of preserving the unsupported multi-argument error.
2. Recursive normalization through WindowExpression can bypass the documented multi-argument analytic COUNT error.
3. Sharing reordered Counts can make AGG_KEYS preaggregation validate only the retained first child and expose partial aggregate-value rows, producing a wrong distinct cardinality.

This review also adds one new inline test-coverage issue: the changed success regressions are bare sql statements and never assert the returned counts or nullable CountIf behavior.

Critical checkpoints:

• Goal and data correctness: ordinary deterministic grouped/global split paths share equivalent Counts and preserve the unique argument set and null semantics, but the three unresolved special paths above mean the PR is not yet safe.
• Scope and clarity: the five-file change is focused; the local map/set work is linear in small aggregate outputs and reduces redundant aggregate state.
• Parallel paths and compatibility: join pushdown is now safely unary; logical/physical distinct splitting and phases 1-4 use the full deduplicated set; the window, BITMAP/HLL, and AGG_KEYS preaggregation paths remain incompatible or incorrect.
• Tests: FE UT and P0 regression are green, but the new Groovy cases have no result oracle, and the unresolved window/type/preaggregation cases lack protecting regressions. check_coverage_fe is currently failing.
• Concurrency, lifecycle, configuration, persistence, transactions, data writes, protocol compatibility, FE/BE variable passing, and observability: not involved.
• User focus: no additional focus was provided; the full authoritative patch was reviewed.

Validation was static only because the review contract prohibits local builds/tests; .worktree_initialized and thirdparty/installed/bin/protoc are absent. Current GitHub checks are otherwise broadly green, including compile, FE/BE/Cloud unit tests, P0/external/cloud/vault regressions, style/license, and performance.

Review convergence: all normal and risk-focused reviewers returned NO_NEW_VALUABLE_FINDINGS for the final current head, ledger, inline comment, and summary after the last accepted candidate and wording/anchor change.

[github-actions]

Make these result-checked regression cases. Both new statements are bare sql, so the suite passes for any non-error output even though this PR changes duplicate removal and the CountIf null-filtering expression. The Java tests only inspect plan shape/input slots. Please use qt_/order_qt_ with generated expected counts, and include reordered/partially duplicated nullable arguments so the grouped/global execution result is actually verified.

dismiss