Uh oh!
There was an error while loading. Please reload this page.
[fix](regression) stabilize branch-4.1 colocate column order test - #65231
Conversation
hello-stephen
commented
Jul 6, 2026
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
shuke987
commented
Jul 6, 2026
run buildall |
shuke987
commented
Jul 6, 2026
/review |
There was a problem hiding this comment.
Automated review summary for PR #65231
Opinion: I did not find a blocking issue or a substantiated inline comment for this one-file regression-test stabilization.
Critical checkpoints:
- Read the review prompt, review metadata bundle, existing review context, changed-file list, required-agents file, and shared ledger before inspecting the diff.
- No required AGENTS.md files were listed for the changed-file ancestors. The repo-local
.claude/skills/code-review/SKILL.mdwas not present after hidden-path search, so the review proceeded with the bundle instructions and shared-ledger workflow. - GitHub PR metadata confirms the live head is
754c7efc261eb526d9cc0d83a9b6cbac65071131, with onlyregression-test/suites/correctness_p0/test_colocate_join_of_column_order.groovychanged. - Existing inline review context was empty, so no duplicate suppression was needed.
- The patch matches the upstream master stabilization from PR #64940 by pinning
parallel_pipeline_task_num=1for the target explain statement, and this branch additionally removes the older injected-stats workaround. - The relevant
SET_VARpath appliesparallel_pipeline_task_numas a statement-scoped session variable, andConnectContext.getTotalInstanceNum()feeds the bucket-shuffle downgrade threshold that the test is stabilizing. - After fetching the prompt base SHA,
git diff --checkpassed for the reviewed base/head range and changed file.
Validation limits:
- I did not run the Doris regression suite locally; this case depends on the Cloud P0-compatible regression environment.
- At review time, several GitHub checks were passing, while macOS BE UT, TeamCity compile, and this code-review workflow were still pending.
User focus points:
- No additional user-provided review focus was supplied.
Subagent conclusions:
optimizer-rewrite: no candidate findings; reviewed optimizer/rewrite, colocate, bucket-shuffle, and semantic-equivalence paths.tests-session-config: no candidate findings; reviewed regression-test behavior, expected-output stability, session/config propagation, compatibility, and basic CI/style signals.- Final convergence round 1 ended with both live subagents replying
NO_NEW_VALUABLE_FINDINGSfor the same final ledger and empty proposed inline comment set.
shuke987
commented
Jul 8, 2026
/review |
Codex automated review failed and did not complete. Error: You've hit your usage limit. Visit https://chatgpt.com/codex/settings/usage to purchase more credits or try again at Jul 10th, 2026 6:44 AM. Please inspect the workflow logs and rerun the review after the underlying issue is resolved. |
shuke987
commented
Jul 9, 2026
/review |
There was a problem hiding this comment.
Reviewed PR 65231 against the live GitHub patch at head 754c7efc261eb526d9cc0d83a9b6cbac65071131.
No blocking or inline-review issues found.
Critical checkpoints:
- Scope: GitHub metadata and patch show one changed file,
regression-test/suites/correctness_p0/test_colocate_join_of_column_order.groovy, with the same live head as the prompt. - Existing review context: there were no existing inline comments or replies to deduplicate against.
- Review instructions: the repo-local
SKILL.mdwas not present after hidden-path and direct searches, so I followed the review prompt plus the Doris shared-ledger workflow fallback. - Optimizer/rewrite: the query-local
SET_VAR(parallel_pipeline_task_num=1)matches the merged upstream PR 64940 stabilization and is applied before Nereids planning for theEXPLAINstatement. - Test/session/config: the
explain { ... contains "COLOCATE" }harness executes the hinted SQL, andparallel_pipeline_task_numpropagates through the normal session-variable path into planning/costing. - Validation:
git diff --checkpassed on the exact PR base/head range after fetching the missing base SHA. I did not run the Cloud P0 regression suite locally because this runner does not provide that environment.
User focus: no additional user-provided review focus was supplied.
Subagent conclusions: optimizer-rewrite and tests-session-config both appended NO_CANDIDATES; after the main ledger merge and proposed empty inline comment set, both returned NO_NEW_VALUABLE_FINDINGS in convergence round 1. No candidates were accepted, dismissed, or merged as duplicates.
Uh oh!
There was an error while loading. Please reload this page.
Proposed changes
Backport the final master-side stabilization for
test_colocate_join_of_column_orderto branch-4.1.Master PR #64940 fixed this case by pinning
parallel_pipeline_task_num=1in the three-table colocate explain query. Branch-4.1 still had the earlier stats-injection workaround from #64613, but later failure evidence showed stats pinning was not the root cause: the flaky plan shape is driven by bucket-shuffle downgrade under higher runtime parallelism.This patch removes the obsolete stats injection and pins
parallel_pipeline_task_num=1for the target explain SQL.Related to #64960.
Follow-up/backport of #64940.
Testing
git diff --check