Skip to content

[branch-4.0][fix](be) Init thread context on AsyncIO worker threads - #65271

Merged
morningman merged 1 commit into
apache:branch-4.0from
liaoxin01:codex/pick-64846-to-branch-4.0
Jul 7, 2026
Merged

[branch-4.0][fix](be) Init thread context on AsyncIO worker threads#65271
morningman merged 1 commit into
apache:branch-4.0from
liaoxin01:codex/pick-64846-to-branch-4.0

Conversation

@liaoxin01

@liaoxin01liaoxin01 commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Pick #64846

@liaoxin01
[fix](be) Init thread context on AsyncIO worker threads (apache#64846)
c42069d
`FILESYSTEM_M` dispatches IO ops from a bthread to an `AsyncIO` worker
pthread that is **not bound to any task** and therefore has no
`ThreadContext`. When the dispatched `fn()` reads a local file, it goes
through `LocalFileReader::read_at_impl` -> `LIMIT_LOCAL_SCAN_IO` ->
`thread_context()`, which raises `Status::FatalError` (aborting the BE
in debug/ASAN builds) when no `ThreadContext` exists.
Observed as a Cloud P0 coredump on the load error-log S3 upload path:
```
RuntimeState::get_error_log_file_path()
-> _s3_error_fs->upload() (called from a bthread)
-> AsyncIO::run_task() on an AsyncIO worker pthread (no attached task)
-> S3FileSystem::upload_impl()
-> LocalFileReader::read_at_impl()
-> LIMIT_LOCAL_SCAN_IO -> thread_context() -> FatalError -> SIGABRT
```
Initialize an (unattached) `ThreadContext` at the `AsyncIO` worker
boundary via `SCOPED_INIT_THREAD_CONTEXT()`, the same pattern used by
StorageEngine background threads. This gives every `thread_context()`
consumer running on an AsyncIO worker (memory tracking,
`LIMIT_*_SCAN_IO`, ...) a valid context, fixing the crash at its root
rather than making individual consumers tolerate a missing context.
CopilotAI review requested due to automatic review settings July 6, 2026 11:37
@hello-stephen

hello-stephen commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

CopilotAI reviewed Jul 6, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR backports #64846 to ensure AsyncIO’s pthread-based worker threads have a valid ThreadContext before running dispatched filesystem work, preventing fatal failures when worker-side code touches thread_context() (e.g., memory tracking / IO limiting helpers).

Changes:

  • Add runtime/thread_context.h include to AsyncIO header.
  • Initialize an (unattached) ThreadContext inside AsyncIO thread-pool task execution via SCOPED_INIT_THREAD_CONTEXT().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadbe/src/util/async_io.h
@liaoxin01

liaoxin01 commented Jul 6, 2026

Copy link
Copy Markdown
ContributorAuthor

run buildall

@hello-stephen

hello-stephen commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage53.51% (19561/36559)
Line Coverage36.57% (182990/500353)
Region Coverage33.15% (142311/429320)
Branch Coverage34.00% (61499/180905)

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Jul 6, 2026
@github-actions

github-actionsBot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@hello-stephen

hello-stephen commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage71.51% (25578/35767)
Line Coverage54.39% (271248/498696)
Region Coverage52.01% (225080/432752)
Branch Coverage53.42% (96867/181327)

@morningman
morningman merged commit 8251b44 into apache:branch-4.0Jul 7, 2026
30 of 34 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@morningmanmorningmanmorningman approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liaoxin01@hello-stephen@morningman