Skip to content

[chore](thirdparty) introduce thridparty about lance-c#65304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zhangstar333 merged 2 commits into from
Jul 17, 2026
+724 −0
Merged

[chore](thirdparty) introduce thridparty about lance-c #65304

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9db7d9b
[chore](thirdparty) introduce thridparty about lance-c
zhangstar333 Jul 7, 2026
3e0d624
update add_thirdparty
zhangstar333 Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions be/cmake/thirdparty.cmake
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -110,6 +110,10 @@ add_thirdparty(arrow_flight_sql LIB64)
add_thirdparty(arrow_dataset LIB64)
add_thirdparty(arrow_acero LIB64)
add_thirdparty(parquet LIB64)
# liblance_c.a contains compiler_builtins cbrt symbols. Place libm before it
# so the final linker resolves C math symbols from the system library first.
add_thirdparty(lance_c LIB64 NOTADD)
list(APPEND COMMON_THIRDPARTY m lance_c)

@github-actionsgithub-actionsBotJul 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

COMMON_THIRDPARTY is linked before glibc-compatibility, so adding bare m here puts system -lm ahead of the compatibility archive on every default Linux link. That contradicts the explicit ordering invariant in be/CMakeLists.txt requiring glibc-compatibility before -lc -lm: existing Doris pow/log/exp references can now be satisfied by the build host's libm before the corresponding compatibility objects are extracted, reintroducing newer libm symbol versions into binaries intended for older glibc. Please keep every -lm after the compatibility targets and solve Lance's compiler-builtins collision without changing the global system-library order.

add_thirdparty(brpc LIB64)
add_thirdparty(rocksdb)
add_thirdparty(cyrus-sasl LIBNAME "lib/libsasl2.a")
Expand Down
3 changes: 3 additions & 0 deletions dist/LICENSE-dist.txt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -1476,6 +1476,9 @@ The Apache Software License, Version 2.0
* opentelemetry-proto: 0.18.0
* opentelemetry-cpp: 1.4.0
* clucene: 2.4.6
* lance-c: 0.1.2

@github-actionsgithub-actionsBotJul 16, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new static archive includes Apache DataFusion 52.4.0 and Apache Arrow Object Store 0.12.5 (both are present in the locked inventory), and each published crate carries a NOTICE.txt attribution. Apache-2.0 section 4(d) requires those relevant attributions to accompany redistributed derivatives, but neither NOTICE.txt nor dist/NOTICE-dist.txt mentions either project; build.sh packages the former with Doris binaries. Please add these NOTICE entries and audit the remaining locked crates for any additional NOTICE files before distributing liblance_c.a.

- source: https://github.com/lance-format/lance-c
- transitive Rust crate licenses: licenses/LICENSE-lance-c-rust-crates.txt

The MIT License -- licenses/LICENSE-MIT.txt
* datatables: 1.12.1
Expand Down
Loading
Loading