(opt)(regression) SlotReference.shapeInfo() do not print table name by englefly · Pull Request #65346 · apache/doris

englefly · 2026-07-08T00:58:33Z

What problem does this PR solve?

some regression case output are not stable, like query_p0/hint/multi_leading.groovy

Exception:
java.lang.IllegalStateException: Check tag 'sql5_2' failed:
Check tag 'sql5_2' failed, line 6, CHAR result mismatch.
Expect cell is: ------NestedLoopJoin[INNER_JOIN](cast(sum(c11) as DOUBLE) > avg(t1.c11) / 20.0)
But real is : ------NestedLoopJoin[INNER_JOIN](cast(sum(c11) as DOUBLE) > (avg(c11) / 20.0))

After this pr, the explain output is fixed to avg(t1.c11)

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

englefly · 2026-07-08T00:58:42Z

run buildall

hello-stephen · 2026-07-08T00:58:45Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

englefly · 2026-07-08T00:58:50Z

/review

github-actions

Automated review result: request changes.

Critical checkpoint conclusions:

Goal/test: the PR tries to make explain output table-qualified by changing SlotReference.computeToSql() globally, but toSql() is also used as a semantic/generated name in Nereids. The current code does not safely accomplish the goal, and no new regression/unit test was added for the affected name-binding paths.
Scope/focus: the patch is small, but the behavioral surface is broad because every SlotReference.toSql() caller now sees qualified names. The explain-only goal should be handled in display formatting or in targeted callers, not by changing the base slot SQL string globally.
Parallel paths/compatibility: set operations, recursive CTEs, and FK join elimination all use toSql() for generated output or alias names, so this can break outer binding and change client-visible labels.
Concurrency, lifecycle, config, persistence, data writes, FE-BE protocol, and observability: not materially involved in this one-file FE expression rendering change.
Tests/validation: static review only. I did not run FE build/checkstyle because this checkout is missing thirdparty/installed and thirdparty/installed/bin/protoc, which the FE instructions require before building. The checkstyle issue is verified from fe/check/checkstyle/checkstyle.xml.
User focus: no additional user-provided review focus was present.

Subagent conclusions:

optimizer-rewrite proposed OPT-REWRITE-001; I verified it as another impact of MAIN-001 and folded it into the accepted correctness inline comment.
tests-session-config proposed TSC-001; I verified and accepted it as MAIN-002.
Convergence round 1 ended after the final candidate update with both live subagents replying NO_NEW_VALUABLE_FINDINGS for the same ledger/comment set.

englefly · 2026-07-08T10:11:33Z

run buildall

hello-stephen · 2026-07-08T11:35:48Z

TPC-H: Total hot run time: 29297 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9175296d2b85e7a21dfadadce8f2ae984b715902, data reload: false
------ Round 1 ----------------------------------
============================================
q1	17713	4040	4003	4003
q2	2043	312	200	200
q3	10286	1333	810	810
q4	4684	467	338	338
q5	7507	846	581	581
q6	177	167	136	136
q7	764	833	632	632
q8	9952	1462	1422	1422
q9	6100	4421	4407	4407
q10	6784	1793	1578	1578
q11	503	345	321	321
q12	722	554	419	419
q13	18174	3290	2706	2706
q14	266	258	242	242
q15	q16	786	783	710	710
q17	995	976	931	931
q18	6943	5718	5498	5498
q19	1331	1246	1082	1082
q20	771	642	559	559
q21	5840	2589	2426	2426
q22	417	360	296	296
Total cold run time: 102758 ms
Total hot run time: 29297 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4332	4279	4260	4260
q2	279	311	214	214
q3	4540	4972	4400	4400
q4	2049	2128	1367	1367
q5	4447	4307	4287	4287
q6	223	175	125	125
q7	1727	1907	1718	1718
q8	2504	2146	2106	2106
q9	7853	7811	7776	7776
q10	4729	4715	4299	4299
q11	591	412	395	395
q12	758	770	545	545
q13	3412	3564	2958	2958
q14	323	330	307	307
q15	q16	720	738	661	661
q17	1347	1301	1300	1300
q18	7954	7347	6988	6988
q19	1059	1002	1047	1002
q20	2218	2186	1938	1938
q21	5190	4490	4356	4356
q22	530	456	391	391
Total cold run time: 56785 ms
Total hot run time: 51393 ms

hello-stephen · 2026-07-08T11:45:40Z

TPC-DS: Total hot run time: 154574 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9175296d2b85e7a21dfadadce8f2ae984b715902, data reload: false
query5 query6	489	238	199	199
query7	4865	535	325	325
query8	333	192	177	177
query9	8948	4109	4023	4023
query10	442	336	286	286
query11	5878	2368	2123	2123
query12	178	104	106	104
query13	1293	609	420	420
query14 query14_1	6988	4643	4293	4293
query15	206	201	183	183
query16	1011	483	437	437
query17	942	711	582	582
query18	2450	466	336	336
query19	195	188	145	145
query20	116	111	110	110
query21	232	161	136	136
query22	13709	13598	13376	13376
query23	17422	16602	16205	16205
query23_1 query24	7813	1754	1337	1337
query24_1	1293	1298	1283	1283
query25	622	462	394	394
query26	1312	354	217	217
query27	2601	577	379	379
query28	4473	2040	2007	2007
query29	1083	636	498	498
query30	415	270	238	238
query31	1142	1107	1000	1000
query32	108	67	71	67
query33 query34	1171	1113	650	650
query35	758	775	678	678
query36	1455	1437	1239	1239
query37	151	111	98	98
query38	1786	1710	1663	1663
query39	944	928	883	883
query39_1	902	872	885	872
query40	246	169	142	142
query41	72	73	71	71
query42	101	97	97	97
query43	320	329	285	285
query44	1416	792	758	758
query45	196	191	191	191
query46	1098	1185	765	765
query47	2385	2389	2265	2265
query48	391	429	271	271
query49 query50	1001	426	362	362
query51	10716	10863	10791	10791
query52	88	90	78	78
query53	240	255	236	236
query54	277	237	213	213
query55	101	73	65	65
query56 query57	1446	1454	1420	1420
query58	304	261	266	261
query59	1628	1676	1494	1494
query60 query61	163	154	151	151
query62	736	672	577	577
query63	244	214	205	205
query64	2969	1020	840	840
query65	4875	4815	4750	4750
query66 query67	29509	29355	29397	29355
query68	3436	1536	976	976
query69	409	288	260	260
query70	1071	992	982	982
query71	475	315	285	285
query72	3120	2647	2361	2361
query73	886	770	424	424
query74	5163	4946	4779	4779
query75 query76 query77 query78	12213	12140	11637	11637
query79	1227	1142	757	757
query80 query81	521	335	294	294
query82	240	158	126	126
query83	365	319	320	319
query84	304	155	162	155
query85	927	616	500	500
query86	337	296	275	275
query87	1810	1825	1754	1754
query88	3681	2760	2779	2760
query89	429	402	353	353
query90	2523	202	192	192
query91	235	187	163	163
query92	64	59	57	57
query93	1506	1434	1008	1008
query94	792	356	333	333
query95	788	586	468	468
query96	1081	772	341	341
query97	2697	2707	2586	2586
query98	217	208	207	207
query99	1144	1173	1042	1042
Total cold run time: 232191 ms
Total hot run time: 154574 ms

hello-stephen · 2026-07-08T11:50:30Z

ClickBench: Total hot run time: 25.07 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9175296d2b85e7a21dfadadce8f2ae984b715902, data reload: false
query1	0.01	0.01	0.01
query2	0.09	0.05	0.05
query3	0.25	0.13	0.14
query4	1.61	0.13	0.13
query5	0.24	0.22	0.22
query6	1.23	1.08	1.06
query7	0.03	0.01	0.00
query8	0.06	0.03	0.03
query9	0.38	0.31	0.31
query10	0.53	0.55	0.54
query11	0.19	0.13	0.13
query12	0.19	0.14	0.14
query13	0.48	0.48	0.48
query14	1.03	1.01	1.00
query15	0.61	0.59	0.59
query16	0.31	0.34	0.32
query17	1.12	1.14	1.10
query18	0.21	0.22	0.21
query19	2.09	1.98	1.96
query20	0.02	0.01	0.02
query21	15.42	0.21	0.13
query22	4.93	0.06	0.05
query23	16.12	0.31	0.12
query24	2.92	0.41	0.33
query25	0.11	0.05	0.04
query26	0.89	0.21	0.14
query27	0.06	0.04	0.04
query28	3.43	0.93	0.56
query29	12.51	4.10	3.26
query30	0.28	0.17	0.15
query31	2.77	0.60	0.30
query32	3.22	0.58	0.49
query33	3.14	3.24	3.17
query34	15.74	4.25	3.52
query35	3.56	3.55	3.61
query36	0.56	0.43	0.42
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.04	0.03	0.03
query40	0.19	0.17	0.15
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.04
Total cold run time: 96.88 s
Total hot run time: 25.07 s

hello-stephen · 2026-07-08T13:03:33Z

FE UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉
Increment coverage report
Complete coverage report

hello-stephen · 2026-07-08T16:48:24Z

FE Regression Coverage Report

Increment line coverage 0.38% (2/523) 🎉
Increment coverage report
Complete coverage report

englefly · 2026-07-09T03:01:39Z

run buildall

englefly · 2026-07-09T03:01:44Z

/review

github-actions

I found one blocking issue in the current head: the code changes shape-plan slot rendering, but the regression expected outputs that exercise that rendering were not updated.

Critical checkpoints:

Goal/test proof: The goal appears to be stabilizing explain shape plan output, but current code and checked .out files disagree, so the tests do not prove the change.
Scope/focus: The source change is small and localized to SlotReference.shapeInfo().
Parallel paths: I checked hash join, nested-loop join, binary predicate, aggregate/function, and toSql() paths. The older generated-name issue from computeToSql() is resolved on the current head.
Concurrency/lifecycle/config/compatibility/persistence/data writes/FE-BE protocol: Not involved in this one-file FE display-path change.
Validation: git diff --check passed on the fetched base/head range. I did not run FE/regression tests because this checkout is missing .worktree_initialized, thirdparty/installed, and thirdparty/installed/bin/protoc.

User focus: No additional user-provided focus was supplied.

Subagent conclusions: TSC-001 was accepted as the inline comment below. OR-001 was merged as duplicate/supporting optimizer evidence for the same issue. Convergence round 1 ended with both optimizer-rewrite and tests-session-config returning NO_NEW_VALUABLE_FINDINGS for the final ledger/comment set.

github-actions · 2026-07-09T03:14:14Z

- } else {
- return qualifier.get(qualifier.size() - 1) + "." + name.get();
- }
+ return name.get();


This leaves the checked shape-plan output stale. The live diff now only changes SlotReference.shapeInfo() to return the bare name, and shape-plan join text is built by PhysicalHashJoin / PhysicalNestedLoopJoin through Expression.shapeInfo() and BinaryOperator.shapeInfo(). Existing regression outputs still expect qualified slots, e.g. test_hint.out still has hashCondition=((t1.c1 = t2.c2)), and the PR body's cited multi_leading.out line still expects avg(t1.c11). With this change those direct slot references render as c1/c2, and aggregate/function arguments still go through toSql(), so the expected files need to be regenerated or the implementation needs to keep the intended qualified display behavior. Otherwise CI can keep comparing against stale shape-plan text.

hello-stephen · 2026-07-09T07:11:13Z

TPC-H: Total hot run time: 29479 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 548c3ce9c27d247669c58e9e22f7115bc4dfbe10, data reload: false
------ Round 1 ----------------------------------
============================================
q1	17714	4007	4049	4007
q2	2026	349	211	211
q3	10299	1446	831	831
q4	4687	471	337	337
q5	7509	861	574	574
q6	184	176	140	140
q7	772	847	632	632
q8	9338	1450	1591	1450
q9	5605	4420	4391	4391
q10	6751	1826	1531	1531
q11	508	351	319	319
q12	699	553	433	433
q13	18093	3449	2777	2777
q14	266	261	249	249
q15	q16	784	787	707	707
q17	1024	966	960	960
q18	6882	5730	5613	5613
q19	1388	1292	1116	1116
q20	792	635	506	506
q21	5915	2605	2391	2391
q22	447	360	304	304
Total cold run time: 101683 ms
Total hot run time: 29479 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4433	4261	4318	4261
q2	299	326	213	213
q3	4583	4996	4375	4375
q4	2085	2179	1378	1378
q5	4432	4348	4348	4348
q6	229	180	132	132
q7	1748	1952	1854	1854
q8	2507	2276	2249	2249
q9	8116	8246	7840	7840
q10	4717	4674	4343	4343
q11	553	423	385	385
q12	754	780	541	541
q13	3280	3621	3030	3030
q14	320	322	273	273
q15	q16	722	719	628	628
q17	1379	1406	1292	1292
q18	7884	7406	7204	7204
q19	1135	1111	1071	1071
q20	2210	2191	1959	1959
q21	5291	4592	4494	4494
q22	543	493	396	396
Total cold run time: 57220 ms
Total hot run time: 52266 ms

hello-stephen · 2026-07-09T07:22:34Z

TPC-DS: Total hot run time: 180059 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 548c3ce9c27d247669c58e9e22f7115bc4dfbe10, data reload: false
query5	4334	637	507	507
query6	458	223	210	210
query7	4839	553	350	350
query8	344	185	171	171
query9	8766	4032	4049	4032
query10	518	333	305	305
query11	5928	2378	2145	2145
query12	154	98	98	98
query13	1265	588	437	437
query14	6230	5282	4941	4941
query14_1	4284	4279	4257	4257
query15	207	202	182	182
query16	1016	479	430	430
query17	905	722	565	565
query18	2427	496	336	336
query19	202	182	140	140
query20	114	108	107	107
query21	228	157	131	131
query22	13616	13643	13358	13358
query23	17520	16546	16120	16120
query23_1	16259	16284	16351	16284
query24	7591	1829	1325	1325
query24_1	1335	1308	1317	1308
query25	581	465	397	397
query26	1329	366	206	206
query27	2585	569	402	402
query28	4453	2005	2006	2005
query29	1134	646	511	511
query30	337	261	230	230
query31	1130	1109	986	986
query32	115	62	62	62
query33	550	325	279	279
query34	1187	1094	639	639
query35	777	790	700	700
query36	1398	1381	1200	1200
query37	158	124	92	92
query38	1886	1839	1664	1664
query39	921	932	904	904
query39_1	885	894	868	868
query40	261	164	138	138
query41	70	73	68	68
query42	97	99	95	95
query43	324	332	292	292
query44	1446	785	769	769
query45	208	187	182	182
query46	1134	1256	768	768
query47	2361	2317	2187	2187
query48	386	416	310	310
query49	585	445	315	315
query50	1069	437	331	331
query51	11052	10515	10779	10515
query52	88	94	80	80
query53	263	271	208	208
query54	296	251	249	249
query55	77	75	70	70
query56	307	314	295	295
query57	1437	1408	1319	1319
query58	290	264	265	264
query59	1596	1715	1461	1461
query60	338	275	271	271
query61	207	148	152	148
query62	691	647	588	588
query63	248	206	198	198
query64	2817	1050	839	839
query65	4883	4773	4784	4773
query66	1844	519	392	392
query67	29807	29527	29381	29381
query68	3159	1491	964	964
query69	413	304	272	272
query70	1134	959	986	959
query71	365	328	302	302
query72	3091	2740	2371	2371
query73	861	768	450	450
query74	5137	4961	4755	4755
query75	2612	2582	2231	2231
query76	2353	1186	772	772
query77	352	377	278	278
query78	12456	12434	11827	11827
query79	1379	1108	773	773
query80	1267	569	455	455
query81	545	325	282	282
query82	652	156	121	121
query83	373	321	290	290
query84	322	155	131	131
query85	952	587	498	498
query86	454	314	303	303
query87	1835	1824	1762	1762
query88	3727	2799	2811	2799
query89	459	397	362	362
query90	1943	210	201	201
query91	206	187	155	155
query92	65	60	61	60
query93	1649	1577	965	965
query94	729	346	332	332
query95	810	503	474	474
query96	1054	775	367	367
query97	2717	2709	2524	2524
query98	227	205	209	205
query99	1149	1197	1035	1035
Total cold run time: 267003 ms
Total hot run time: 180059 ms

hello-stephen · 2026-07-09T07:27:35Z

ClickBench: Total hot run time: 25.09 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 548c3ce9c27d247669c58e9e22f7115bc4dfbe10, data reload: false
query1	0.01	0.01	0.01
query2	0.09	0.04	0.05
query3	0.25	0.13	0.13
query4	1.64	0.15	0.14
query5	0.25	0.22	0.22
query6	1.24	1.07	1.05
query7	0.03	0.01	0.00
query8	0.05	0.04	0.04
query9	0.38	0.33	0.30
query10	0.55	0.57	0.56
query11	0.20	0.14	0.14
query12	0.18	0.15	0.15
query13	0.49	0.48	0.51
query14	1.02	1.02	1.02
query15	0.63	0.60	0.60
query16	0.32	0.33	0.31
query17	1.09	1.12	1.12
query18	0.24	0.22	0.22
query19	2.09	2.05	1.90
query20	0.02	0.01	0.01
query21	15.45	0.21	0.13
query22	4.91	0.05	0.05
query23	16.11	0.31	0.12
query24	3.08	0.43	0.33
query25	0.10	0.05	0.05
query26	0.74	0.21	0.14
query27	0.05	0.03	0.04
query28	3.51	0.96	0.56
query29	12.51	4.08	3.25
query30	0.27	0.16	0.15
query31	2.77	0.60	0.31
query32	3.22	0.60	0.48
query33	3.17	3.22	3.18
query34	15.55	4.22	3.53
query35	3.54	3.54	3.58
query36	0.55	0.44	0.44
query37	0.08	0.06	0.07
query38	0.06	0.04	0.04
query39	0.04	0.03	0.03
query40	0.17	0.16	0.14
query41	0.08	0.03	0.03
query42	0.04	0.03	0.03
query43	0.05	0.04	0.03
Total cold run time: 96.82 s
Total hot run time: 25.09 s

englefly · 2026-07-10T03:19:10Z

run buildall

hello-stephen · 2026-07-10T04:48:45Z

FE UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉
Increment coverage report
Complete coverage report

hello-stephen · 2026-07-10T05:28:51Z

TPC-H: Total hot run time: 29442 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 548c3ce9c27d247669c58e9e22f7115bc4dfbe10, data reload: false
------ Round 1 ----------------------------------
============================================
q1	17674	3969	3935	3935
q2	1991	317	201	201
q3	10309	1473	828	828
q4	4727	467	336	336
q5	7918	835	576	576
q6	249	166	136	136
q7	770	812	627	627
q8	10438	1592	1588	1588
q9	6023	4373	4378	4373
q10	6844	1806	1524	1524
q11	500	338	320	320
q12	748	546	428	428
q13	18059	3429	2763	2763
q14	264	258	241	241
q15	q16	792	773	721	721
q17	991	971	1045	971
q18	7008	5794	5473	5473
q19	1168	1220	987	987
q20	758	626	581	581
q21	5754	2538	2563	2538
q22	426	360	295	295
Total cold run time: 103411 ms
Total hot run time: 29442 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4305	4214	4219	4214
q2	292	321	212	212
q3	4577	4994	4400	4400
q4	2034	2112	1355	1355
q5	4471	4334	4294	4294
q6	228	173	124	124
q7	1710	2050	1680	1680
q8	2468	2198	2079	2079
q9	7864	7824	7809	7809
q10	4757	4740	4301	4301
q11	573	409	486	409
q12	786	755	541	541
q13	3212	3569	2945	2945
q14	311	315	289	289
q15	q16	698	724	629	629
q17	1351	1307	1317	1307
q18	7969	7385	6655	6655
q19	1083	1079	1085	1079
q20	2200	2197	1926	1926
q21	5207	4566	4452	4452
q22	515	444	397	397
Total cold run time: 56611 ms
Total hot run time: 51097 ms

hello-stephen · 2026-07-10T05:40:21Z

TPC-DS: Total hot run time: 180801 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 548c3ce9c27d247669c58e9e22f7115bc4dfbe10, data reload: false
query5	4345	660	503	503
query6	466	221	206	206
query7	4849	631	340	340
query8	338	193	171	171
query9	8773	4056	4039	4039
query10	461	360	318	318
query11	5841	2392	2117	2117
query12	163	104	105	104
query13	1268	610	443	443
query14	6378	5367	5000	5000
query14_1	4312	4339	4306	4306
query15	211	196	179	179
query16	1020	452	438	438
query17	1131	728	569	569
query18	2569	481	338	338
query19	203	201	146	146
query20	110	104	105	104
query21	236	159	132	132
query22	13589	13697	13424	13424
query23	17399	16586	16255	16255
query23_1	16318	16280	16323	16280
query24	7485	1808	1288	1288
query24_1	1348	1320	1310	1310
query25	566	450	364	364
query26	1318	345	214	214
query27	2571	588	379	379
query28	4449	2028	2004	2004
query29	1078	629	497	497
query30	337	273	232	232
query31	1132	1107	1007	1007
query32	110	65	64	64
query33	545	335	260	260
query34	1162	1174	656	656
query35	777	799	702	702
query36	1417	1353	1229	1229
query37	160	108	91	91
query38	1910	1728	1661	1661
query39	926	949	917	917
query39_1	884	877	873	873
query40	256	165	150	150
query41	73	69	70	69
query42	95	94	96	94
query43	339	350	294	294
query44	1490	766	805	766
query45	204	187	220	187
query46	1109	1214	713	713
query47	2296	2278	2181	2181
query48	409	414	288	288
query49	595	428	339	339
query50	1068	423	338	338
query51	10595	10965	10490	10490
query52	86	85	75	75
query53	279	282	202	202
query54	277	237	232	232
query55	75	70	69	69
query56	299	301	286	286
query57	1416	1349	1290	1290
query58	278	258	248	248
query59	1626	1748	1476	1476
query60	298	268	257	257
query61	157	156	156	156
query62	713	662	593	593
query63	235	202	200	200
query64	2829	1054	862	862
query65	4872	4770	4814	4770
query66	1779	524	384	384
query67	29880	29771	29497	29497
query68	3010	1532	991	991
query69	418	312	267	267
query70	1090	978	982	978
query71	375	349	308	308
query72	3079	2777	2443	2443
query73	810	811	417	417
query74	5123	4981	4786	4786
query75	2622	2611	2225	2225
query76	2307	1196	791	791
query77	363	381	293	293
query78	12443	12430	11752	11752
query79	1413	1156	744	744
query80	933	542	464	464
query81	521	345	285	285
query82	573	157	122	122
query83	401	319	292	292
query84	273	161	127	127
query85	964	617	541	541
query86	404	312	284	284
query87	1871	1845	1785	1785
query88	3786	2812	2810	2810
query89	473	405	379	379
query90	1778	210	199	199
query91	225	200	176	176
query92	66	62	61	61
query93	1609	1537	983	983
query94	646	368	328	328
query95	810	622	485	485
query96	1100	777	347	347
query97	2697	2690	2573	2573
query98	221	210	204	204
query99	1221	1183	1025	1025
Total cold run time: 265693 ms
Total hot run time: 180801 ms

hello-stephen · 2026-07-10T05:45:21Z

ClickBench: Total hot run time: 25.06 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 548c3ce9c27d247669c58e9e22f7115bc4dfbe10, data reload: false
query1	0.01	0.01	0.01
query2	0.09	0.06	0.05
query3	0.26	0.15	0.13
query4	1.61	0.14	0.14
query5	0.24	0.27	0.22
query6	1.26	1.08	1.08
query7	0.03	0.01	0.01
query8	0.05	0.04	0.03
query9	0.39	0.31	0.34
query10	0.56	0.58	0.54
query11	0.18	0.14	0.13
query12	0.19	0.14	0.14
query13	0.49	0.47	0.47
query14	1.00	1.02	1.01
query15	0.61	0.60	0.60
query16	0.31	0.33	0.32
query17	1.08	1.12	1.08
query18	0.22	0.21	0.22
query19	2.01	1.89	1.96
query20	0.02	0.01	0.01
query21	15.43	0.23	0.13
query22	4.80	0.05	0.05
query23	16.13	0.31	0.12
query24	2.98	0.44	0.31
query25	0.11	0.05	0.04
query26	0.77	0.21	0.16
query27	0.05	0.04	0.04
query28	3.46	0.90	0.55
query29	12.47	4.06	3.23
query30	0.28	0.17	0.16
query31	2.77	0.60	0.32
query32	3.21	0.59	0.49
query33	3.18	3.19	3.21
query34	15.65	4.24	3.52
query35	3.56	3.57	3.58
query36	0.54	0.43	0.44
query37	0.08	0.06	0.06
query38	0.05	0.05	0.04
query39	0.04	0.03	0.03
query40	0.18	0.16	0.16
query41	0.08	0.04	0.03
query42	0.03	0.02	0.02
query43	0.05	0.03	0.03
Total cold run time: 96.51 s
Total hot run time: 25.06 s

hello-stephen · 2026-07-10T08:03:19Z

FE Regression Coverage Report

Increment line coverage 0.97% (1/103) 🎉
Increment coverage report
Complete coverage report

print table name in SlotReference.computeToSql
4c0b1b5

englefly requested review from 924060929, morrySnow and starocean999 as code owners July 8, 2026 00:58

github-actionsBot requested changes Jul 8, 2026
View reviewed changes

Comment threadfe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/SlotReference.java Outdated

github-actionsBot reviewed Jul 8, 2026
View reviewed changes

Comment threadfe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/SlotReference.java Outdated

fmt
9175296

remove table qualifier
548c3ce

englefly changed the title ~~(opt)(explain) print table name in SlotReference.computeToSql~~(opt)(regression) SlotReference.shapeInfo() do not print table nameJul 9, 2026

github-actionsBot requested changes Jul 9, 2026
View reviewed changes

shuke987 mentioned this pull request Jul 10, 2026
[fix](regression) stabilize DPHyp query85 shape check #65461
Draft
16 tasks

englefly closed this Jul 13, 2026

englefly deleted the aggFuncPrintV2 branch August 5, 2026 02:08

Uh oh!

Conversation

englefly commented Jul 8, 2026

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

englefly commented Jul 8, 2026

Uh oh!

hello-stephen commented Jul 8, 2026

Uh oh!

englefly commented Jul 8, 2026

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

englefly commented Jul 8, 2026

Uh oh!

hello-stephen commented Jul 8, 2026

Uh oh!

hello-stephen commented Jul 8, 2026

Uh oh!

hello-stephen commented Jul 8, 2026

Uh oh!

hello-stephen commented Jul 8, 2026

FE UT Coverage Report

Uh oh!

hello-stephen commented Jul 8, 2026

FE Regression Coverage Report

Uh oh!

englefly commented Jul 9, 2026

Uh oh!

englefly commented Jul 9, 2026

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actionsBotJul 9, 2026

Choose a reason for hiding this comment

Uh oh!

hello-stephen commented Jul 9, 2026

Uh oh!

hello-stephen commented Jul 9, 2026

Uh oh!

hello-stephen commented Jul 9, 2026

Uh oh!

englefly commented Jul 10, 2026

Uh oh!

hello-stephen commented Jul 10, 2026

FE UT Coverage Report

Uh oh!

hello-stephen commented Jul 10, 2026

Uh oh!

hello-stephen commented Jul 10, 2026

Uh oh!

hello-stephen commented Jul 10, 2026

Uh oh!

hello-stephen commented Jul 10, 2026

FE Regression Coverage Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants