Uh oh!
There was an error while loading. Please reload this page.
branch-4.1: [improve](metrics) Export file cache remote index byte metrics #65398 - #65439
Merged
Conversation
Issue Number: None Related PR: None Problem Summary: File cache statistics already track the remote-read bytes for inverted index and segment footer index data, but BE Doris metrics only export the aggregate cache/local/remote/peer byte counters. As a result, these two index-specific remote read costs are visible in query profile internals but not exposed from the BE `/metrics` endpoint, which makes them harder to monitor and alert on in cloud/file-cache scenarios. This PR exposes the following two BE metrics: - `doris_be_inverted_index_bytes_read_from_remote` - `doris_be_segment_footer_index_bytes_read_from_remote` The change keeps the existing file cache metrics aggregation path and extends it in three places: 1. Register the two counters in `DorisMetrics` 2. Extend `FileCacheMetrics::AtomicStatistics` and the aggregation/update path to accumulate them 3. Export them from the existing metrics hook and cover the behavior with a BE unit test ### Release note Add two new BE metrics for file cache remote index read bytes: - `doris_be_inverted_index_bytes_read_from_remote` - `doris_be_segment_footer_index_bytes_read_from_remote` ### Check List (For Author) - Test <!-- At least one of them must be included. --> - [x] Regression test - `./run-regression-test.sh --run -d cloud_p0 -s test_file_cache_remote_index_byte_metrics -runMode=cloud` - [x] Unit Test - `./run-be-ut.sh --run --filter=DorisMetricsTest.*:FileCacheProfileReporterTest.*` - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason <!-- Add your reason? --> - Behavior changed: - [x] No. - [ ] Yes. - Does this need documentation? - [x] No. - [ ] Yes. <!-- Add document PR link here. eg: apache/doris-website#1214 --> ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
hello-stephen
commented
Jul 10, 2026
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
hello-stephen
commented
Jul 10, 2026
Contributor
run buildall |
1 similar comment
hoshinojyunn
commented
Jul 16, 2026
Contributor
run buildall |
hello-stephen
commented
Jul 16, 2026
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
Jul 16, 2026
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
Jul 17, 2026
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
1 similar comment
hello-stephen
commented
Jul 17, 2026
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
approved these changes
Jul 21, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #65398