Uh oh!
There was an error while loading. Please reload this page.
[fix](test) Isolate cloud mode in colocation proc test - #65515
Conversation
hello-stephen
commented
Jul 13, 2026
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
shuke987
commented
Jul 13, 2026
run buildall |
hello-stephen
commented
Jul 13, 2026
TPC-H: Total hot run time: 29487 ms |
hello-stephen
commented
Jul 13, 2026
TPC-DS: Total hot run time: 179463 ms |
hello-stephen
commented
Jul 13, 2026
ClickBench: Total hot run time: 24.94 s |
hello-stephen
commented
Jul 13, 2026
FE UT Coverage ReportIncrement line coverage `` 🎉 |
shuke987
commented
Jul 15, 2026
/review |
There was a problem hiding this comment.
Reviewed the test-only change in ColocationGroupProcDirTest. I did not find a blocking issue.
Checkpoint conclusions:
- Goal/test coverage: the patch keeps the cloud-mode colocation proc tests focused on the intended cloud fallback and
ReplicaAllocation == "null"behavior while avoiding direct globalConfig.deploy_modemutation. - Scope: the modification is narrow and limited to the affected FE unit test.
- Concurrency/locking/lifecycle: no production concurrency or locking path is changed; the new static mocks are scoped by try-with-resources, and the existing table unregister/register cleanup remains intact.
- Compatibility/persistence/config passing: no persisted format, RPC/Thrift, or runtime config behavior is changed.
- Parallel paths/performance/observability: no production path changes.
- Tests: this PR only adjusts existing FE unit tests. I did not run the FE test suite in this review-only runner.
- User focus: no additional user focus was provided.
Subagent convergence: normal test-harness, production-coverage, and risk-focused subagents all returned NO_NEW_VALUABLE_FINDINGS for the final no-inline comment set.
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
Uh oh!
There was an error while loading. Please reload this page.
Problem Summary: `ColocationGroupProcDirTest` runs with a local mock FE and a background heartbeat daemon. Four cloud proc tests temporarily changed the process-wide `Config.deploy_mode` to `cloud`. If heartbeat ran during that window, it could enter cloud-only backend handling against the local `SystemInfoService`, fail the heartbeat, and persist the only mock backend as dead. Later tests then failed during table setup with zero available backends, before reaching their proc assertions. Replace the process-wide configuration changes with thread-scoped static mocks of `Config.isCloudMode()`. The proc call under test still exercises the cloud branch, while the heartbeat thread continues to observe local mode. Classification: case bug. Product proc behavior and assertions are unchanged.
What problem does this PR solve?
Issue Number: N/A
Related PR: #60944
Problem Summary:
ColocationGroupProcDirTestruns with a local mock FE and a background heartbeat daemon. Four cloud proc tests temporarily changed the process-wideConfig.deploy_modetocloud. If heartbeat ran during that window, it could enter cloud-only backend handling against the localSystemInfoService, fail the heartbeat, and persist the only mock backend as dead. Later tests then failed during table setup with zero available backends, before reaching their proc assertions.Replace the process-wide configuration changes with thread-scoped static mocks of
Config.isCloudMode(). The proc call under test still exercises the cloud branch, while the heartbeat thread continues to observe local mode.Classification: case bug. Product proc behavior and assertions are unchanged.
Validation:
git diff --checkrun buildallon this PR.Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)