[fix](be) Use shortest round-trip floating-point strings by jacktengg · Pull Request #65609 · apache/doris

jacktengg · 2026-07-14T16:13:54Z

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
Formatting float and double values with max_digits10 preserves round-trip precision but emits redundant digits such as 1.1000000000000001. Use fmt Dragonbox shortest-round-trip formatting in BE and bit-exact matching formatting in FE, and synchronize affected tests and expected results.

Release note

Float and double values now use shortest round-trip string formatting consistently in FE and BE.

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

hello-stephen · 2026-07-14T16:13:59Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

jacktengg · 2026-07-14T16:14:05Z

run buildall

github-actions · 2026-07-14T16:15:14Z

Possible file(s) that should be tracked in LFS detected: 🚨

The following file(s) exceeds the file size limit: 1048576 bytes, as set in the .yml configuration files:

regression-test/data/datatype_p0/nested_types/query/test_nested_types_insert_into_with_s3.out

Consider using git-lfs to manage large files.

github-actions · 2026-07-14T16:54:15Z

Possible file(s) that should be tracked in LFS detected: 🚨

The following file(s) exceeds the file size limit: 1048576 bytes, as set in the .yml configuration files:

regression-test/data/datatype_p0/nested_types/query/test_nested_types_insert_into_with_s3.out

Consider using git-lfs to manage large files.

jacktengg · 2026-07-14T16:55:07Z

run buildall

### What problem does this PR solve? Issue Number: None Related PR: apache#65609 Problem Summary: The legacy analyzer FloatLiteral unit test still expected the previous precision-limited float and double formatting. Update all stale positive, negative, boundary, and scientific-notation expectations to the shortest round-trip format already used by FE and BE. ### Release note None ### Check List (For Author) - Test: Unit Test - ./run-fe-ut.sh --run org.apache.doris.analysis.FloatLiteralTest,org.apache.doris.analysis.ExprToStringValueVisitorTest,org.apache.doris.nereids.trees.expressions.literal.DoubleLiteralTest,org.apache.doris.nereids.trees.expressions.literal.FloatLiteralTest - Behavior changed: No - Does this need documentation: No

github-actions · 2026-07-14T17:05:12Z

Possible file(s) that should be tracked in LFS detected: 🚨

The following file(s) exceeds the file size limit: 1048576 bytes, as set in the .yml configuration files:

regression-test/data/datatype_p0/nested_types/query/test_nested_types_insert_into_with_s3.out

Consider using git-lfs to manage large files.

jacktengg · 2026-07-14T17:11:32Z

test

jacktengg · 2026-07-14T17:13:07Z

run buildall

hello-stephen · 2026-07-14T17:32:23Z

TPC-H: Total hot run time: 29594 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 01f656d28bd982484de94798f7c57d436512b179, data reload: false
------ Round 1 ----------------------------------
============================================
q1	17698	4063	4035	4035
q2	2017	350	212	212
q3	10299	1432	804	804
q4	4683	467	339	339
q5	7532	857	578	578
q6	185	172	136	136
q7	749	821	608	608
q8	9458	1682	1596	1596
q9	6257	4358	4336	4336
q10	6837	1772	1483	1483
q11	497	343	319	319
q12	758	549	425	425
q13	18161	3307	2744	2744
q14	262	271	238	238
q15	q16	784	788	706	706
q17	889	897	922	897
q18	7169	5775	5754	5754
q19	1162	1280	997	997
q20	766	667	527	527
q21	5781	2611	2568	2568
q22	425	356	292	292
Total cold run time: 102369 ms
Total hot run time: 29594 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4368	4271	4379	4271
q2	286	320	212	212
q3	4588	4932	4369	4369
q4	2068	2140	1347	1347
q5	4371	4293	4266	4266
q6	227	171	126	126
q7	1730	2007	1816	1816
q8	2653	2196	2191	2191
q9	8024	8021	7619	7619
q10	4715	4629	4203	4203
q11	584	428	378	378
q12	743	760	561	561
q13	3179	3561	3052	3052
q14	303	300	269	269
q15	q16	715	727	634	634
q17	1339	1322	1309	1309
q18	7884	7382	7173	7173
q19	1131	1107	1123	1107
q20	2207	2212	1912	1912
q21	5208	4528	4370	4370
q22	518	463	428	428
Total cold run time: 56841 ms
Total hot run time: 51613 ms

hello-stephen · 2026-07-14T17:43:36Z

TPC-DS: Total hot run time: 177975 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 01f656d28bd982484de94798f7c57d436512b179, data reload: false
query5	4314	642	482	482
query6	475	232	207	207
query7	4889	602	340	340
query8	330	193	167	167
query9	8782	3999	4042	3999
query10	468	350	298	298
query11	5891	2317	2185	2185
query12	166	102	101	101
query13	1263	603	447	447
query14	6251	5229	4857	4857
query14_1	4277	4281	4238	4238
query15	218	206	185	185
query16	1028	483	446	446
query17	925	741	589	589
query18	2443	484	354	354
query19	214	199	153	153
query20	111	107	106	106
query21	237	152	137	137
query22	13587	13509	13459	13459
query23	17282	16431	16243	16243
query23_1	16281	16228	16220	16220
query24	7495	1734	1289	1289
query24_1	1309	1288	1270	1270
query25	569	467	399	399
query26	1356	343	214	214
query27	2621	564	395	395
query28	4516	2007	2010	2007
query29	1075	637	492	492
query30	337	256	221	221
query31	1115	1093	970	970
query32	113	64	63	63
query33	533	323	257	257
query34	1163	1105	653	653
query35	780	770	666	666
query36	1200	1198	1095	1095
query37	155	144	88	88
query38	1861	1697	1661	1661
query39	882	870	840	840
query39_1	859	832	831	831
query40	236	153	135	135
query41	64	63	63	63
query42	91	89	94	89
query43	315	317	277	277
query44	1445	769	759	759
query45	196	184	170	170
query46	1063	1239	690	690
query47	2093	2122	2034	2034
query48	420	420	298	298
query49	578	417	304	304
query50	1045	408	330	330
query51	11015	10807	10782	10782
query52	84	85	72	72
query53	256	264	198	198
query54	277	221	208	208
query55	73	72	65	65
query56	300	275	267	267
query57	1314	1290	1220	1220
query58	267	265	233	233
query59	1577	1606	1393	1393
query60	303	259	248	248
query61	145	147	148	147
query62	544	495	434	434
query63	235	200	206	200
query64	2815	1061	846	846
query65	4753	4674	4635	4635
query66	1829	500	372	372
query67	29440	29278	29214	29214
query68	3157	1570	975	975
query69	412	293	268	268
query70	1036	961	923	923
query71	357	317	293	293
query72	3090	2663	2379	2379
query73	876	807	421	421
query74	5042	4884	4720	4720
query75	2507	2490	2113	2113
query76	2323	1161	758	758
query77	330	370	280	280
query78	11947	11936	11340	11340
query79	1446	1196	746	746
query80	1296	547	453	453
query81	522	317	277	277
query82	615	154	125	125
query83	368	319	292	292
query84	331	156	127	127
query85	951	605	506	506
query86	427	291	285	285
query87	1835	1808	1720	1720
query88	3740	2830	2771	2771
query89	427	362	324	324
query90	1887	199	184	184
query91	200	184	159	159
query92	60	60	56	56
query93	1631	1571	932	932
query94	724	373	346	346
query95	764	585	465	465
query96	1067	802	333	333
query97	2613	2610	2530	2530
query98	223	208	195	195
query99	1096	1125	1003	1003
Total cold run time: 263850 ms
Total hot run time: 177975 ms

hello-stephen · 2026-07-14T17:48:37Z

ClickBench: Total hot run time: 24.82 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 01f656d28bd982484de94798f7c57d436512b179, data reload: false
query1	0.00	0.00	0.00
query2	0.09	0.07	0.05
query3	0.26	0.12	0.13
query4	1.61	0.13	0.13
query5	0.24	0.21	0.21
query6	1.22	1.09	1.05
query7	0.04	0.01	0.01
query8	0.06	0.03	0.04
query9	0.38	0.30	0.31
query10	0.54	0.58	0.54
query11	0.19	0.14	0.14
query12	0.19	0.15	0.14
query13	0.46	0.46	0.47
query14	1.03	1.02	0.99
query15	0.63	0.59	0.61
query16	0.32	0.33	0.33
query17	1.12	1.16	1.11
query18	0.22	0.21	0.21
query19	2.06	1.87	1.96
query20	0.02	0.01	0.02
query21	15.42	0.21	0.13
query22	4.87	0.06	0.05
query23	16.13	0.31	0.12
query24	2.91	0.42	0.33
query25	0.10	0.05	0.04
query26	0.73	0.21	0.14
query27	0.06	0.02	0.03
query28	3.58	0.90	0.56
query29	12.49	4.07	3.21
query30	0.28	0.15	0.15
query31	2.77	0.58	0.32
query32	3.22	0.59	0.48
query33	3.18	3.17	3.18
query34	15.67	4.21	3.54
query35	3.49	3.50	3.51
query36	0.57	0.41	0.42
query37	0.09	0.06	0.07
query38	0.06	0.04	0.03
query39	0.04	0.03	0.03
query40	0.18	0.16	0.15
query41	0.08	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.03	0.04
Total cold run time: 96.68 s
Total hot run time: 24.82 s

hello-stephen · 2026-07-14T18:32:27Z

FE UT Coverage Report

Increment line coverage 100.00% (5/5) 🎉
Increment coverage report
Complete coverage report

hello-stephen · 2026-07-14T21:21:44Z

FE Regression Coverage Report

Increment line coverage 100.00% (5/5) 🎉
Increment coverage report
Complete coverage report

yiguolei · 2026-07-16T03:14:17Z

Do not modify it anymore

github-actions · 2026-07-24T07:29:03Z

Possible file(s) that should be tracked in LFS detected: 🚨

The following file(s) exceeds the file size limit: 1048576 bytes, as set in the .yml configuration files:

regression-test/data/datatype_p0/nested_types/query/test_nested_types_insert_into_with_s3.out

Consider using git-lfs to manage large files.

Formatting float and double values with max_digits10 preserves round-trip precision but emits redundant digits such as 1.1000000000000001. Use fmt Dragonbox shortest-round-trip formatting in BE and bit-exact matching formatting in FE, and synchronize affected tests and expected results.

jacktengg · 2026-07-27T14:58:39Z

run buildall

github-actions · 2026-07-27T15:38:05Z

Possible file(s) that should be tracked in LFS detected: 🚨

The following file(s) exceeds the file size limit: 1048576 bytes, as set in the .yml configuration files:

regression-test/data/datatype_p0/nested_types/base_cases/one_level_nestedtypes_with_s3data.out
regression-test/data/datatype_p0/nested_types/query/test_nested_types_insert_into_with_s3.out

Consider using git-lfs to manage large files.

hello-stephen · 2026-07-27T17:02:58Z

FE UT Coverage Report

Increment line coverage 100.00% (5/5) 🎉
Increment coverage report
Complete coverage report

github-actions · 2026-07-31T04:07:50Z

PR approved by at least one committer and no changes requested.

Issue Number: None Related PR: apache#65609 Problem Summary: Gitleaks treats random-string fixtures in four generated regression result files as generic API keys whenever floating-point formatting changes rewrite their long lines. Limit the allowlist to those exact paths and the synthetic random-string shape so real credential patterns remain detectable. None - Test: Manual test - Replayed Gitleaks v8.30.0 on the triggering commit range: 11 findings before, 0 after - Confirmed a generic credential positive control is still detected - Behavior changed: No - Does this need documentation: No

github-actions · 2026-08-03T03:01:44Z

Possible file(s) that should be tracked in LFS detected: 🚨

The following file(s) exceeds the file size limit: 1048576 bytes, as set in the .yml configuration files:

regression-test/data/datatype_p0/nested_types/base_cases/one_level_nestedtypes_with_s3data.out
regression-test/data/datatype_p0/nested_types/query/test_nested_types_insert_into_with_s3.out

Consider using git-lfs to manage large files.

# Conflicts: # .gitleaks.toml

github-actions · 2026-08-03T03:05:15Z

Possible file(s) that should be tracked in LFS detected: 🚨

The following file(s) exceeds the file size limit: 1048576 bytes, as set in the .yml configuration files:

regression-test/data/datatype_p0/nested_types/base_cases/one_level_nestedtypes_with_s3data.out
regression-test/data/datatype_p0/nested_types/query/test_nested_types_insert_into_with_s3.out

Consider using git-lfs to manage large files.

hello-stephen · 2026-08-03T03:05:46Z

skip buildall

HappenLee

LGTM

CalvinKirs

POM changes look good

Floating number to string is now handled correctly by CastToString::from_number in PR apache#65609, special handing in DataTypeNumberSerDe<T>::to_olap_string is not necessary now.

### What problem does this PR solve? Issue Number: close #xxx Related PR: #65302 Problem Summary: Floating number to string is now handled correctly by CastToString::from_number in PR #65609, special handing in DataTypeNumberSerDe<T>::to_olap_string is not necessary now. ### Release note None ### Check List (For Author) - Test  - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason  - Behavior changed: - [ ] No. - [ ] Yes.  - Does this need documentation? - [ ] No. - [ ] Yes.  ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label

…6425) ### What problem does this PR solve? Pick #65609 and #66375 Issue Number: close #xxx Related PR: #xxx Problem Summary: ### Release note None ### Check List (For Author) - Test  - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason  - Behavior changed: - [ ] No. - [ ] Yes.  - Does this need documentation? - [ ] No. - [ ] Yes.  ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label  --------- Co-authored-by: lidongyang <lidongyang@selectdb.com>

### What problem does this PR solve? Issue Number: close #xxx Related PR: #xxx Problem Summary: Formatting float and double values with max_digits10 preserves round-trip precision but emits redundant digits such as 1.1000000000000001. Use fmt Dragonbox shortest-round-trip formatting in BE and bit-exact matching formatting in FE, and synchronize affected tests and expected results. ### Release note Float and double values now use shortest round-trip string formatting consistently in FE and BE. ### Check List (For Author) - Test  - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason  - Behavior changed: - [ ] No. - [ ] Yes.  - Does this need documentation? - [ ] No. - [ ] Yes.  ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label  --------- Co-authored-by: lidongyang <lidongyang@selectdb.com>

### What problem does this PR solve? Issue Number: close #xxx Related PR: apache#65302 Problem Summary: Floating number to string is now handled correctly by CastToString::from_number in PR apache#65609, special handing in DataTypeNumberSerDe<T>::to_olap_string is not necessary now. ### Release note None ### Check List (For Author) - Test  - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason  - Behavior changed: - [ ] No. - [ ] Yes.  - Does this need documentation? - [ ] No. - [ ] Yes.  ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label

jacktengg requested review from 924060929, englefly, gavinchou, morrySnow and starocean999 as code owners July 14, 2026 16:13

github-actionsBot added the lfs-detected! Warning Label for use when LFS is detected in the commits of a Pull Request label Jul 14, 2026

yiguolei closed this Jul 16, 2026

jacktengg reopened this Jul 24, 2026

jacktengg force-pushed the wt-float-to-str-opt branch from 01f656d to 4823985Compare July 27, 2026 14:58

jacktengg requested a review from yiguolei as a code owner July 27, 2026 14:58

morrySnow previously approved these changes Jul 31, 2026
View reviewed changes

hello-stephen mentioned this pull request Aug 3, 2026
[fix](build) Allow generated regression fixtures in Gitleaks #66367
Closed

hello-stephen dismissed stale reviews from morrySnow and HappenLee via 4890de4August 3, 2026 03:01

Merge branch master into wt-float-to-str-opt
1213530
# Conflicts: # .gitleaks.toml

HappenLee approved these changes Aug 3, 2026
View reviewed changes

morrySnow approved these changes Aug 3, 2026
View reviewed changes

yiguolei approved these changes Aug 3, 2026
View reviewed changes

CalvinKirs approved these changes Aug 3, 2026
View reviewed changes

jacktengg merged commit af44286 into apache:masterAug 3, 2026
33 of 34 checks passed

jacktengg mentioned this pull request Aug 3, 2026
[chore](float) Unify floating number to string #66375
Merged
16 tasks

jacktengg added the dev/4.1.x label Aug 4, 2026

github-actionsBot added the dev/4.1.x-conflict label Aug 4, 2026

jacktengg deleted the wt-float-to-str-opt branch August 4, 2026 02:15

jacktengg mentioned this pull request Aug 4, 2026
[fix](be) Use shortest round-trip floating-point strings (#65609) #66425
Merged
16 tasks

yiguolei added dev/4.1.4-merged and removed dev/4.1.x dev/4.1.x-conflict labels Aug 4, 2026

HappenLee mentioned this pull request Aug 11, 2026
[feature](query) Generate TopN filters from aggregation #66652
Open

Baymine mentioned this pull request Aug 17, 2026
[fix](rowid-fetch) fix TopN lazy materialization crash with duplicate projected columns #64372
Merged
16 tasks

Uh oh!

Conversation

jacktengg commented Jul 14, 2026

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

hello-stephen commented Jul 14, 2026

Uh oh!

jacktengg commented Jul 14, 2026

Uh oh!

github-actionsBot commented Jul 14, 2026

Possible file(s) that should be tracked in LFS detected: 🚨

Uh oh!

github-actionsBot commented Jul 14, 2026

Possible file(s) that should be tracked in LFS detected: 🚨

Uh oh!

jacktengg commented Jul 14, 2026

Uh oh!

github-actionsBot commented Jul 14, 2026

Possible file(s) that should be tracked in LFS detected: 🚨

Uh oh!

jacktengg commented Jul 14, 2026

Uh oh!

jacktengg commented Jul 14, 2026

Uh oh!

hello-stephen commented Jul 14, 2026

Uh oh!

hello-stephen commented Jul 14, 2026

Uh oh!

hello-stephen commented Jul 14, 2026

Uh oh!

hello-stephen commented Jul 14, 2026

FE UT Coverage Report

Uh oh!

hello-stephen commented Jul 14, 2026

FE Regression Coverage Report

Uh oh!

yiguolei commented Jul 16, 2026

Uh oh!

github-actionsBot commented Jul 24, 2026

Possible file(s) that should be tracked in LFS detected: 🚨

Uh oh!

jacktengg commented Jul 27, 2026

Uh oh!

github-actionsBot commented Jul 27, 2026

Possible file(s) that should be tracked in LFS detected: 🚨

Uh oh!

hello-stephen commented Jul 27, 2026

FE UT Coverage Report

Uh oh!

github-actionsBot commented Jul 31, 2026

Uh oh!

github-actionsBot commented Aug 3, 2026

Possible file(s) that should be tracked in LFS detected: 🚨

Uh oh!

github-actionsBot commented Aug 3, 2026

Possible file(s) that should be tracked in LFS detected: 🚨

Uh oh!

hello-stephen commented Aug 3, 2026

Uh oh!

HappenLee left a comment

Choose a reason for hiding this comment

Uh oh!

CalvinKirs left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants