Uh oh!
There was an error while loading. Please reload this page.
[fix](ci) Generate local review context and randomize Codex auth - #65626
Conversation
### What problem does this PR solve? Issue Number: None Related PR: apache#65178 Problem Summary: The review runner fetched aggregate pull request diffs through the GitHub API. GitHub rejects diffs over 20,000 lines, so large pull requests failed before Codex ran. Fetch complete checkout history and generate the changed-file list and three-dot diff locally from the verified PR base and head. The prompt now states the exact diff semantics, and setup failures are reported accurately. ### Release note None ### Check List (For Author) - Test: Manual workflow validation in a temporary fork PR - Behavior changed: Yes (large pull requests no longer depend on GitHub aggregate diff limits) - Does this need documentation: No
### What problem does this PR solve? Issue Number: None Related PR: None Problem Summary: The review runner used one shared Codex auth object for every run. Select one of the two dedicated auth objects for each run, keep the downloaded filename as auth.json, and sync any refreshed credentials back to the selected source object. ### Release note None ### Check List (For Author) - Test: Static workflow checks and a temporary fork PR review run - Behavior changed: Yes (review runs distribute auth-file use across two OSS objects) - Does this need documentation: No
hello-stephen
commented
Jul 15, 2026
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
zclllyybb
commented
Jul 15, 2026
run buildall |
zclllyybb
commented
Jul 15, 2026
/review |
There was a problem hiding this comment.
I found one workflow correctness issue in the new failure-reporting path. The local diff/context generation and Codex auth randomization paths otherwise look coherent from static review: checkout verifies the requested head, context generation uses the verified three-dot range, auth sync writes back to the selected object, and the prompt accurately documents the merge-base-to-head diff semantics.
Critical checkpoint conclusions:
- Goal/test coverage: the PR addresses large-diff review context generation and auth-object contention; the author reports fork workflow coverage, but I did not run workflows from this review environment.
- Scope/focus: the change is focused to the review runner workflow.
- Concurrency/lifecycle: no runtime concurrency in Doris code; the CI auth-object split reduces shared-token contention, with sync-back tied to the selected object.
- Compatibility/parallel paths: failure reporting has a skipped-step edge case called out inline; review-context and Codex failure paths were otherwise traced.
- User focus: no additional user-provided review focus was supplied.
Uh oh!
There was an error while loading. Please reload this page.
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
Uh oh!
There was an error while loading. Please reload this page.
…che#65626) ### What problem does this PR solve? Issue Number: None Related PR: apache#65178 The review runner previously obtained the aggregate pull-request diff through the GitHub API. GitHub rejects aggregate diffs larger than 20,000 lines, causing large pull requests to fail before Codex could review them. The runner now checks out complete history and locally generates the changed-file list and the verified three-dot diff from the live base and head SHAs. The review prompt also states those diff semantics, and context-preparation failures are reported separately from Codex failures. Each run now randomly selects `oss://doris-community-ci/codex/auth.json.1` or `oss://doris-community-ci/codex/auth.json.2`, downloads it locally as `auth.json`, and syncs refreshed credentials back to that same selected object.
What problem does this PR solve?
Issue Number: None
Related PR: #65178
The review runner previously obtained the aggregate pull-request diff through the GitHub API. GitHub rejects aggregate diffs larger than 20,000 lines, causing large pull requests to fail before Codex could review them. The runner now checks out complete history and locally generates the changed-file list and the verified three-dot diff from the live base and head SHAs. The review prompt also states those diff semantics, and context-preparation failures are reported separately from Codex failures.
Each run now randomly selects
oss://doris-community-ci/codex/auth.json.1oross://doris-community-ci/codex/auth.json.2, downloads it locally asauth.json, and syncs refreshed credentials back to that same selected object.Release note
None
Check List (For Author)
git diff --check upstream/master...HEADauth.json.1and uploaded refreshed credentials back toauth.json.1.