Uh oh!
There was an error while loading. Please reload this page.
branch-4.1: [fix](inverted index) Split bound multi-segment readers #63138 - #65687
Merged
Merged
Conversation
### What problem does this PR solve? Issue Number: DORIS-25499 Related PR: None Problem Summary: query_v2 search collection can drive segment iteration from `readers.front()` while leaf scorers resolve CLucene readers from `reader_bindings` or `field_reader_bindings`. If the actual leaf reader remains a multi-segment reader, `SegmentPostings` calls `TermDocs::readBlock()`, which CLucene does not support for multi-segment readers and can abort BE. This PR selects the actual segmented reader from the execution context, rewrites all readers and reader bindings to segment-level readers for each callback, validates segmented reader topology, and keeps `MultiSegmentReader` / `MultiReader` doc base handling explicit. It also adds regression coverage for `MultiReader`, segmented field bindings, and explicit single-reader binding keys. ### Release note None ### Check List (For Author) - Test - [x] Regression test - Added `MultiSegmentCollectorTest.CollectDocSetWithMultiReader` - Added `MultiSegmentCollectorTest.CollectDocSetWithSegmentedFieldBinding` - Added `MultiSegmentCollectorTest.CollectDocSetWithSingleReaderBinding` - [x] Unit Test - `env CCACHE_DIR=/tmp/doris25499-master-ccache CCACHE_TEMPDIR=/tmp/doris25499-master-ccache-tmp ./run-be-ut.sh --run --filter=MultiSegmentCollectorTest.* -j 32` - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason - Behavior changed: - [x] No. - [ ] Yes. - Does this need documentation? - [x] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label
hello-stephen
commented
Jul 16, 2026
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
airborne12
commented
Jul 16, 2026
MemberAuthor
run buildall |
hello-stephen
commented
Jul 16, 2026
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
Jul 16, 2026
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
approved these changes
Jul 17, 2026
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
yiguolei
commented
Jul 17, 2026
Contributor
skip buildall |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Cherry-pick #63138 to branch-4.1.
Issue Number: DORIS-25499
Problem Summary:
query_v2 search collection can drive segment iteration from
readers.front()while leaf scorers resolve CLucene readers fromreader_bindingsorfield_reader_bindings. If the actual leaf reader remains a multi-segment reader,SegmentPostingscallsTermDocs::readBlock(), which CLucene does not support for multi-segment readers and can abort BE.Release note
None