Skip to content

branch-4.1: [Exec](shuffle) random shuffle firstly use local channel to improve performance #59431 - #66103

Merged
yiguolei merged 1 commit into
apache:branch-4.1from
HappenLee:pick-59431-branch-4.1
Jul 29, 2026
Merged

branch-4.1: [Exec](shuffle) random shuffle firstly use local channel to improve performance #59431#66103
yiguolei merged 1 commit into
apache:branch-4.1from
HappenLee:pick-59431-branch-4.1

Conversation

@HappenLee

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #59431

Problem Summary: Cherry-pick #59431 to branch-4.1. For RANDOM shuffle, the exchange sink used to send blocks to channels in round-robin order one by one. This change collects local channel ids during init and prefers sending to local channels first, reducing network overhead and improving performance.

Release note

None

Check List (For Author)

  • Test: No need to test (pure cherry-pick from master with minor conflict resolution on namespace)
  • Behavior changed: No
  • Does this need documentation: No

@HappenLee
HappenLee requested a review from yiguolei as a code ownerJuly 27, 2026 09:43
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@yiguolei

Copy link
Copy Markdown
Contributor

run buildall

1 similar comment
@HappenLee

Copy link
Copy Markdown
ContributorAuthor

run buildall

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Jul 28, 2026
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 10.00% (1/10) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage57.17% (23390/40916)
Line Coverage41.21% (232505/564233)
Region Coverage37.50% (184160/491157)
Branch Coverage38.56% (82867/214922)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (10/10) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage73.10% (29208/39956)
Line Coverage56.78% (318681/561258)
Region Coverage54.01% (266885/494112)
Branch Coverage54.72% (117685/215073)

@yiguolei

Copy link
Copy Markdown
Contributor

skip buildall

@yiguolei
yiguolei merged commit c64618c into apache:branch-4.1Jul 29, 2026
32 of 34 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@HappenLee@hello-stephen@yiguolei