Skip to content

branch-4.1: [feature](variant) Add native ColumnVariantV2 execution - #66188

Merged
yiguolei merged 1 commit into
apache:branch-4.1from
eldenmoon:branch-pick-pr-65561-to-branch-4.1
Jul 30, 2026
Merged

branch-4.1: [feature](variant) Add native ColumnVariantV2 execution#66188
yiguolei merged 1 commit into
apache:branch-4.1from
eldenmoon:branch-pick-pr-65561-to-branch-4.1

Conversation

@eldenmoon

@eldenmooneldenmoon commented Jul 28, 2026

Copy link
Copy Markdown
Member

cherry-pick #65561

@hello-stephen

hello-stephen commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@eldenmoon

eldenmoon commented Jul 28, 2026

Copy link
Copy Markdown
MemberAuthor

run buildall

@eldenmoon
eldenmoon marked this pull request as ready for review July 28, 2026 12:54
@eldenmoon
eldenmoon requested a review from yiguolei as a code ownerJuly 28, 2026 12:54
CopilotAI review requested due to automatic review settings July 28, 2026 12:54
CopilotAI reviewed Jul 28, 2026

CopilotAI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review this pull request because it exceeds the maximum number of lines (20,000). Try reducing the number of changed lines and requesting a review from Copilot again.

@eldenmoon
[feature](variant) Add native ColumnVariantV2 execution
d93c10a
### What problem does this PR solve?
Issue Number: None
Related PR: apache#65561
Problem Summary: Backport native ColumnVariantV2 execution to branch-4.1. The original change also altered legacy Variant analysis when enable_variant_v2 was disabled. Preserve branch-4.1 legacy GROUP BY, DISTINCT, set-operation, implicit JSON-cast, root comparison, and common-type behavior while enabling canonical Variant V2 execution when the session variable is enabled.
### Release note
Add native Variant V2 execution behind enable_variant_v2 on branch-4.1 while preserving legacy Variant behavior when disabled.
### Check List (For Author)
- Test:
- Regression test: variant_p0 test_variant_equality_contexts, test_variant_ordering_comparison_error, variant_parse_functions, variant_compute_v2
- Unit Test: 133 focused FE tests; 228 focused BE tests (1 additional disabled test)
- Build: ASAN BE build and FE build
- Behavior changed: Yes. Variant V2 execution is enabled only when enable_variant_v2=true; legacy Variant behavior remains unchanged when false.
- Does this need documentation: No
@eldenmoon
eldenmoonforce-pushed the branch-pick-pr-65561-to-branch-4.1 branch from cdd9d10 to d93c10aCompareJuly 28, 2026 12:58
@eldenmoon

eldenmoon commented Jul 28, 2026

Copy link
Copy Markdown
MemberAuthor

run buildall

@eldenmoon
eldenmoon marked this pull request as draft July 28, 2026 12:59
@eldenmoon
eldenmoon marked this pull request as ready for review July 28, 2026 13:00
@eldenmoon

eldenmoon commented Jul 28, 2026

Copy link
Copy Markdown
MemberAuthor

run buildall

@hello-stephen

hello-stephen commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage77.58% (1900/2449)
Line Coverage64.39% (33960/52745)
Region Coverage64.89% (17506/26980)
Branch Coverage54.04% (9379/17356)

@hello-stephen

hello-stephen commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage `` 🎉
Increment coverage report
Complete coverage report

@hello-stephen

hello-stephen commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 88.31% (7335/8306) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage57.87% (24101/41649)
Line Coverage41.92% (240049/572606)
Region Coverage37.97% (189174/498244)
Branch Coverage39.22% (85737/218587)

@hello-stephen

hello-stephen commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 87.75% (7175/8177) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage73.56% (29926/40680)
Line Coverage57.31% (326361/569503)
Region Coverage54.29% (272086/501171)
Branch Coverage55.16% (120645/218724)

1 similar comment
@hello-stephen

hello-stephen commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 87.75% (7175/8177) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage73.56% (29926/40680)
Line Coverage57.31% (326361/569503)
Region Coverage54.29% (272086/501171)
Branch Coverage55.16% (120645/218724)

@yiguolei
yiguolei merged commit 20635ab into apache:branch-4.1Jul 30, 2026
29 of 33 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@yiguoleiyiguoleiyiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eldenmoon@hello-stephen@yiguolei