[fix](table stream) Fix multi-segment row-binlog reads for MoW tables by TsukiokaKogane · Pull Request #66338 · apache/doris

TsukiokaKogane · 2026-07-31T10:57:11Z

What problem does this PR solve?

Issue Number: close#65901

Related PR: #65418

Problem Summary:

Table Stream queries over ROW binlog could crash or return incorrect results when a row-binlog rowset contained multiple segments. This affected both multi-segment rowsets generated by load and non-singleton overlapping rowsets produced by row-binlog LMax quick merge. Although the source table may use UNIQUE_KEYS with Merge-on-Write, the scan reads from its dedicated DUP_KEYS row-binlog tablet; the problem was caused by inconsistent iterator selection and incorrect ordering and grouping assumptions.

For a non-overlapping multi-segment rowset, force_key_ordered_read caused BetaRowsetReader to build a merge iterator solely because ordered output was required. The outer VCollectIterator could still select its block-based union path because the rowset was non-overlapping. This mismatch made the child iterator enter by-reference mode while its parent called the block interface, triggering the !_get_data_by_ref assertion and aborting the BE. Non-overlapping segments do not require a merge iterator because an ordered union already preserves key order.

Row-binlog LMax quick merge introduces another multi-segment layout: it links segments from multiple rowsets into a non-singleton rowset marked OVERLAPPING. The previous is_segments_overlapping() implementation only recognized singleton delta rowsets, so these quick-merge rowsets could incorrectly use the union path instead of merging their segments by key and TSO. The TSO column could also be skipped after zone-map pruning even though it is required as the merge sequence column.

In addition, MIN_DELTA processing used IteratorRowRef::is_same to identify consecutive events belonging to the same user key. This flag is a merge/dedup marker and does not reliably mark same-key events that reside in one segment after quick merge. As a result, one key's change chain could be split into multiple groups and folded incorrectly.

This change separates ordered-output requirements from iterator selection: non-overlapping segments use the ordered union path, while segments explicitly marked as overlapping use the merge path. It recognizes non-singleton overlapping rowsets created by quick merge, always materializes the row-binlog TSO column when it is needed for ordering, and groups MIN_DELTA events by comparing their user-key columns directly.

Before this change, affected queries could abort the BE, read quick-merge rowsets out of order, or produce incorrect MIN_DELTA results. After this change, multi-segment row-binlog rowsets are read through a consistent iterator interface and processed in key/TSO order with correct per-key change folding.

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

hello-stephen · 2026-07-31T10:57:17Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

TsukiokaKogane · 2026-07-31T10:57:50Z

run buildall

hello-stephen · 2026-07-31T11:48:35Z

TPC-H: Total hot run time: 29218 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 44b3c979a9d9ffdb2a99f285cefb2096d8d3dd75, data reload: false
------ Round 1 ----------------------------------
============================================
q1	17704	3980	3966	3966
q2	2007	325	204	204
q3	10270	1442	799	799
q4	4681	467	338	338
q5	7507	828	554	554
q6	176	166	135	135
q7	736	800	597	597
q8	9314	1620	1517	1517
q9	5366	4052	4041	4041
q10	6758	1635	1364	1364
q11	494	362	336	336
q12	717	580	463	463
q13	18104	3212	2724	2724
q14	264	251	238	238
q15	q16	742	731	661	661
q17	1027	946	952	946
q18	6774	5754	5667	5667
q19	1318	1295	1013	1013
q20	828	688	577	577
q21	6344	2868	2751	2751
q22	461	369	327	327
Total cold run time: 101592 ms
Total hot run time: 29218 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4991	4480	4649	4480
q2	287	329	227	227
q3	4888	5264	4694	4694
q4	2185	2254	1445	1445
q5	4680	4410	4374	4374
q6	225	174	128	128
q7	1961	1708	1522	1522
q8	2314	2037	1994	1994
q9	7110	6653	6685	6653
q10	4276	4182	3793	3793
q11	500	369	336	336
q12	696	698	491	491
q13	2946	3267	2720	2720
q14	263	282	248	248
q15	q16	661	688	597	597
q17	1232	1213	1202	1202
q18	7258	6847	6761	6761
q19	1069	1025	1104	1025
q20	2191	2190	1921	1921
q21	5624	4575	4444	4444
q22	504	439	410	410
Total cold run time: 55861 ms
Total hot run time: 49465 ms

hello-stephen · 2026-07-31T11:59:22Z

TPC-DS: Total hot run time: 169216 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 44b3c979a9d9ffdb2a99f285cefb2096d8d3dd75, data reload: false
query5	4337	603	490	490
query6	460	217	211	211
query7	4927	626	334	334
query8	328	177	166	166
query9	8762	4037	4022	4022
query10	444	353	292	292
query11	5808	2203	1998	1998
query12	155	102	95	95
query13	1291	612	446	446
query14	6133	4663	4379	4379
query14_1	3829	3806	3796	3796
query15	212	207	175	175
query16	1007	485	479	479
query17	1108	694	571	571
query18	2481	466	345	345
query19	208	194	149	149
query20	116	106	102	102
query21	231	158	135	135
query22	13156	13131	12829	12829
query23	17256	16444	16011	16011
query23_1	16123	16131	16117	16117
query24	7535	1662	1228	1228
query24_1	1270	1267	1232	1232
query25	565	495	374	374
query26	1321	373	215	215
query27	2593	613	382	382
query28	4445	2021	2039	2021
query29	1096	665	466	466
query30	340	257	234	234
query31	1092	1078	960	960
query32	101	61	60	60
query33	533	300	235	235
query34	1186	1111	636	636
query35	732	737	648	648
query36	773	778	712	712
query37	147	107	93	93
query38	1831	1652	1601	1601
query39	829	853	787	787
query39_1	784	778	785	778
query40	246	165	138	138
query41	65	63	63	63
query42	93	93	95	93
query43	316	319	278	278
query44	1405	768	764	764
query45	180	175	171	171
query46	1010	1193	689	689
query47	1548	1543	1443	1443
query48	389	385	295	295
query49	598	405	299	299
query50	1057	422	348	348
query51	10563	10364	10419	10364
query52	85	83	73	73
query53	263	290	197	197
query54	288	235	213	213
query55	74	70	66	66
query56	291	296	292	292
query57	1025	995	915	915
query58	285	258	250	250
query59	1555	1607	1352	1352
query60	327	264	247	247
query61	157	147	138	138
query62	394	321	275	275
query63	242	198	191	191
query64	2816	1012	837	837
query65	3858	3864	3818	3818
query66	1824	468	366	366
query67	28232	28148	28082	28082
query68	3167	1510	990	990
query69	389	299	266	266
query70	909	779	778	778
query71	364	326	322	322
query72	2961	2603	2344	2344
query73	850	767	418	418
query74	4605	4515	4309	4309
query75	2404	2399	1982	1982
query76	2321	1159	752	752
query77	339	388	268	268
query78	11212	11197	10644	10644
query79	1367	1153	756	756
query80	700	556	446	446
query81	472	326	284	284
query82	554	150	120	120
query83	385	321	295	295
query84	271	159	131	131
query85	954	622	533	533
query86	318	253	217	217
query87	1805	1792	1767	1767
query88	3692	2827	2788	2788
query89	402	320	284	284
query90	1861	195	195	195
query91	212	192	159	159
query92	65	62	57	57
query93	1634	1641	944	944
query94	586	349	302	302
query95	779	497	555	497
query96	1055	770	350	350
query97	2442	2472	2359	2359
query98	202	197	193	193
query99	722	716	613	613
Total cold run time: 254849 ms
Total hot run time: 169216 ms

hello-stephen · 2026-07-31T12:04:13Z

ClickBench: Total hot run time: 23.94 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 44b3c979a9d9ffdb2a99f285cefb2096d8d3dd75, data reload: false
query1	0.01	0.01	0.00
query2	0.09	0.06	0.05
query3	0.26	0.13	0.14
query4	1.61	0.15	0.13
query5	0.23	0.21	0.21
query6	1.16	0.82	0.81
query7	0.04	0.01	0.01
query8	0.06	0.04	0.04
query9	0.37	0.31	0.30
query10	0.54	0.55	0.58
query11	0.20	0.15	0.13
query12	0.17	0.14	0.14
query13	0.47	0.47	0.47
query14	1.01	1.02	0.98
query15	0.60	0.59	0.59
query16	0.32	0.33	0.33
query17	1.16	1.06	1.09
query18	0.22	0.20	0.20
query19	2.11	1.92	1.92
query20	0.02	0.01	0.01
query21	15.44	0.23	0.13
query22	4.89	0.04	0.05
query23	16.11	0.29	0.14
query24	2.96	0.46	0.32
query25	0.10	0.05	0.04
query26	0.73	0.21	0.16
query27	0.05	0.03	0.04
query28	3.55	0.86	0.35
query29	12.52	4.04	3.21
query30	0.27	0.17	0.16
query31	2.76	0.56	0.31
query32	3.21	0.60	0.49
query33	3.15	3.30	3.20
query34	15.48	3.95	3.30
query35	3.22	3.23	3.24
query36	0.55	0.45	0.41
query37	0.09	0.07	0.06
query38	0.06	0.04	0.04
query39	0.04	0.04	0.03
query40	0.17	0.15	0.15
query41	0.09	0.03	0.03
query42	0.04	0.02	0.03
query43	0.04	0.03	0.04
Total cold run time: 96.17 s
Total hot run time: 23.94 s

hello-stephen · 2026-07-31T14:21:34Z

BE Regression && UT Coverage Report

Increment line coverage 100.00% (1/1) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	75.83% (32040/42251)
Line Coverage	60.46% (357186/590798)
Region Coverage	56.92% (299095/525493)
Branch Coverage	58.30% (134689/231038)

TsukiokaKogane · 2026-08-04T08:18:27Z

run buildall

HappenLee · 2026-08-04T08:35:26Z

/review

github-actions

Two issues need resolution; see the inline comments.

Critical checkpoint conclusions:

Goal and proof: The APPEND_ONLY crash trigger is correctly identified, and the DUP/MoW sections cover that direct block path. However, the blanket union-mode change leaves the supported MIN_DELTA/DETAIL row-wise child handoff able to crash (P1), so the fix is not complete across parallel consumers. The schema-derived is_unique change is correct, but its distinct event-preservation behavior has no direct regression oracle (P2).
Scope and parallel paths: The production edits are localized. Ordinary/projected UNIQUE reads, AGG paths, row-binlog DUP semantics, compaction, schema-change, checksum, and cloud/manual uniqueness contexts were traced. No storage-format, protocol, or rolling-upgrade incompatibility was introduced.
Concurrency, lifecycle, and errors: The iterator state is scanner-local and sequential; no new threads, locks, atomics, or lock-order concerns apply. The surviving defect is lifecycle initialization at union-child handoff: a later child can reach a null block before reader status propagation. Shared-block ownership, same bits, EOF handling, row locations, reverse traversal, and empty-child erasure are otherwise coherent once the child is initialized.
Configuration and observability: No production configuration is added. The regression's temporary BE setting and debug point are scoped and restored, and the non-cloud restriction matches existing row-binlog support. No new metric or log is required for this local correction.
Tests and results: The added output is internally consistent and deterministically ordered for the APPEND_ONLY cases. Coverage is missing for a row-wise multi-rowset handoff and for same-key/same-TSO events split across segments of one forced-merge rowset. No build or test was run during this static-only review.
Persistence and writes: The production change is read-time only; it adds no transaction, persistence, edit-log, write-atomicity, or FE-BE variable work.
Performance: No separate substantiated performance blocker survived review; correctness initialization must be fixed first.
User focus: No additional user-provided focus was present, so the whole PR received the normal complete review.

Review completion: complete after two review rounds; all candidates were accepted, deduplicated, or dismissed before freezing this request-changes payload.

hello-stephen · 2026-08-04T11:58:25Z

TPC-H: Total hot run time: 28727 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 690d6942ce7fcb6b930d5b7c7f27bf9700b9c82e, data reload: false
------ Round 1 ----------------------------------
============================================
q1	17707	4040	3941	3941
q2	2053	321	200	200
q3	10279	1438	804	804
q4	4683	464	343	343
q5	7554	837	552	552
q6	176	167	134	134
q7	741	797	603	603
q8	9337	1539	1541	1539
q9	5376	4047	4111	4047
q10	6718	1629	1352	1352
q11	493	369	337	337
q12	709	575	456	456
q13	18109	3338	2771	2771
q14	267	258	233	233
q15	q16	745	736	664	664
q17	1032	981	928	928
q18	6632	5623	5547	5547
q19	1361	1197	1047	1047
q20	767	705	565	565
q21	5880	2590	2367	2367
q22	425	355	297	297
Total cold run time: 101044 ms
Total hot run time: 28727 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1	4266	4177	4184	4177
q2	278	319	208	208
q3	4594	4985	4436	4436
q4	2158	2253	1409	1409
q5	4224	4108	4104	4104
q6	225	171	125	125
q7	1687	1641	1400	1400
q8	2718	2252	2169	2169
q9	7374	7441	7374	7374
q10	4329	4256	3880	3880
q11	560	421	368	368
q12	756	734	520	520
q13	3289	3516	2887	2887
q14	314	318	273	273
q15	q16	705	740	680	680
q17	1305	1262	1266	1262
q18	12104	11056	11854	11056
q19	1133	1144	1173	1144
q20	2228	2270	1933	1933
q21	5612	4784	4955	4784
q22	597	489	431	431
Total cold run time: 60456 ms
Total hot run time: 54620 ms

hello-stephen · 2026-08-04T12:09:05Z

TPC-DS: Total hot run time: 166289 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 690d6942ce7fcb6b930d5b7c7f27bf9700b9c82e, data reload: false
query5	4299	586	457	457
query6	479	212	196	196
query7	4852	590	346	346
query8	322	157	157	157
query9	8775	4099	4091	4091
query10	459	344	319	319
query11	5829	2186	2002	2002
query12	151	100	95	95
query13	1261	575	448	448
query14	6029	4239	3928	3928
query14_1	3771	3749	3760	3749
query15	194	194	175	175
query16	985	452	427	427
query17	897	686	524	524
query18	2435	444	321	321
query19	198	183	137	137
query20	105	98	104	98
query21	235	154	132	132
query22	13050	13094	12779	12779
query23	15763	14961	14555	14555
query23_1	15441	15090	15087	15087
query24	7677	1720	1201	1201
query24_1	1243	1250	1232	1232
query25	548	456	386	386
query26	1317	353	218	218
query27	2614	577	389	389
query28	4609	2079	2036	2036
query29	1074	577	474	474
query30	331	266	219	219
query31	1153	1112	1023	1023
query32	108	55	56	55
query33	512	288	235	235
query34	1192	1152	636	636
query35	713	739	621	621
query36	776	765	704	704
query37	147	97	87	87
query38	1822	1770	1661	1661
query39	831	826	796	796
query39_1	819	769	774	769
query40	246	157	138	138
query41	62	58	58	58
query42	90	86	88	86
query43	317	318	275	275
query44	1423	770	765	765
query45	177	167	164	164
query46	1007	1181	709	709
query47	1516	1546	1438	1438
query48	401	427	290	290
query49	593	420	304	304
query50	1046	444	316	316
query51	10383	10658	10302	10302
query52	82	85	73	73
query53	246	267	191	191
query54	269	226	225	225
query55	72	73	66	66
query56	295	280	286	280
query57	1023	1003	914	914
query58	275	253	255	253
query59	1495	1557	1368	1368
query60	296	275	264	264
query61	152	142	148	142
query62	396	316	271	271
query63	223	198	194	194
query64	2844	1021	858	858
query65	3897	3816	3793	3793
query66	1856	469	357	357
query67	28119	28122	28061	28061
query68	3374	1594	1056	1056
query69	418	296	254	254
query70	876	780	771	771
query71	371	347	318	318
query72	3044	2627	2421	2421
query73	857	837	439	439
query74	4609	4501	4307	4307
query75	2385	2336	1998	1998
query76	2283	1148	751	751
query77	339	366	269	269
query78	11180	11083	10587	10587
query79	1377	1185	732	732
query80	737	530	476	476
query81	466	329	283	283
query82	628	176	134	134
query83	402	328	306	306
query84	318	161	140	140
query85	965	593	520	520
query86	347	228	218	218
query87	1976	1939	1833	1833
query88	3695	2814	2779	2779
query89	388	321	280	280
query90	1773	192	193	192
query91	196	187	162	162
query92	60	57	53	53
query93	1554	1556	970	970
query94	591	343	313	313
query95	780	578	470	470
query96	1091	785	356	356
query97	2434	2476	2317	2317
query98	189	184	181	181
query99	723	737	614	614
Total cold run time: 252431 ms
Total hot run time: 166289 ms

hello-stephen · 2026-08-04T12:14:01Z

ClickBench: Total hot run time: 23.9 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 690d6942ce7fcb6b930d5b7c7f27bf9700b9c82e, data reload: false
query1	0.00	0.00	0.01
query2	0.09	0.05	0.04
query3	0.25	0.14	0.13
query4	1.61	0.14	0.13
query5	0.26	0.21	0.22
query6	1.16	0.84	0.81
query7	0.04	0.01	0.01
query8	0.06	0.04	0.04
query9	0.36	0.32	0.31
query10	0.54	0.55	0.58
query11	0.19	0.13	0.15
query12	0.17	0.14	0.14
query13	0.46	0.47	0.47
query14	1.02	1.01	0.98
query15	0.60	0.59	0.58
query16	0.32	0.32	0.32
query17	1.09	1.08	1.12
query18	0.22	0.21	0.19
query19	2.08	1.88	1.92
query20	0.02	0.01	0.01
query21	15.47	0.21	0.15
query22	4.79	0.05	0.06
query23	16.12	0.31	0.12
query24	3.02	0.46	0.31
query25	0.10	0.05	0.05
query26	0.74	0.22	0.15
query27	0.04	0.04	0.03
query28	3.50	0.77	0.34
query29	12.47	4.06	3.17
query30	0.27	0.15	0.16
query31	2.76	0.57	0.31
query32	3.22	0.66	0.54
query33	3.16	3.26	3.28
query34	15.58	3.97	3.28
query35	3.19	3.19	3.25
query36	0.55	0.43	0.42
query37	0.08	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.03	0.03
query40	0.17	0.16	0.15
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.03	0.03
Total cold run time: 96.02 s
Total hot run time: 23.9 s

TsukiokaKogane · 2026-08-05T03:23:17Z

run buildall

TsukiokaKogane · 2026-08-05T04:39:43Z

run buildall

TsukiokaKogane · 2026-08-11T12:45:36Z

run buildall

TsukiokaKogane · 2026-08-11T13:30:06Z

run buildall

TsukiokaKogane · 2026-08-13T01:44:05Z

run buildall

hello-stephen · 2026-08-13T06:41:37Z

TPC-H: Total hot run time: 29557 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2b8173d69e5b936e2ea32d3a1aac18e8fa245b33, data reload: false
------ Round 1 ----------------------------------
============================================
q1	17604	4164	4188	4164
q2	2085	334	208	208
q3	10263	1514	826	826
q4	4684	476	346	346
q5	7503	879	568	568
q6	192	181	142	142
q7	783	807	607	607
q8	9345	1544	1674	1544
q9	5400	4121	4079	4079
q10	6743	1635	1378	1378
q11	515	379	327	327
q12	721	572	448	448
q13	18128	3366	2763	2763
q14	271	258	238	238
q15	q16	746	731	678	678
q17	1047	1015	921	921
q18	6702	5656	5557	5557
q19	1171	1271	1133	1133
q20	816	689	582	582
q21	6000	2850	2722	2722
q22	472	379	326	326
Total cold run time: 101191 ms
Total hot run time: 29557 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1	5190	4881	4906	4881
q2	300	324	214	214
q3	5016	5263	4721	4721
q4	2218	2329	1451	1451
q5	4771	4498	4438	4438
q6	231	177	132	132
q7	1864	1708	1559	1559
q8	2388	2160	2090	2090
q9	7305	6843	6724	6724
q10	4268	4429	3800	3800
q11	543	401	343	343
q12	707	713	501	501
q13	3077	3346	2790	2790
q14	274	282	250	250
q15	q16	674	692	623	623
q17	1268	1253	1236	1236
q18	12149	11069	11905	11069
q19	1080	1050	1086	1050
q20	2238	2195	1912	1912
q21	5358	4543	4624	4543
q22	522	460	399	399
Total cold run time: 61441 ms
Total hot run time: 54726 ms

hello-stephen · 2026-08-13T06:51:51Z

TPC-DS: Total hot run time: 158011 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2b8173d69e5b936e2ea32d3a1aac18e8fa245b33, data reload: false
query5	4309	602	462	462
query6	473	217	223	217
query7	4860	606	316	316
query8	329	172	153	153
query9	8802	4051	4039	4039
query10	464	358	302	302
query11	5815	2175	2031	2031
query12	149	94	95	94
query13	1242	586	411	411
query14	6055	4357	4004	4004
query14_1	3845	3808	3866	3808
query15	199	206	181	181
query16	1023	501	471	471
query17	909	687	541	541
query18	2427	476	337	337
query19	200	175	145	145
query20	107	104	102	102
query21	235	157	134	134
query22	12994	13045	12799	12799
query23	16010	15179	14591	14591
query23_1	14637	14577	14757	14577
query24	7521	1734	1250	1250
query24_1	1248	1238	1245	1238
query25	562	451	388	388
query26	1312	365	207	207
query27	2630	610	389	389
query28	4610	2031	1997	1997
query29	1114	612	467	467
query30	346	256	221	221
query31	1169	1107	1067	1067
query32	115	61	58	58
query33	501	314	235	235
query34	1189	1132	636	636
query35	741	743	634	634
query36	790	763	689	689
query37	160	107	91	91
query38	1838	1763	1722	1722
query39	823	821	795	795
query39_1	808	793	782	782
query40	255	168	143	143
query41	65	63	62	62
query42	95	93	94	93
query43	325	325	289	289
query44	1397	760	769	760
query45	186	179	169	169
query46	1081	1129	704	704
query47	1511	1500	1470	1470
query48	384	396	304	304
query49	589	400	297	297
query50	1034	435	329	329
query51	10616	10543	10420	10420
query52	94	94	77	77
query53	263	270	213	213
query54	287	246	229	229
query55	75	72	68	68
query56	297	306	313	306
query57	1039	986	933	933
query58	306	254	256	254
query59	1607	1671	1424	1424
query60	302	273	265	265
query61	151	151	148	148
query62	407	313	266	266
query63	243	196	196	196
query64	2827	1022	819	819
query65	3922	3818	3813	3813
query66	1835	473	356	356
query67	20426	20364	19719	19719
query68	3180	1537	949	949
query69	399	300	293	293
query70	879	759	783	759
query71	367	333	349	333
query72	3103	2855	2447	2447
query73	800	756	447	447
query74	4630	4518	4305	4305
query75	2366	2343	2003	2003
query76	2340	1158	774	774
query77	354	377	281	281
query78	11312	11128	10609	10609
query79	1358	1171	760	760
query80	764	597	514	514
query81	476	334	287	287
query82	641	175	143	143
query83	410	334	303	303
query84	330	170	129	129
query85	968	625	505	505
query86	345	239	230	230
query87	1992	1943	1813	1813
query88	3764	2774	2757	2757
query89	396	316	285	285
query90	1858	190	201	190
query91	201	191	166	166
query92	68	62	55	55
query93	1595	1544	993	993
query94	614	351	329	329
query95	785	518	474	474
query96	1111	815	351	351
query97	2460	2453	2366	2366
query98	195	186	182	182
query99	746	737	622	622
Total cold run time: 245215 ms
Total hot run time: 158011 ms

hello-stephen · 2026-08-13T06:56:49Z

ClickBench: Total hot run time: 24.21 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2b8173d69e5b936e2ea32d3a1aac18e8fa245b33, data reload: false
query1	0.01	0.01	0.01
query2	0.10	0.05	0.05
query3	0.26	0.14	0.14
query4	1.61	0.14	0.14
query5	0.24	0.22	0.22
query6	1.16	0.86	0.82
query7	0.05	0.01	0.01
query8	0.06	0.04	0.04
query9	0.39	0.33	0.31
query10	0.56	0.56	0.55
query11	0.20	0.14	0.14
query12	0.18	0.15	0.15
query13	0.49	0.48	0.47
query14	1.00	0.99	0.99
query15	0.62	0.60	0.61
query16	0.32	0.33	0.32
query17	1.11	1.10	1.09
query18	0.21	0.20	0.20
query19	2.04	2.01	1.96
query20	0.02	0.02	0.01
query21	15.44	0.21	0.14
query22	4.89	0.05	0.05
query23	16.14	0.33	0.12
query24	2.92	0.46	0.33
query25	0.11	0.05	0.04
query26	0.73	0.21	0.15
query27	0.04	0.03	0.04
query28	3.55	0.80	0.36
query29	12.48	4.20	3.32
query30	0.30	0.18	0.17
query31	2.78	0.55	0.32
query32	3.24	0.59	0.49
query33	3.15	3.26	3.17
query34	15.37	3.98	3.29
query35	3.28	3.20	3.21
query36	0.55	0.44	0.43
query37	0.09	0.06	0.07
query38	0.05	0.04	0.04
query39	0.04	0.03	0.04
query40	0.18	0.16	0.15
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.04
Total cold run time: 96.13 s
Total hot run time: 24.21 s

hello-stephen · 2026-08-20T16:27:21Z

BE UT Coverage Report

Increment line coverage 100.00% (3/3) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	62.32% (29056/46625)
Line Coverage	47.42% (304421/642021)
Region Coverage	43.07% (245736/570518)
Branch Coverage	44.64% (114394/256245)

csun5285 · 2026-08-21T02:42:46Z

/review

github-actions

Review result: request changes for two nonduplicate findings (one rolling-upgrade correctness issue and one persistent performance regression). The review converged after two rounds; all three Round 2 passes returned NO_NEW_VALUABLE_FINDINGS, and the final sweep covered all 18 changed files.

Critical checkpoints:

Goal and proof: The PR correctly improves row-binlog key/TSO ordering for newly produced data, but it does not fully accomplish safe deployment because an upgraded reader can misread pre-existing or concurrently old-produced horizontal-compaction rowsets. The new tests prove current-producer cases, not that compatibility case.
Scope and clarity: The production changes are focused and their new conditions are documented; no unrelated source change was found.
Concurrency and thread safety: No new shared mutable state, thread entry, lock order, or atomic protocol is introduced. Existing writer statistics remain protected while copied into metadata; no deadlock or heavy-under-lock issue was found.
Lifecycle and static initialization: Rowset-reader acquire/release and iterator ownership remain balanced. No new static/global initialization dependency, circular ownership, or abnormal release path was found.
Configuration: No configuration item is added. The existing dynamically selected horizontal-compaction path is part of the P1 compatibility trigger.
Compatibility and persistence: P1 below is blocking: the removed read-side fallback leaves stale NONOVERLAPPING metadata unsafe during upgrade. Current snapshot rename may recompute the bit, but ordinary persisted rowsets, mixed-version production, and index manual-build remain uncovered.
Parallel paths and conditions: Horizontal, vertical, LMax quick-merge, direct-load, APPEND_ONLY, MIN_DELTA/DETAIL, local/cloud writer, empty/single-segment, and parallel-scanner paths were checked. Current producers publish safe metadata; no additional parallel-path defect was found.
Tests and expected results: Added BE unit/regression expectations are internally consistent and cover grouping, cross-rowset order, forced segment boundaries, and quick merge. Missing negative coverage remains for stale pre-upgrade metadata and disjoint string keys sharing a 36-byte prefix. No local build/test was run because this review job forbids builds.
Observability: Existing reader/compaction diagnostics are adequate for these local paths; no new distributed operation or critical metric requirement was identified.
Transactions, data writes, and crash behavior: Commit/visibility and rowset publication flows are unchanged, and no new atomicity, delete-bitmap, failover, leak, or crash-order issue was found. The P1 problem is persisted metadata compatibility, not a new transaction boundary.
FE/BE protocol: No transmitted variable or protocol field is added, so there is no FE-BE propagation gap.
Error handling, memory safety, and nullability: Changed calls preserve Status propagation; no unchecked error, new allocation ownership, reservation, nullable/const-column, or defensive-continuation issue was found.
Performance: P2 below persistently selects merge behavior and inflates compaction score for disjoint long-prefix keys. The unconditional TSO-read concern is already covered by live thread r3820374570 and was not duplicated.
Other findings and completion: Existing live threads fence the earlier handoff, direct-load coverage, RowsetMeta-scope, horizontal future-producer, and TSO-I/O concerns. No unresolved candidate remains.
CI: COMPILE, BE UT, NonConcurrent Regression, cloud_p0, vault_p0, External Regression, and performance are green. General P0 Regression is red, but its TeamCity detail is authentication-gated and the status exposes no failure evidence that can be attributed to this diff.
User focus: No additional focus was supplied; the complete PR was reviewed.

TsukiokaKogane · 2026-08-21T03:16:43Z

run p0

hello-stephen · 2026-08-21T05:48:27Z

BE Regression && UT Coverage Report

Increment line coverage 100.00% (3/3) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	75.94% (34292/45159)
Line Coverage	60.96% (386866/634671)
Region Coverage	57.27% (325510/568350)
Branch Coverage	58.00% (148187/255516)

TsukiokaKogane · 2026-08-21T12:25:59Z

run buildall

hello-stephen · 2026-08-21T14:01:17Z

TPC-H: Total hot run time: 17333 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9181de7c55043e0e65665fd18dc721c198c682f6, data reload: false
------ Round 1 ----------------------------------
============================================
q1	17575	3060	3051	3051
q2	1917	240	156	156
q3	10434	854	513	513
q4	4666	245	211	211
q5	7670	578	382	382
q6	138	121	93	93
q7	532	501	388	388
q8	9238	956	854	854
q9	3517	2439	2405	2405
q10	6501	869	729	729
q11	437	255	244	244
q12	707	380	321	321
q13	17856	1540	1178	1178
q14	155	149	138	138
q15	q16	442	407	372	372
q17	847	866	831	831
q18	3129	2297	2256	2256
q19	1115	938	785	785
q20	677	501	462	462
q21	5287	1737	1989	1737
q22	330	264	227	227
Total cold run time: 93170 ms
Total hot run time: 17333 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1	3361	3346	3315	3315
q2	211	215	152	152
q3	2260	2354	2263	2263
q4	1197	1163	907	907
q5	2189	2155	2190	2155
q6	176	131	88	88
q7	1064	894	855	855
q8	1608	1424	1432	1424
q9	3177	3122	3145	3122
q10	1861	1818	1651	1651
q11	354	269	254	254
q12	451	435	339	339
q13	1460	1538	1173	1173
q14	173	164	156	156
q15	q16	391	398	365	365
q17	1053	1034	1028	1028
q18	5082	4448	4822	4448
q19	873	852	857	852
q20	993	974	841	841
q21	3711	3128	3255	3128
q22	393	345	341	341
Total cold run time: 32038 ms
Total hot run time: 28857 ms

hello-stephen · 2026-08-21T14:07:51Z

TPC-DS: Total hot run time: 83086 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9181de7c55043e0e65665fd18dc721c198c682f6, data reload: false
query5	4292	417	338	338
query6	400	165	157	157
query7	4865	465	265	265
query8	289	127	115	115
query9	8676	2879	2872	2872
query10	421	267	209	209
query11	5375	1046	922	922
query12	116	77	69	69
query13	1190	439	315	315
query14	6127	2195	2079	2079
query14_1	1974	1972	1962	1962
query15	174	124	114	114
query16	935	377	355	355
query17	815	446	368	368
query18	2338	336	237	237
query19	170	148	115	115
query20	76	73	73	73
query21	217	120	102	102
query22	5525	5391	5341	5341
query23	7189	6292	6080	6080
query23_1	6060	5946	6101	5946
query24	7310	1099	790	790
query24_1	785	806	768	768
query25	447	330	280	280
query26	1252	279	171	171
query27	2697	452	282	282
query28	4608	1489	1505	1489
query29	947	451	362	362
query30	295	183	158	158
query31	855	435	366	366
query32	111	53	51	51
query33	478	222	200	200
query34	990	854	489	489
query35	405	408	351	351
query36	564	562	529	529
query37	129	82	72	72
query38	1024	869	843	843
query39	509	486	500	486
query39_1	476	476	461	461
query40	229	131	115	115
query41	59	60	61	60
query42	87	82	87	82
query43	241	242	210	210
query44	1034	566	550	550
query45	115	106	105	105
query46	779	863	546	546
query47	777	737	724	724
query48	321	295	214	214
query49	553	243	211	211
query50	813	324	253	253
query51	8078	7692	7895	7692
query52	76	80	66	66
query53	204	245	158	158
query54	239	174	166	166
query55	72	59	56	56
query56	225	223	239	223
query57	690	685	645	645
query58	227	221	190	190
query59	1205	1212	1070	1070
query60	249	218	213	213
query61	117	118	119	118
query62	407	233	196	196
query63	201	169	149	149
query64	2746	702	578	578
query65	1604	1654	1618	1618
query66	2432	316	254	254
query67	10090	10007	9748	9748
query68	2748	1182	775	775
query69	349	217	185	185
query70	694	587	571	571
query71	310	254	237	237
query72	2295	1760	1530	1530
query73	665	611	354	354
query74	1594	1244	1130	1130
query75	1221	1150	1007	1007
query76	2287	745	544	544
query77	260	261	211	211
query78	3928	3672	3312	3312
query79	2950	831	604	604
query80	1581	390	343	343
query81	511	200	174	174
query82	634	124	95	95
query83	314	258	235	235
query84	328	124	101	101
query85	905	483	366	366
query86	492	168	175	168
query87	1016	987	903	903
query88	3021	2138	2084	2084
query89	320	219	207	207
query90	2059	143	135	135
query91	154	147	126	126
query92	54	48	44	44
query93	2304	1105	716	716
query94	628	245	222	222
query95	616	432	348	348
query96	787	546	269	269
query97	1094	1055	1022	1022
query98	191	138	132	132
query99	411	338	307	307
Total cold run time: 181084 ms
Total hot run time: 83086 ms

hello-stephen · 2026-08-21T14:12:14Z

ClickBench: Total hot run time: 14.87 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9181de7c55043e0e65665fd18dc721c198c682f6, data reload: false
query1	0.00	0.00	0.00
query2	0.07	0.03	0.04
query3	0.25	0.11	0.11
query4	1.60	0.09	0.10
query5	0.18	0.16	0.17
query6	1.25	0.68	0.72
query7	0.03	0.01	0.00
query8	0.05	0.03	0.03
query9	0.28	0.21	0.22
query10	0.36	0.35	0.37
query11	0.17	0.11	0.11
query12	0.15	0.12	0.12
query13	0.31	0.31	0.31
query14	0.46	0.44	0.46
query15	0.36	0.35	0.36
query16	0.22	0.20	0.21
query17	0.69	0.71	0.73
query18	0.18	0.17	0.17
query19	1.20	1.20	1.21
query20	0.02	0.01	0.01
query21	15.42	0.15	0.12
query22	5.05	0.04	0.05
query23	16.18	0.27	0.10
query24	2.98	0.34	0.25
query25	0.11	0.04	0.04
query26	0.73	0.17	0.11
query27	0.04	0.02	0.03
query28	3.67	0.60	0.25
query29	12.44	3.21	2.55
query30	0.25	0.12	0.13
query31	2.76	0.38	0.18
query32	3.51	0.32	0.23
query33	1.37	1.52	1.58
query34	15.41	2.16	1.79
query35	1.74	1.76	1.76
query36	0.45	0.29	0.29
query37	0.06	0.04	0.04
query38	0.05	0.03	0.03
query39	0.03	0.02	0.03
query40	0.11	0.08	0.07
query41	0.07	0.02	0.02
query42	0.04	0.02	0.02
query43	0.03	0.03	0.02
Total cold run time: 90.33 s
Total hot run time: 14.87 s

hello-stephen · 2026-08-21T18:00:16Z

BE UT Coverage Report

Increment line coverage 100.00% (3/3) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	62.44% (29098/46599)
Line Coverage	47.47% (304631/641717)
Region Coverage	43.13% (245867/570089)
Branch Coverage	44.68% (114422/256094)

hello-stephen · 2026-08-21T18:04:00Z

BE Regression && UT Coverage Report

Increment line coverage 100.00% (3/3) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	75.84% (34226/45132)
Line Coverage	60.81% (385778/634372)
Region Coverage	57.00% (323695/567925)
Branch Coverage	57.79% (147575/255369)

TsukiokaKogane · 2026-08-24T09:21:10Z

run buildall

hello-stephen · 2026-08-24T11:38:01Z

TPC-H: Total hot run time: 16915 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3f58ef294ba79a33cf7d881e47a35d85a321c34f, data reload: false
------ Round 1 ----------------------------------
============================================
q1	17563	3119	3135	3119
q2	1887	237	145	145
q3	10480	848	511	511
q4	4678	242	202	202
q5	7691	568	396	396
q6	138	117	97	97
q7	540	497	395	395
q8	9244	896	923	896
q9	3467	2430	2432	2430
q10	6487	838	727	727
q11	391	201	176	176
q12	625	263	196	196
q13	18115	1554	1158	1158
q14	157	152	141	141
q15	q16	442	409	365	365
q17	696	798	760	760
q18	3188	2251	2253	2251
q19	1117	899	816	816
q20	370	286	194	194
q21	5275	1703	1856	1703
q22	327	265	237	237
Total cold run time: 92878 ms
Total hot run time: 16915 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1	3482	3416	3423	3416
q2	207	213	157	157
q3	2237	2294	2238	2238
q4	1196	1162	895	895
q5	2175	2124	2137	2124
q6	175	126	86	86
q7	1038	974	877	877
q8	1628	1438	1421	1421
q9	3144	3122	3124	3122
q10	1865	1791	1647	1647
q11	355	277	253	253
q12	460	432	334	334
q13	1485	1558	1164	1164
q14	175	177	153	153
q15	q16	390	391	366	366
q17	1053	1041	1028	1028
q18	4991	4408	4790	4408
q19	856	882	864	864
q20	978	943	807	807
q21	3540	3287	3281	3281
q22	391	338	335	335
Total cold run time: 31821 ms
Total hot run time: 28976 ms

hello-stephen · 2026-08-24T11:44:27Z

TPC-DS: Total hot run time: 82219 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3f58ef294ba79a33cf7d881e47a35d85a321c34f, data reload: false
query5	4283	440	342	342
query6	396	135	132	132
query7	4894	436	232	232
query8	292	126	121	121
query9	8674	2870	2858	2858
query10	416	232	186	186
query11	5386	1055	945	945
query12	114	74	70	70
query13	1206	441	320	320
query14	6023	2209	2064	2064
query14_1	1969	1973	1989	1973
query15	180	122	113	113
query16	932	370	361	361
query17	796	466	370	370
query18	2336	341	241	241
query19	186	131	99	99
query20	68	65	72	65
query21	201	101	87	87
query22	5550	5569	5491	5491
query23	6912	6439	6353	6353
query23_1	6098	6007	6040	6007
query24	7226	1093	771	771
query24_1	756	751	803	751
query25	404	298	237	237
query26	1231	224	128	128
query27	2794	403	256	256
query28	4687	1489	1486	1486
query29	926	439	324	324
query30	253	151	129	129
query31	809	401	329	329
query32	97	47	46	46
query33	461	210	178	178
query34	968	816	497	497
query35	397	414	335	335
query36	580	579	494	494
query37	120	79	67	67
query38	997	838	800	800
query39	484	478	469	469
query39_1	460	467	455	455
query40	201	87	78	78
query41	53	51	50	50
query42	74	73	75	73
query43	239	240	209	209
query44	1008	558	535	535
query45	110	100	95	95
query46	765	891	530	530
query47	762	749	714	714
query48	288	303	233	233
query49	545	232	177	177
query50	723	266	191	191
query51	7989	7946	7970	7946
query52	66	66	59	59
query53	199	196	144	144
query54	225	193	183	183
query55	69	62	77	62
query56	235	156	159	156
query57	688	655	635	635
query58	221	158	152	152
query59	1222	1231	1109	1109
query60	233	176	165	165
query61	123	115	118	115
query62	347	211	173	173
query63	172	151	143	143
query64	2777	672	570	570
query65	1611	1585	1657	1585
query66	1840	263	207	207
query67	9798	9728	9815	9728
query68	2743	1211	764	764
query69	343	219	195	195
query70	662	598	616	598
query71	244	177	162	162
query72	2348	1695	1534	1534
query73	672	604	321	321
query74	1580	1237	1142	1142
query75	1169	1084	977	977
query76	2278	734	534	534
query77	247	263	207	207
query78	4004	3632	3210	3210
query79	1182	804	583	583
query80	1300	335	267	267
query81	464	155	132	132
query82	601	122	95	95
query83	285	208	191	191
query84	294	110	88	88
query85	1047	366	365	365
query86	367	177	186	177
query87	1017	978	898	898
query88	2736	2106	2080	2080
query89	293	192	178	178
query90	1780	136	135	135
query91	145	136	114	114
query92	49	47	48	47
query93	1172	1111	662	662
query94	588	270	224	224
query95	544	265	236	236
query96	787	599	257	257
query97	1086	1026	1004	1004
query98	143	140	136	136
query99	426	350	311	311
Total cold run time: 175113 ms
Total hot run time: 82219 ms

hello-stephen · 2026-08-24T11:48:49Z

ClickBench: Total hot run time: 14.59 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3f58ef294ba79a33cf7d881e47a35d85a321c34f, data reload: false
query1	0.01	0.00	0.01
query2	0.08	0.04	0.04
query3	0.24	0.10	0.11
query4	1.60	0.10	0.11
query5	0.17	0.16	0.15
query6	1.25	0.67	0.69
query7	0.03	0.01	0.01
query8	0.04	0.03	0.03
query9	0.28	0.21	0.22
query10	0.35	0.34	0.35
query11	0.15	0.12	0.11
query12	0.15	0.12	0.12
query13	0.30	0.31	0.30
query14	0.46	0.45	0.47
query15	0.36	0.37	0.35
query16	0.22	0.22	0.21
query17	0.72	0.68	0.65
query18	0.18	0.17	0.18
query19	1.18	1.16	1.13
query20	0.02	0.01	0.01
query21	15.44	0.17	0.12
query22	5.06	0.04	0.04
query23	16.18	0.26	0.10
query24	2.95	0.30	0.27
query25	0.11	0.03	0.04
query26	0.83	0.16	0.11
query27	0.04	0.03	0.02
query28	3.66	0.55	0.28
query29	12.46	3.20	2.57
query30	0.24	0.11	0.12
query31	2.75	0.35	0.17
query32	3.55	0.32	0.23
query33	1.46	1.43	1.42
query34	15.34	2.14	1.74
query35	1.76	1.73	1.72
query36	0.46	0.31	0.27
query37	0.06	0.04	0.04
query38	0.05	0.03	0.03
query39	0.03	0.02	0.02
query40	0.12	0.08	0.08
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 90.48 s
Total hot run time: 14.59 s

hello-stephen · 2026-08-24T13:24:13Z

BE Regression && UT Coverage Report

Increment line coverage 100.00% (3/3) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	75.97% (34351/45218)
Line Coverage	60.91% (386864/635121)
Region Coverage	57.04% (324423/568756)
Branch Coverage	57.87% (148022/255770)

HappenLee

LGTM

a

TsukiokaKogane requested review from gavinchou and yiguolei as code owners July 31, 2026 10:57

TsukiokaKogane changed the title ~~[fix](table stream) Forbid child iterator by-ref mode on the non-merg…~~[fix](table stream) Forbid child iterator by-ref mode on the non-merge union pathJul 31, 2026

TsukiokaKogane marked this pull request as draft July 31, 2026 11:15

TsukiokaKogane marked this pull request as ready for review August 4, 2026 08:16

github-actionsBot requested changes Aug 4, 2026
View reviewed changes

Comment threadbe/src/storage/iterator/vcollect_iterator.cpp Outdated
Comment threadbe/src/storage/tablet/tablet_reader.cpp Outdated

TsukiokaKogane changed the title ~~[fix](table stream) Forbid child iterator by-ref mode on the non-merge union path~~[fix](table stream) force VCollectIterator merge in case of binlog scan Aug 5, 2026

HappenLee reviewed Aug 6, 2026
View reviewed changes

Comment threadbe/src/storage/rowset/beta_rowset_reader.h

TsukiokaKogane force-pushed the fix_append_only_multi_seg_core branch from 820270f to 4c7c828Compare August 11, 2026 12:42

TsukiokaKogane changed the title ~~[fix](table stream) force VCollectIterator merge in case of binlog scan~~ [fix](table stream) Fix multi-segment row-binlog reads for MoW tablesAug 11, 2026

TsukiokaKogane force-pushed the fix_append_only_multi_seg_core branch from 4c7c828 to 4966a71Compare August 11, 2026 13:29

github-actionsBot previously requested changes Aug 21, 2026
View reviewed changes

Comment threadbe/src/storage/merger.cpp
Comment threadbe/src/storage/rowset/beta_rowset_writer.cpp

TsukiokaKogane force-pushed the fix_append_only_multi_seg_core branch from 76041b1 to 5ee9a43Compare August 21, 2026 10:13

csun5285 previously approved these changes Aug 24, 2026
View reviewed changes

TsukiokaKogane added 2 commits August 24, 2026 09:18

fix mow multi segment
2267b48

fix tso force read
3f58ef2

TsukiokaKogane dismissed csun5285’s stale review via 3f58ef2August 24, 2026 09:20

TsukiokaKogane force-pushed the fix_append_only_multi_seg_core branch from 9181de7 to 3f58ef2Compare August 24, 2026 09:20

csun5285 approved these changes Aug 25, 2026
View reviewed changes

HappenLee approved these changes Aug 25, 2026
View reviewed changes

gavinchou approved these changes Aug 25, 2026
View reviewed changes

gavinchou merged commit 369f887 into apache:masterAug 25, 2026
32 of 33 checks passed

gavinchou added the binlog label Aug 25, 2026

MoanasDaddyXu mentioned this pull request Aug 25, 2026
[Tracking][Binlog] Binlog feature umbrella — all sub-issues tracked here #65265
Open
40 tasks

morningman mentioned this pull request Sep 1, 2026
[Feature] Track incremental computation with row binlog, Table Stream, and MTMV #65418
Open
69 tasks

Uh oh!

Conversation

TsukiokaKogane commented Jul 31, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

hello-stephen commented Jul 31, 2026

Uh oh!

TsukiokaKogane commented Jul 31, 2026

Uh oh!

hello-stephen commented Jul 31, 2026

Uh oh!

hello-stephen commented Jul 31, 2026

Uh oh!

hello-stephen commented Jul 31, 2026

Uh oh!

hello-stephen commented Jul 31, 2026

BE Regression && UT Coverage Report

Uh oh!

TsukiokaKogane commented Aug 4, 2026

Uh oh!

HappenLee commented Aug 4, 2026

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

hello-stephen commented Aug 4, 2026

Uh oh!

hello-stephen commented Aug 4, 2026

Uh oh!

hello-stephen commented Aug 4, 2026

Uh oh!

TsukiokaKogane commented Aug 5, 2026

Uh oh!

TsukiokaKogane commented Aug 5, 2026

Uh oh!

Uh oh!

TsukiokaKogane commented Aug 11, 2026

Uh oh!

TsukiokaKogane commented Aug 11, 2026

Uh oh!

TsukiokaKogane commented Aug 13, 2026

Uh oh!

hello-stephen commented Aug 13, 2026

Uh oh!

hello-stephen commented Aug 13, 2026

Uh oh!

hello-stephen commented Aug 13, 2026

Uh oh!

hello-stephen commented Aug 20, 2026

BE UT Coverage Report

Uh oh!

csun5285 commented Aug 21, 2026

Uh oh!

github-actionsBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

TsukiokaKogane commented Aug 21, 2026

Uh oh!

hello-stephen commented Aug 21, 2026

BE Regression && UT Coverage Report

Uh oh!

TsukiokaKogane commented Aug 21, 2026

Uh oh!

hello-stephen commented Aug 21, 2026

Uh oh!

hello-stephen commented Aug 21, 2026

Uh oh!

hello-stephen commented Aug 21, 2026

Uh oh!

hello-stephen commented Aug 21, 2026

BE UT Coverage Report

Uh oh!

TsukiokaKogane commented Jul 31, 2026•
edited
Loading