Skip to content

branch-4.1: [fix](cloud) Prevent old clients from decoding unknown MetaServiceCode as OK (#64148) - #66353

Merged
yiguolei merged 1 commit into
apache:branch-4.1from
wyxxxcat:pick_64148_4_1
Aug 3, 2026
Merged

branch-4.1: [fix](cloud) Prevent old clients from decoding unknown MetaServiceCode as OK (#64148)#66353
yiguolei merged 1 commit into
apache:branch-4.1from
wyxxxcat:pick_64148_4_1

Conversation

@wyxxxcat

@wyxxxcatwyxxxcat commented Aug 1, 2026

Copy link
Copy Markdown
Collaborator

pick: #64148
Problem Summary: Older BE versions may treat unknown meta service enum codes as OK under proto2 semantics. Add a request capability marker so MS only returns MS_TOO_BUSY to BE versions that can handle it, and downgrade otherwise.

@wyxxxcat
wyxxxcat requested a review from yiguolei as a code ownerAugust 1, 2026 14:50
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wyxxxcatwyxxxcat changed the title pick: [fix](cloud) Prevent old clients from decoding unknown MetaServiceCode as OK (#64148)branch-4.1: [fix](cloud) Prevent old clients from decoding unknown MetaServiceCode as OK (#64148)Aug 1, 2026
@wyxxxcat

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

…e as OK (apache#64148)
Problem Summary: Older BE versions may treat unknown meta service enum
codes as OK under proto2 semantics. Add a request capability marker so
MS only returns MS_TOO_BUSY to BE versions that can handle it, and
downgrade otherwise.
- Behavior changed: Yes (MS_TOO_BUSY is returned only when the BE
request declares support; legacy requests receive KV_TXN_CONFLICT
instead)
@wyxxxcat

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 62.96% (17/27) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage77.62% (1904/2453)
Line Coverage64.46% (34013/52769)
Region Coverage64.49% (17214/26693)
Branch Coverage53.97% (9210/17064)

@hello-stephen

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 40.00% (12/30) 🎉
Increment coverage report
Complete coverage report

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 35.29% (6/17) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage58.01% (24293/41879)
Line Coverage42.10% (242360/575665)
Region Coverage38.18% (191394/501274)
Branch Coverage39.47% (87043/220529)

@hello-stephen

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (17/17) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage73.40% (30024/40906)
Line Coverage57.32% (328187/572542)
Region Coverage54.16% (273090/504189)
Branch Coverage55.16% (121709/220660)

@hello-stephen

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 56.67% (17/30) 🎉
Increment coverage report
Complete coverage report

@yiguolei
yiguolei merged commit af7b993 into apache:branch-4.1Aug 3, 2026
29 of 32 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@wyxxxcat@hello-stephen@yiguolei