Uh oh!
There was an error while loading. Please reload this page.
[fix](cloud) Fail closed on unknown MetaService response codes - #66364
Conversation
hello-stephen
commented
Aug 2, 2026
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
9de76ba to
d0aa93cCompared0aa93c to
aeed3c8Comparewyxxxcat
commented
Aug 3, 2026
run buildall |
Uh oh!
There was an error while loading. Please reload this page.
hello-stephen
commented
Aug 3, 2026
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
Aug 3, 2026
FE UT Coverage ReportIncrement line coverage |
aeed3c8 to
7037019Comparewyxxxcat
commented
Aug 3, 2026
run buildall |
f5606b1 to
64dad43Comparewyxxxcat
commented
Aug 3, 2026
run buildall |
hello-stephen
commented
Aug 3, 2026
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
Aug 3, 2026
FE UT Coverage ReportIncrement line coverage |
hello-stephen
commented
Aug 3, 2026
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
Aug 3, 2026
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
Aug 3, 2026
FE Regression Coverage ReportIncrement line coverage |
hello-stephen
commented
Aug 3, 2026
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
Aug 3, 2026
FE Regression Coverage ReportIncrement line coverage |
64dad43 to
d5c450eComparewyxxxcat
commented
Aug 5, 2026
run buildall |
hello-stephen
commented
Aug 5, 2026
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
PR approved by at least one committer and no changes requested. |
hello-stephen
commented
Aug 12, 2026
FE Regression Coverage ReportIncrement line coverage |
hello-stephen
commented
Aug 12, 2026
FE UT Coverage ReportIncrement line coverage |
040d2ac to
4a9b077Comparewyxxxcat
commented
Aug 12, 2026
run buildall |
hello-stephen
commented
Aug 12, 2026
FE Regression Coverage ReportIncrement line coverage |
hello-stephen
commented
Aug 12, 2026
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
Aug 12, 2026
TPC-H: Total hot run time: 28932 ms |
hello-stephen
commented
Aug 12, 2026
TPC-DS: Total hot run time: 158004 ms |
hello-stephen
commented
Aug 12, 2026
ClickBench: Total hot run time: 25.27 s |
wyxxxcat
commented
Aug 13, 2026
run buildall |
hello-stephen
commented
Aug 13, 2026
TPC-H: Total hot run time: 29017 ms |
hello-stephen
commented
Aug 13, 2026
TPC-DS: Total hot run time: 159028 ms |
hello-stephen
commented
Aug 13, 2026
ClickBench: Total hot run time: 23.93 s |
hello-stephen
commented
Aug 13, 2026
FE Regression Coverage ReportIncrement line coverage |
Uh oh!
There was an error while loading. Please reload this page.
Related PR: #64148 Problem Summary: Meta Service responses contain both an exact actual_code and a legacy-compatible code. When a client recognizes the actual_code, it should use that exact value. When actual_code is unknown, the legacy code is safe only if it is explicitly present and non-OK. The previous logic could fall back to an unset or OK code and incorrectly treat an unknown Meta Service error as success. This change makes BE and FE fail closed with UNDEFINED_ERR in that case, while preserving compatible non-OK fallbacks. It also adds a message explaining the MS_TOO_BUSY to KV_TXN_CONFLICT conversion for legacy clients.
…e#66364) Related PR: apache#64148 Problem Summary: Meta Service responses contain both an exact actual_code and a legacy-compatible code. When a client recognizes the actual_code, it should use that exact value. When actual_code is unknown, the legacy code is safe only if it is explicitly present and non-OK. The previous logic could fall back to an unset or OK code and incorrectly treat an unknown Meta Service error as success. This change makes BE and FE fail closed with UNDEFINED_ERR in that case, while preserving compatible non-OK fallbacks. It also adds a message explaining the MS_TOO_BUSY to KV_TXN_CONFLICT conversion for legacy clients.
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #64148
Problem Summary:
Meta Service responses contain both an exact actual_code and a legacy-compatible code. When a client recognizes the actual_code, it should use that exact value. When actual_code is unknown, the legacy code is safe only if it is explicitly present and non-OK. The previous logic could fall back to an unset or OK code and incorrectly treat an unknown Meta Service error as success.
This change makes BE and FE fail closed with UNDEFINED_ERR in that case, while preserving compatible non-OK fallbacks. It also adds a message explaining the MS_TOO_BUSY to KV_TXN_CONFLICT conversion for legacy clients.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)