Skip to content

branch-4.1: [fix](compaction) Fix sparse vertical compaction destination offset #66306 - #66429

Merged
yiguolei merged 1 commit into
branch-4.1from
auto-pick-66306-branch-4.1
Aug 4, 2026
Merged

branch-4.1: [fix](compaction) Fix sparse vertical compaction destination offset #66306#66429
yiguolei merged 1 commit into
branch-4.1from
auto-pick-66306-branch-4.1

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Cherry-picked from #66306

@Yukang-LianYour Name
[fix](compaction) Fix sparse vertical compaction destination offset (#…
59fd9e9
…66306)
## What changed
- Save the original target-column row count before sparse-column
preparation.
- Use the saved row count as the destination offset.
- Add regression coverage for a reserve-only leading `BOOLEAN` column
followed by a nullable fixed-width `BIGINT` column in the same value
group.
## Why
The leading value column may reserve capacity without increasing its
size. Deriving the destination offset from its post-prepare size can
therefore select the wrong position.
@hello-stephen

hello-stephen commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen

hello-stephen commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

run buildall

@hello-stephen

hello-stephen commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (2/2) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage73.55% (30286/41178)
Line Coverage57.46% (332199/578103)
Region Coverage54.43% (276913/508714)
Branch Coverage55.29% (123619/223589)

@yiguolei
yiguolei merged commit 7f81c98 into branch-4.1Aug 4, 2026
29 of 32 checks passed
@morrySnow
morrySnow deleted the auto-pick-66306-branch-4.1 branch August 20, 2026 03:59
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguoleiyiguoleiyiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hello-stephen@yiguolei@Yukang-Lian