Uh oh!
There was an error while loading. Please reload this page.
branch-4.1: [improvement](be) Add instance ID to hash join profiles #66097 - #66453
Merged
Conversation
### What problem does this PR solve? Issue Number: None Related PR: #65761 Problem Summary: This forward-ports #65761 from `opt_perf_4.1` to `master`. Shuffle hash join build and probe operators run in separate pipelines, so their per-instance profiles are difficult to correlate. Add the fragment instance ID to both hash join build and probe custom profiles. Profiles with the same join node ID and `InstanceID` now identify the corresponding build/probe pair without relying on process-local hash table addresses. ### Release note None ### Check List (For Author) - Test - [ ] Regression test - [ ] Unit Test - [ ] Manual test - [x] No need to test or manual test. The change only adds profile metadata. - `build-support/clang-format.sh` (passed) - `build-support/check-format.sh` (passed) - `git diff --check origin/master...HEAD` (passed) - `BUILD_TYPE=ASAN ./build.sh --be` (attempted; CMake configured successfully, but Ninja was blocked before compilation because this worktree lacks `thirdparty/installed/lib64/liblance_c.a`) - `thirdparty/build-thirdparty.sh lance_c` (attempted; blocked because the required Rust/Cargo 1.91 toolchain is unavailable) - `build-support/run-clang-tidy.sh --base origin/master --build-dir be/build_ASAN` (attempted; blocked by the existing `core/types.h` unmatched `NOLINTEND` and missing system `stddef.h`; no diagnostic identified on the added lines) - [ ] This is a refactor/code format and no logic has been changed. - Behavior changed: - [ ] No. - [x] Yes. Hash join build and probe profiles include `InstanceID`. - Does this need documentation? - [x] No. - [ ] Yes. Co-authored-by: HappenLee <happenlee@selectdb.com>
hello-stephen
commented
Aug 5, 2026
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
hello-stephen
commented
Aug 5, 2026
Contributor
run buildall |
hello-stephen
commented
Aug 5, 2026
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
approved these changes
Aug 6, 2026
ContributorAuthor
PR approved by at least one committer and no changes requested. |
ContributorAuthor
PR approved by anyone and no changes requested. |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #66097