Uh oh!
There was an error while loading. Please reload this page.
branch-4.1: [improvement](be) Optimize Variant V2 ingestion and STRING casts - #66744
Merged
Conversation
hello-stephen
commented
Aug 13, 2026
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
eldenmoon
commented
Aug 13, 2026
MemberAuthor
run buildall |
hello-stephen
commented
Aug 13, 2026
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
eldenmoon
marked this pull request as ready for review
August 17, 2026 01:28
yiguolei
approved these changes
Aug 18, 2026
Uh oh!
There was an error while loading. Please reload this page.
hubgeter added a commit
to hubgeter/doris
that referenced
this pull request
Aug 18, 2026
Resolved four conflicts, all against apache#66744 "Optimize Variant V2 ingestion and STRING casts" and its VariantRef::ObjectView work: - variant_value.{h,cpp}: kept both additions. _container_offset() and the index_out output of _object_find_by_id() belong to the direct-seek container lookup on this branch; object_view() and the optional dictionary_size of _object_field_id() come from upstream. They do not overlap, and passing no dictionary_size keeps the previous metadata.dict_size() behaviour. - cast_variant_to_string.cpp: upstream's payload-reuse short circuit supersedes the one added here, because it also merges forced nulls without rebuilding the column. Kept it, and kept this branch's handling of the remaining case, where a string typed column does contain Variant nulls and the surviving rows can still be read straight from the typed payload. - cast_variant_v2_from_test.cpp: kept upstream's typed_strings() fixture and its two tests, which cover payload reuse and the forced/inner null matrix more precisely. Kept only the added test that cross-checks the typed and encoded casts byte for byte, which is the invariant typed direct-seek results rely on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cherry-pick #66709