Skip to content

branch-4.1: [fix](cloud) recycler decrement_delete_bitmap_packed_file_ref_counts method should read delete bitmaps as blobs #66728 - #66892

Merged
yiguolei merged 1 commit into
branch-4.1from
auto-pick-66728-branch-4.1
Aug 20, 2026
Merged

branch-4.1: [fix](cloud) recycler decrement_delete_bitmap_packed_file_ref_counts method should read delete bitmaps as blobs #66728#66892
yiguolei merged 1 commit into
branch-4.1from
auto-pick-66728-branch-4.1

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Cherry-picked from #66728

…method should read delete bitmaps as blobs (#66728)
v2 delete bitmaps are written with `blob_put`, which appends a suffix to every physical key.
The recycler read the unsuffixed logical key with Transaction::get, treated existing delete bitmap metadata as missing, and skipped standalone-file deletion or packed-file reference-count updates.
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen

Copy link
Copy Markdown
Contributor

run buildall

@hello-stephen

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 100.00% (3/3) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage77.48% (1909/2464)
Line Coverage64.28% (34158/53141)
Region Coverage64.41% (17292/26845)
Branch Coverage53.97% (9264/17166)

@yiguolei
yiguolei merged commit 3e01e0f into branch-4.1Aug 20, 2026
29 of 32 checks passed
@morrySnow
morrySnow deleted the auto-pick-66728-branch-4.1 branch August 20, 2026 04:01
924060929 added a commit to 924060929/incubator-doris that referenced this pull request Sep 2, 2026
### What problem does this PR solve?
Issue Number: closeapache#66892
Related PR: apache#66913
Problem Summary: Iceberg schema and partition-column projection could release a no-context snapshot lease before resolving schema/spec metadata, allowing a concurrent catalog reset to splice two generations. HMS Iceberg cache loads also promoted a table without rechecking the captured generation after the remote load. Hudi batch cancellation marked queued tasks done but left their FutureTask objects in shared executor queues. Keep Iceberg projection inside one retained generation, fence HMS loads before promotion, and remove cancelled Hudi tasks from their exact executor queues.
### Release note
Fix Iceberg and Hudi metadata handle lifecycle races during catalog reset and query cancellation.
### Check List (For Author)
- Test: Unit Test
- HudiBatchFsViewOwnerTest
- IcebergUtilsTest
- IcebergExternalMetaCacheTest
- ./build.sh --fe -j4
- Behavior changed: No
- Does this need documentation: No
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@hello-stephen@yiguolei@mymeiyi