[opt](build) Decouple common/status.h from thrift/protobuf generated headers by morningman · Pull Request #67036 · apache/doris

morningman · 2026-08-21T14:15:40Z

What problem does this PR solve?

Issue Number: none

Related PR: #66901 (header-hygiene gate this PR extends), #66715 (BE build-speed umbrella, closed)

Problem Summary:

common/status.h is included by ~2450 of ~2500 BE TUs and carried
gen_cpp/Status_types.h (the whole thrift runtime) plus gen_cpp/types.pb.h
(the protobuf runtime) into every one of them. For any TU whose only path to
the generated headers was status.h, that is ~44k preprocessed lines of pure
tax per TU — paid in every build without a usable PCH: the Linux BE UT line
(be/test builds with no PCH), ENABLE_PCH=OFF (gcc) builds, clangd/clang-tidy,
and every incremental build after touching Status.thrift/types.proto.

This PR decouples status.h/exception.h (and util/hash_util.hpp) from the
generated headers, with zero runtime semantic change:

status.h: APPLY_FOR_THRIFT_ERROR_CODES now carries the literal enum
value per entry; status.cpp locks every value to the thrift enum with a
static_assert, so Status.thrift stays the single source of truth — any
drift is a compile error. Status::create<stacktrace>(TStatus/PStatus)
move out of line with 4 explicit instantiations (cold path: RPC error
conversion), code_as_string() moves out of line (cold path: error
printing), and both generated includes are dropped (TStatus joins
PStatus as a forward declaration).
exception.h: drops its unused Status_types.h include.
hash_util.hpp: the std::hash<TUniqueId/TNetworkAddress/pair>
specializations keep only their declarations here (this header stays the
earliest carrier, so they remain visible before any implicit
instantiation); the bodies move to uid_util.cpp/network_util.cpp where
the types are complete. The Types_types.h include is then dropped.
Mechanical fallout, all preparation-wave commits: endian.h gets its own
gbswap_16/32 builtins instead of leaning on the bswap_* macros that
protobuf's stubs/port.h happened to leak into most TUs;
IDataType::to_protobuf(PTypeDesc*) and the nine derived overrides move
out of line (data_type.h forward-declares the pb types); every TU that
named TStatusCode/TStatus/PStatus/PValues or std::set/
std::unordered_set via ride-along gets its direct include.

Numbers (clang -E, macOS arm; text include-graph reach over be/src+be/test):

metric	before	after
`common/status.h` closure	147,838 lines	103,883 (-29.7%)
`util/hash_util.hpp` closure	178,644 lines	131,801 (-26.2%)
`util/bitmap.cpp` natural closure (representative winner)	172,721	128,752 (-25%)
`gen_cpp/Status_types.h` reach	2453 TUs	37 TUs
`gen_cpp/types.pb.h` reach	2458 TUs	1791 TUs

Cold build wall-clock with clang + ENABLE_PCH=ON is neutral (687.3s ->
693.6s, +0.9%, paired back-to-back --compile-bench -j 6 runs, within
run-to-run noise) — expected, since pch.h itself still includes the generated
headers. The wins are the no-PCH worlds and the incremental radius: editing
Status.thrift no longer invalidates essentially every TU there.

Guards (extends #66901): check-header-deps.py now forbids
status.h/exception.h/hash_util.hpp from reaching gen_cpp/* (empty
whitelists), the exec_env gen_cpp whitelist empties out, thread_context loses
its Status_types.h entry, and REVERSE_REACH_BASELINES pins the three
generated headers at their new reach so the tax cannot silently regrow.
syntax_sweep.py gains --include-tests so the UT line's natural closures
are sweepable.

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
  - -fsyntax-only natural-closure sweeps (PCH stripped) at three
    scopes, all zero regressions vs pre-surgery baselines: Release
    unity scope (315 TUs), UT test scope with --include-tests
    (1167 be/test TUs), and a per-file sweep of all 1497 be/src
    sources (defeats unity masking);
  - full build.sh --be compile + doris_be link green;
    status_test.cpp / exception_test.cpp compiled to .o with the
    UT flag set;
  - guard self-test: re-injecting #include <gen_cpp/types.pb.h>
    into status.h makes check-header-deps.py fail as intended;
  - paired cold-build bench, see numbers above.
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

🤖 Generated with Claude Code

https://claude.ai/code/session_0167LexPzAjQuu5yHvaH9hmo

hello-stephen · 2026-08-21T14:15:45Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

morningman · 2026-08-21T14:15:49Z

run buildall

hello-stephen · 2026-08-21T16:20:35Z

TPC-H: Total hot run time: 17629 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit b741a2c8d4551ef457b889c55f199a2d554df19d, data reload: false
------ Round 1 ----------------------------------
============================================
q1	17566	3066	3024	3024
q2	1879	233	149	149
q3	10493	879	539	539
q4	4674	256	204	204
q5	7662	570	404	404
q6	141	116	100	100
q7	528	507	394	394
q8	9249	964	908	908
q9	3497	2435	2466	2435
q10	6541	872	736	736
q11	459	258	252	252
q12	690	401	331	331
q13	17869	1531	1161	1161
q14	161	152	143	143
q15	q16	449	411	373	373
q17	835	822	853	822
q18	3247	2341	2326	2326
q19	1591	870	804	804
q20	673	578	483	483
q21	5654	1810	1868	1810
q22	322	270	231	231
Total cold run time: 94180 ms
Total hot run time: 17629 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1	3420	3327	3338	3327
q2	206	222	155	155
q3	2279	2426	2225	2225
q4	1232	1232	916	916
q5	2243	2201	2178	2178
q6	181	125	87	87
q7	1042	1029	874	874
q8	1630	1425	1434	1425
q9	3237	3207	3233	3207
q10	1900	1848	1680	1680
q11	369	284	263	263
q12	471	439	342	342
q13	1501	1541	1204	1204
q14	172	176	165	165
q15	q16	400	404	369	369
q17	1043	1029	1024	1024
q18	5099	4542	4901	4542
q19	881	843	872	843
q20	998	975	869	869
q21	3885	3139	3349	3139
q22	401	340	335	335
Total cold run time: 32590 ms
Total hot run time: 29169 ms

hello-stephen · 2026-08-21T16:27:10Z

TPC-DS: Total hot run time: 84308 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit b741a2c8d4551ef457b889c55f199a2d554df19d, data reload: false
query5	4284	424	331	331
query6	413	165	152	152
query7	4869	424	267	267
query8	290	125	117	117
query9	8701	2893	2887	2887
query10	401	262	232	232
query11	5380	1054	931	931
query12	132	69	70	69
query13	1198	442	339	339
query14	6126	2258	2156	2156
query14_1	2076	2026	2034	2026
query15	172	121	112	112
query16	936	379	384	379
query17	849	459	367	367
query18	2338	341	251	251
query19	171	142	117	117
query20	75	71	75	71
query21	214	120	103	103
query22	5559	5491	5457	5457
query23	6923	6400	6134	6134
query23_1	6222	6217	6390	6217
query24	7263	1127	789	789
query24_1	775	810	806	806
query25	439	306	260	260
query26	1259	282	164	164
query27	2691	442	290	290
query28	4613	1506	1499	1499
query29	994	435	344	344
query30	278	183	152	152
query31	844	443	353	353
query32	102	49	46	46
query33	460	214	173	173
query34	986	828	484	484
query35	421	408	349	349
query36	564	577	536	536
query37	119	77	68	68
query38	1009	862	818	818
query39	493	471	465	465
query39_1	459	442	455	442
query40	212	123	111	111
query41	55	52	63	52
query42	92	82	79	79
query43	242	241	208	208
query44	1024	539	538	538
query45	109	106	103	103
query46	774	839	547	547
query47	770	766	720	720
query48	329	313	224	224
query49	528	243	190	190
query50	760	324	265	265
query51	8146	8161	7922	7922
query52	74	71	62	62
query53	202	210	159	159
query54	241	177	169	169
query55	76	60	54	54
query56	233	239	245	239
query57	696	671	683	671
query58	221	218	200	200
query59	1252	1248	1116	1116
query60	267	211	208	208
query61	130	124	111	111
query62	368	209	186	186
query63	188	169	167	167
query64	2730	697	580	580
query65	1631	1661	1683	1661
query66	1910	294	239	239
query67	10103	10057	9649	9649
query68	2749	1214	753	753
query69	353	219	192	192
query70	685	602	620	602
query71	276	251	245	245
query72	2304	1757	1538	1538
query73	634	590	324	324
query74	1560	1242	1179	1179
query75	1248	1157	1025	1025
query76	2281	745	536	536
query77	240	258	211	211
query78	3981	3599	3366	3366
query79	2557	847	606	606
query80	1570	425	358	358
query81	474	201	179	179
query82	608	131	94	94
query83	317	257	230	230
query84	299	119	101	101
query85	851	446	373	373
query86	384	176	166	166
query87	1036	971	924	924
query88	2793	2119	2130	2119
query89	303	225	212	212
query90	1848	141	135	135
query91	156	155	126	126
query92	52	49	42	42
query93	1516	1107	768	768
query94	622	239	222	222
query95	640	371	387	371
query96	844	589	266	266
query97	1105	1117	1086	1086
query98	164	139	150	139
query99	412	361	312	312
Total cold run time: 178784 ms
Total hot run time: 84308 ms

hello-stephen · 2026-08-21T16:31:32Z

ClickBench: Total hot run time: 14.75 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit b741a2c8d4551ef457b889c55f199a2d554df19d, data reload: false
query1	0.01	0.01	0.00
query2	0.10	0.04	0.03
query3	0.25	0.11	0.10
query4	1.60	0.10	0.10
query5	0.17	0.16	0.16
query6	1.24	0.73	0.69
query7	0.04	0.01	0.01
query8	0.05	0.03	0.03
query9	0.30	0.22	0.21
query10	0.35	0.35	0.35
query11	0.16	0.12	0.12
query12	0.15	0.14	0.11
query13	0.31	0.30	0.31
query14	0.46	0.47	0.46
query15	0.36	0.35	0.36
query16	0.22	0.23	0.22
query17	0.67	0.69	0.68
query18	0.17	0.16	0.18
query19	1.16	1.20	1.13
query20	0.01	0.01	0.01
query21	15.43	0.14	0.11
query22	5.09	0.04	0.05
query23	16.18	0.26	0.11
query24	3.03	0.32	0.24
query25	0.12	0.03	0.03
query26	0.75	0.16	0.12
query27	0.04	0.03	0.04
query28	3.60	0.54	0.28
query29	12.44	3.22	2.59
query30	0.26	0.11	0.12
query31	2.75	0.39	0.18
query32	3.49	0.33	0.24
query33	1.50	1.48	1.44
query34	15.37	2.18	1.77
query35	1.79	1.73	1.75
query36	0.49	0.30	0.27
query37	0.06	0.04	0.04
query38	0.05	0.03	0.03
query39	0.03	0.03	0.02
query40	0.12	0.08	0.08
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 90.5 s
Total hot run time: 14.75 s

hello-stephen · 2026-08-21T16:51:43Z

BE UT Coverage Report

Increment line coverage 91.04% (61/67) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	62.44% (29098/46601)
Line Coverage	47.46% (304563/641697)
Region Coverage	43.11% (245728/570047)
Branch Coverage	44.65% (114342/256064)

hello-stephen · 2026-08-21T19:15:55Z

BE Regression && UT Coverage Report

Increment line coverage 100.00% (67/67) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	75.94% (34273/45134)
Line Coverage	60.90% (386326/634352)
Region Coverage	56.99% (323637/567883)
Branch Coverage	57.86% (147748/255339)

eldenmoon

LGTM

airborne12

LGTM

…enerated headers Mechanical preparation wave, no include is removed yet (safe on master): - endian.h: define gbswap_16/32 with compiler builtins instead of leaning on the bswap_* macros that protobuf's stubs/port.h leaks into most TUs - hash_util.hpp: the std::hash specializations for TUniqueId/TNetworkAddress keep only declarations here (an incomplete type suffices); bodies move to uid_util.cpp / network_util.cpp where the thrift types are complete - IDataType::to_protobuf(PTypeDesc*) and the nine derived overrides move out of line; data_type.h forward-declares PTypeDesc/PTypeNode/PScalarType - add direct includes to every TU that named TStatusCode/TStatus/PStatus/ PValues or std::set/unordered_set but rode them in via common/status.h or hash_util.hpp Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0167LexPzAjQuu5yHvaH9hmo

…tobuf generated headers common/status.h is included by ~2450 of ~2500 BE TUs and carried gen_cpp/Status_types.h (thrift runtime) plus gen_cpp/types.pb.h (protobuf runtime) into every one of them: -44k preprocessed lines per TU wherever no other generated-header path exists. Surgery (zero runtime semantic change): - APPLY_FOR_THRIFT_ERROR_CODES gains the literal enum value per entry; status.cpp locks every value to the thrift enum with a static_assert, so Status.thrift stays the single source of truth (drift = compile error) - Status::create<stacktrace>(TStatus/PStatus) bodies move to status.cpp with 4 explicit instantiations (cold path: RPC error conversion) - code_as_string() moves to status.cpp (cold path: error printing) - both generated includes are dropped; TStatus joins PStatus as a forward declaration; exception.h drops its unused Status_types.h include Guards: check-header-deps.py forbids status.h/exception.h from reaching gen_cpp/* (empty whitelist), the exec_env whitelist empties out, the thread_context whitelist loses Status_types.h, and REVERSE_REACH_BASELINES locks Status_types.h at its new reach (37 TUs, down from 2453). syntax_sweep.py gains --include-tests: be/test builds without a PCH, so the UT line always compiles natural closures and must be sweepable. Probes (clang -E, macOS arm): status.h closure 147,838 -> 103,883 lines (-29.7%); util/bitmap.cpp -43,969; text-graph reach: Status_types.h 2453 -> 37 TUs, types.pb.h 2458 -> 1791. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0167LexPzAjQuu5yHvaH9hmo

hash_util.hpp rides into most of the backend through string_ref.h, column_string.h, vdatetime_value.h and storage/olap_common.h. After the std::hash specializations for TUniqueId/TNetworkAddress moved their bodies out of line (previous commit), the Types_types.h include carries nothing this header uses: dropping it removes the whole thrift runtime from every TU whose only path to it was hash_util (closure 178,644 -> 131,801 preprocessed lines, -26%). check-header-deps.py forbids hash_util.hpp from reaching gen_cpp/* so the edge cannot silently regrow. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0167LexPzAjQuu5yHvaH9hmo

morningman · 2026-09-01T11:47:09Z

run buildall

hello-stephen · 2026-09-01T19:36:15Z

TPC-H: Total hot run time: 16922 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3a70b027c276d96aa4239f5f549d40387f47ddc1, data reload: false
------ Round 1 ----------------------------------
============================================
q1	17583	3060	3055	3055
q2	2156	273	232	232
q3	10168	873	513	513
q4	4672	255	199	199
q5	7673	573	389	389
q6	137	112	92	92
q7	524	503	385	385
q8	9230	893	896	893
q9	3493	2384	2392	2384
q10	6492	840	713	713
q11	387	193	182	182
q12	622	258	194	194
q13	18124	1512	1153	1153
q14	160	151	143	143
q15	q16	427	395	368	368
q17	1399	871	820	820
q18	3114	2250	2221	2221
q19	1254	918	776	776
q20	371	283	199	199
q21	5627	1786	1908	1786
q22	322	262	225	225
Total cold run time: 93935 ms
Total hot run time: 16922 ms
----- Round 2, with runtime_filter_mode=off -----
============================================
q1	3444	3364	3389	3364
q2	520	403	366	366
q3	2271	2666	2174	2174
q4	1178	1146	877	877
q5	2168	2117	2121	2117
q6	175	116	87	87
q7	1085	930	836	836
q8	1599	1391	1402	1391
q9	3123	3122	3077	3077
q10	1839	1778	1632	1632
q11	362	265	249	249
q12	447	432	346	346
q13	1488	1513	1148	1148
q14	181	189	158	158
q15	q16	399	400	353	353
q17	3576	3342	3206	3206
q18	4801	4419	4705	4419
q19	842	970	881	881
q20	981	957	850	850
q21	3817	3212	3184	3184
q22	400	349	324	324
Total cold run time: 34696 ms
Total hot run time: 31039 ms

hello-stephen · 2026-09-01T19:42:45Z

TPC-DS: Total hot run time: 81648 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3a70b027c276d96aa4239f5f549d40387f47ddc1, data reload: false
query5	4252	403	344	344
query6	381	145	121	121
query7	4951	437	232	232
query8	290	123	123	123
query9	8684	2870	2866	2866
query10	389	212	184	184
query11	5354	1024	897	897
query12	118	71	70	70
query13	1202	447	349	349
query14	5990	2215	2075	2075
query14_1	1967	1951	1945	1945
query15	174	119	111	111
query16	906	372	351	351
query17	798	459	368	368
query18	2337	324	242	242
query19	166	141	109	109
query20	85	72	71	71
query21	201	102	85	85
query22	5289	5229	5341	5229
query23	6852	6096	6037	6037
query23_1	6056	6174	5948	5948
query24	7274	1127	802	802
query24_1	789	768	805	768
query25	434	298	266	266
query26	1234	240	132	132
query27	2774	411	265	265
query28	4662	1512	1496	1496
query29	931	436	366	366
query30	257	156	123	123
query31	811	401	332	332
query32	125	76	76	76
query33	459	232	177	177
query34	999	858	473	473
query35	403	395	353	353
query36	589	573	523	523
query37	119	82	70	70
query38	1004	839	811	811
query39	501	486	504	486
query39_1	456	466	435	435
query40	202	95	79	79
query41	59	56	56	56
query42	74	71	72	71
query43	240	247	214	214
query44	1007	543	556	543
query45	109	103	106	103
query46	828	823	507	507
query47	771	749	733	733
query48	313	317	230	230
query49	562	227	186	186
query50	752	264	184	184
query51	8011	8078	8075	8075
query52	68	66	60	60
query53	189	194	153	153
query54	241	158	175	158
query55	71	61	54	54
query56	233	174	165	165
query57	692	699	633	633
query58	199	153	163	153
query59	1246	1222	1076	1076
query60	239	196	174	174
query61	120	168	125	125
query62	358	205	170	170
query63	170	137	136	136
query64	2765	699	556	556
query65	1641	1608	1567	1567
query66	2025	263	198	198
query67	9945	9770	9583	9583
query68	2771	1157	776	776
query69	345	229	200	200
query70	658	622	610	610
query71	250	177	175	175
query72	2333	1729	1545	1545
query73	672	581	338	338
query74	1572	1210	1123	1123
query75	1172	1105	951	951
query76	2290	709	539	539
query77	247	257	208	208
query78	3975	3668	3187	3187
query79	2793	812	597	597
query80	1620	332	268	268
query81	518	156	129	129
query82	644	122	103	103
query83	291	215	192	192
query84	298	112	89	89
query85	845	363	287	287
query86	471	180	169	169
query87	1008	952	890	890
query88	3017	2114	2108	2108
query89	290	196	176	176
query90	2049	125	128	125
query91	134	119	101	101
query92	85	73	68	68
query93	2206	1189	725	725
query94	642	236	216	216
query95	528	329	227	227
query96	808	579	277	277
query97	1041	1065	986	986
query98	174	138	134	134
query99	424	341	313	313
Total cold run time: 178973 ms
Total hot run time: 81648 ms

hello-stephen · 2026-09-01T19:47:07Z

ClickBench: Total hot run time: 14.55 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3a70b027c276d96aa4239f5f549d40387f47ddc1, data reload: false
query1	0.01	0.00	0.01
query2	0.08	0.04	0.03
query3	0.24	0.10	0.10
query4	1.60	0.09	0.10
query5	0.18	0.16	0.16
query6	1.25	0.71	0.70
query7	0.03	0.01	0.00
query8	0.05	0.03	0.03
query9	0.28	0.21	0.22
query10	0.35	0.33	0.34
query11	0.16	0.12	0.12
query12	0.15	0.12	0.12
query13	0.32	0.31	0.30
query14	0.45	0.43	0.44
query15	0.36	0.36	0.34
query16	0.20	0.22	0.21
query17	0.68	0.67	0.68
query18	0.18	0.17	0.18
query19	1.22	1.09	1.21
query20	0.01	0.00	0.00
query21	15.45	0.15	0.13
query22	5.06	0.04	0.04
query23	16.20	0.26	0.10
query24	3.01	0.33	0.25
query25	0.10	0.04	0.05
query26	0.71	0.17	0.11
query27	0.04	0.04	0.03
query28	3.63	0.54	0.29
query29	12.47	3.13	2.55
query30	0.25	0.11	0.12
query31	2.76	0.36	0.16
query32	3.53	0.31	0.23
query33	1.34	1.62	1.48
query34	15.39	2.11	1.72
query35	1.70	1.76	1.69
query36	0.45	0.29	0.29
query37	0.06	0.04	0.04
query38	0.05	0.03	0.03
query39	0.03	0.03	0.03
query40	0.11	0.08	0.07
query41	0.07	0.02	0.03
query42	0.04	0.02	0.02
query43	0.03	0.02	0.02
Total cold run time: 90.28 s
Total hot run time: 14.55 s

hello-stephen · 2026-09-02T07:02:41Z

BE UT Coverage Report

Increment line coverage 91.04% (61/67) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	62.95% (29573/46980)
Line Coverage	47.99% (310075/646180)
Region Coverage	43.59% (250543/574707)
Branch Coverage	45.10% (116526/258378)

hello-stephen · 2026-09-02T07:06:45Z

BE Regression && UT Coverage Report

Increment line coverage 100.00% (67/67) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	76.07% (34615/45502)
Line Coverage	61.16% (390651/638739)
Region Coverage	57.39% (328431/572310)
Branch Coverage	58.11% (149708/257609)

github-actions · 2026-09-02T07:22:19Z

PR approved by anyone and no changes requested.

github-actions · 2026-09-02T07:22:21Z

PR approved by at least one committer and no changes requested.

Upstream apache#67036 decoupled common/status.h from thrift generated headers. Branch tests use TStatusCode via the old ride-along include; add the direct include.

morningman requested review from Gabriel39, airborne12, csun5285, eldenmoon, gavinchou, liaoxin01, luwei16 and yiguolei as code owners August 21, 2026 14:15

eldenmoon approved these changes Aug 24, 2026
View reviewed changes

airborne12 approved these changes Aug 24, 2026
View reviewed changes

Gabriel39 approved these changes Aug 24, 2026
View reviewed changes

morningmanand others added 3 commits September 1, 2026 18:26

morningman force-pushed the opt-status branch from b741a2c to 3a70b02Compare September 1, 2026 10:26

gavinchou approved these changes Sep 2, 2026
View reviewed changes

morningman merged commit 2a3a390 into apache:masterSep 2, 2026
31 of 32 checks passed

github-actionsBot added the reviewed label Sep 2, 2026

github-actionsBot added the approved Indicates a PR has been approved by one committer. label Sep 2, 2026

Uh oh!

Conversation

morningman commented Aug 21, 2026

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

hello-stephen commented Aug 21, 2026

Uh oh!

morningman commented Aug 21, 2026

Uh oh!

hello-stephen commented Aug 21, 2026

Uh oh!

hello-stephen commented Aug 21, 2026

Uh oh!

hello-stephen commented Aug 21, 2026

Uh oh!

hello-stephen commented Aug 21, 2026

BE UT Coverage Report

Uh oh!

hello-stephen commented Aug 21, 2026

BE Regression && UT Coverage Report

Uh oh!

eldenmoon left a comment

Choose a reason for hiding this comment

Uh oh!

airborne12 left a comment

Choose a reason for hiding this comment

Uh oh!

morningman commented Sep 1, 2026

Uh oh!

hello-stephen commented Sep 1, 2026

Uh oh!

hello-stephen commented Sep 1, 2026

Uh oh!

hello-stephen commented Sep 1, 2026

Uh oh!

hello-stephen commented Sep 2, 2026

BE UT Coverage Report

Uh oh!

hello-stephen commented Sep 2, 2026

BE Regression && UT Coverage Report

Uh oh!

Uh oh!

github-actionsBot commented Sep 2, 2026

Uh oh!

github-actionsBot commented Sep 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants