Skip to content

[fix](be) Skip CHAR payload checks for NULL rows#67043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiguolei merged 1 commit into from
Aug 24, 2026
Merged

[fix](be) Skip CHAR payload checks for NULL rows #67043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion be/src/storage/iterator/olap_data_convertor.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -549,7 +549,7 @@ Status OlapBlockDataConvertor::OlapColumnDataConvertorChar::convert_to_olap() {

// If column_string is not padded to full, we should do padding here.
if (should_padding(column_string, _length)) {
_column = clone_and_padding(column_string, _length);
_column = clone_and_padding(column_string, _length, _nullmap);

@github-actionsgithub-actionsBotAug 22, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Padding eligibility also needs to ignore NULL payloads. For CHAR(4), a live "a" (1 byte) plus a NULL row with a 7-byte nested payload has chars.size() == 2 * 4, so should_padding() returns false and this new call never executes. Debug then fails the live-row width DCHECK; release forwards a 1-byte Slice, and a 4-byte CHAR short key reaches CHECK(index_size <= slice->size). Please make the predicate inspect non-NULL rows using the same unshifted map, and add a production-converter test for this compensating-size case; existing tests never exercise the new null-map branch.

column_string = assert_cast<const ColumnString*>(_column.get());
}

Expand Down
7 changes: 6 additions & 1 deletion be/src/storage/iterator/olap_data_convertor.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -180,7 +180,8 @@ class OlapBlockDataConvertor {
return column->size() * padding_length != column->chars.size();
}

static ColumnPtr clone_and_padding(const ColumnString* input, size_t padding_length) {
static ColumnPtr clone_and_padding(const ColumnString* input, size_t padding_length,
const UInt8* null_map = nullptr) {
auto column = ColumnString::create();

column->offsets.resize(input->size());
Expand All@@ -192,6 +193,10 @@ class OlapBlockDataConvertor {

auto str = input->get_data_at(i);

if (null_map && null_map[i]) {
continue;
}

DCHECK(str.size <= padding_length)
<< "char type data length over limit, padding_length=" << padding_length
<< ", real=" << str.size;
Expand Down
Loading