Uh oh!
There was an error while loading. Please reload this page.
branch-4.1: [fix](be) Skip CHAR payload checks for NULL rows #67043 - #67054
Merged
Conversation
Nullable CHAR columns can carry a non-empty nested string payload for rows whose logical value is NULL. The CHAR storage converter previously validated that payload against the CHAR length even though the row was NULL, causing an unnecessary DCHECK during INSERT. This change passes the null map into CHAR padding and skips validation and copying for NULL rows while preserving the existing checks for non-NULL rows.
hello-stephen
commented
Aug 24, 2026
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
hello-stephen
commented
Aug 24, 2026
Contributor
run buildall |
hello-stephen
commented
Aug 24, 2026
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
approved these changes
Aug 24, 2026
ContributorAuthor
PR approved by anyone and no changes requested. |
ContributorAuthor
PR approved by at least one committer and no changes requested. |
hello-stephen
commented
Aug 24, 2026
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
2 similar comments
hello-stephen
commented
Aug 24, 2026
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
Aug 24, 2026
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #67043