Uh oh!
There was an error while loading. Please reload this page.
branch-4.1: [fix](be) Read instead of recursing when the ANN IVF list cache is absent #67024 - #67057
Merged
Merged
Conversation
…sent (#67024) ### What problem does this PR solve? Issue Number: None Related PR: #61160 Problem Summary: An IVF-on-disk search with no `AnnIndexIVFListCache` installed never returns — it recurses until the stack is exhausted. **Reproduction**: build an `IVF_ON_DISK` index, save it, load it, and search it without calling `AnnIndexIVFListCache::create_global_cache()` first. Under ASAN the process dies with `AddressSanitizer: stack-overflow`; on a large stack it simply spins. **Root cause**: `CachedRandomAccessReader::borrow()` falls back to `RandomAccessReader::borrow()` when `AnnIndexIVFListCache::instance()` is null. faiss documents that base implementation as *"allocates a buffer and calls read_at()"*, and `CachedRandomAccessReader::read_at()` is overridden to call `borrow()` — so the two call each other without bound: ``` CachedRandomAccessReader::borrow (no cache) -> faiss::RandomAccessReader::borrow (base: allocate + read_at) -> CachedRandomAccessReader::read_at (override: calls borrow) -> CachedRandomAccessReader::borrow -> ... ``` The branch reads like a fallback but cannot work at all. **Reachability, stated plainly**: `exec_env_init` installs the cache unconditionally at BE startup, so a running BE does not hit this today. What it does hit is unit tests. Every existing IVF-on-disk case in `faiss_vector_index_test.cpp` opens with `AnnIndexIVFListCache::create_global_cache(...)`, and a new test that does not know to do so gets a stack overflow rather than a diagnosable failure — which is how this was found, while writing an unrelated ANN container test. It also becomes live the moment the cache is made optional or its lifetime is shortened. **Fix**: the no-cache path reads the region itself under `_io_mutex` and returns an owning `ReadRef`. No cache means no cache accounting, so it uses a plain buffer rather than a `DataPage`; the buffer lives exactly as long as the ref the caller holds. ### Release note None
hello-stephen
commented
Aug 24, 2026
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
hello-stephen
commented
Aug 24, 2026
Contributor
run buildall |
yiguolei
commented
Aug 24, 2026
Contributor
skip buildall |
hello-stephen
commented
Aug 24, 2026
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
hello-stephen
commented
Aug 24, 2026
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
yiguolei
approved these changes
Aug 25, 2026
Uh oh!
There was an error while loading. Please reload this page.
ContributorAuthor
PR approved by anyone and no changes requested. |
ContributorAuthor
PR approved by at least one committer and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #67024