Skip to content

[fix](cloud) Skip versioned delete bitmap cleanup for non-MoW tablets - #67084

Merged
gavinchou merged 1 commit into
apache:masterfrom
wyxxxcat:delete_dbm_if_mow
Aug 28, 2026
Merged

[fix](cloud) Skip versioned delete bitmap cleanup for non-MoW tablets#67084
gavinchou merged 1 commit into
apache:masterfrom
wyxxxcat:delete_dbm_if_mow

Conversation

@wyxxxcat

@wyxxxcatwyxxxcat commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary: The recycler previously deleted versioned delete bitmap KVs for all recycled rowsets, although versioned delete bitmaps are only used by merge-on-write tablets. This change checks the tablet MoW state before cleanup and skips the versioned delete bitmap cleanup for non-MoW tablets.

The MoW state is cached by partition to avoid repeated tablet metadata reads. Rowsets without a partition ID fall back to tablet index lookup, and already recycled tablets are handled safely when their metadata is no longer present.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen

hello-stephen commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@wyxxxcat
wyxxxcatforce-pushed the delete_dbm_if_mow branch 3 times, most recently from 3369289 to 49bee5fCompareAugust 25, 2026 06:06
@wyxxxcat

wyxxxcat commented Aug 25, 2026

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

@hello-stephen

hello-stephen commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 81.25% (65/80) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage78.05% (2048/2624)
Line Coverage65.69% (37415/56958)
Region Coverage52.88% (34862/65931)
Branch Coverage56.26% (11194/19898)

@wyxxxcat

wyxxxcat commented Aug 25, 2026

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

@hello-stephen

hello-stephen commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 81.25% (65/80) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage78.05% (2048/2624)
Line Coverage65.69% (37418/56958)
Region Coverage52.82% (34824/65931)
Branch Coverage56.26% (11195/19898)

@wyxxxcat

wyxxxcat commented Aug 26, 2026

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

@wyxxxcat

wyxxxcat commented Aug 27, 2026

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

@hello-stephen

hello-stephen commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 75.90% (63/83) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage78.06% (2049/2625)
Line Coverage65.77% (37483/56989)
Region Coverage52.94% (34924/65970)
Branch Coverage56.37% (11222/19906)

@wyxxxcat

wyxxxcat commented Aug 27, 2026

Copy link
Copy Markdown
CollaboratorAuthor

run buildall

@hello-stephen

hello-stephen commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Cloud UT Coverage Report

Increment line coverage 75.00% (63/84) 🎉

Increment coverage report
Complete coverage report

CategoryCoverage
Function Coverage78.06% (2049/2625)
Line Coverage65.70% (37445/56991)
Region Coverage52.89% (34898/65988)
Branch Coverage56.37% (11221/19906)

gavinchou
gavinchou approved these changes Aug 28, 2026
View reviewed changes

@gavinchougavinchou left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The single-version recycler paths, row-binlog exception, legacy metadata fallback, asynchronous cleanup ordering, and targeted tests look correct. Non-blocking follow-up: multi-version recycling still removes versioned delete-bitmap ranges unconditionally in recycle_rowset_meta_and_data/cleanup_rowset_metadata, so the optimization does not yet cover that mode.

@gavinchou
gavinchou merged commit 678b2dd into apache:masterAug 28, 2026
28 of 29 checks passed
github-actionsBot pushed a commit that referenced this pull request Aug 28, 2026
@wyxxxcatYour Name
[fix](cloud) Skip versioned delete bitmap cleanup for non-MoW tablets (…
041e12b
…#67084)
Skip versioned delete bitmap cleanup for non-MoW tablets by caching the MoW state per partition. Preserve cleanup for row-binlog tablets and legacy rowset metadata, while keeping metadata lookup failures retryable.
Tests: required CI checks, including Cloud UT, compile, regression, and performance checks, passed.
The PR apache/doris/67084 is merged by gavinchou's agent at 2026-08-28T07:52:04Z
@github-actionsgithub-actionsBot mentioned this pull request Aug 28, 2026
Closed
@wyxxxcatwyxxxcat mentioned this pull request Aug 28, 2026
Merged
wyxxxcat added a commit to wyxxxcat/doris that referenced this pull request Aug 28, 2026
@wyxxxcat
[fix](cloud) Skip versioned delete bitmap cleanup for non-MoW tablets (…
05a1e5f
…apache#67084)
Skip versioned delete bitmap cleanup for non-MoW tablets by caching the MoW state per partition. Preserve cleanup for row-binlog tablets and legacy rowset metadata, while keeping metadata lookup failures retryable.
Tests: required CI checks, including Cloud UT, compile, regression, and performance checks, passed.
The PR apache/doris/67084 is merged by gavinchou's agent at 2026-08-28T07:52:04Z
wyxxxcat added a commit to wyxxxcat/doris that referenced this pull request Aug 28, 2026
@wyxxxcat
[fix](cloud) Skip versioned delete bitmap cleanup for non-MoW tablets (…
e9529a0
…apache#67084)
Skip versioned delete bitmap cleanup for non-MoW tablets by caching the MoW state per partition. Preserve cleanup for row-binlog tablets and legacy rowset metadata, while keeping metadata lookup failures retryable.
Tests: required CI checks, including Cloud UT, compile, regression, and performance checks, passed.
The PR apache/doris/67084 is merged by gavinchou's agent at 2026-08-28T07:52:04Z
wyxxxcat added a commit to wyxxxcat/doris that referenced this pull request Aug 28, 2026
@wyxxxcat
[fix](cloud) Skip versioned delete bitmap cleanup for non-MoW tablets (…
db802f4
…apache#67084)
Skip versioned delete bitmap cleanup for non-MoW tablets by caching the MoW state per partition. Preserve cleanup for row-binlog tablets and legacy rowset metadata, while keeping metadata lookup failures retryable.
Tests: required CI checks, including Cloud UT, compile, regression, and performance checks, passed.
The PR apache/doris/67084 is merged by gavinchou's agent at 2026-08-28T07:52:04Z
wyxxxcat added a commit to wyxxxcat/doris that referenced this pull request Aug 28, 2026
@wyxxxcat
[fix](cloud) Skip versioned delete bitmap cleanup for non-MoW tablets (…
1c289ac
…apache#67084)
Skip versioned delete bitmap cleanup for non-MoW tablets by caching the MoW state per partition. Preserve cleanup for row-binlog tablets and legacy rowset metadata, while keeping metadata lookup failures retryable.
Tests: required CI checks, including Cloud UT, compile, regression, and performance checks, passed.
The PR apache/doris/67084 is merged by gavinchou's agent at 2026-08-28T07:52:04Z
wyxxxcat added a commit to wyxxxcat/doris that referenced this pull request Aug 30, 2026
@wyxxxcat
[fix](cloud) Skip versioned delete bitmap cleanup for non-MoW tablets (…
2250472
…apache#67084)
Skip versioned delete bitmap cleanup for non-MoW tablets by caching the MoW state per partition. Preserve cleanup for row-binlog tablets and legacy rowset metadata, while keeping metadata lookup failures retryable.
Tests: required CI checks, including Cloud UT, compile, regression, and performance checks, passed.
The PR apache/doris/67084 is merged by gavinchou's agent at 2026-08-28T07:52:04Z
yiguolei pushed a commit that referenced this pull request Aug 31, 2026
@wyxxxcat
branch-4.1: [fix](cloud) Skip versioned delete bitmap cleanup for non…
81e3088
…-MoW tablets #67084 (#67287)
pick: #67084
@yiguoleiyiguolei mentioned this pull request Sep 1, 2026
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchougavinchougavinchou approved these changes
@liaoxin01liaoxin01Awaiting requested review from liaoxin01liaoxin01 is a code owner
@luwei16luwei16Awaiting requested review from luwei16luwei16 is a code owner

Assignees

@mymeiyimymeiyi

Labels

dev/4.1.4-merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wyxxxcat@hello-stephen@gavinchou@mymeiyi@yiguolei