Skip to content

branch-4.1: [fix](user variable) Preserve TIMESTAMPTZ user variable type #66833 - #67128

Merged
yiguolei merged 1 commit into
branch-4.1from
auto-pick-66833-branch-4.1
Aug 28, 2026
Merged

branch-4.1: [fix](user variable) Preserve TIMESTAMPTZ user variable type #66833#67128
yiguolei merged 1 commit into
branch-4.1from
auto-pick-66833-branch-4.1

Conversation

@github-actions

@github-actionsgithub-actionsBot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Cherry-picked from #66833

@MryangeYour Name
[fix](user variable) Preserve TIMESTAMPTZ user variable type (#66833)
a55c218
TIMESTAMPTZ user variables could lose their original type when converted
from a legacy literal to a Nereids literal. The value was restored as a
string, which changed timezone rendering and comparison semantics after
the session timezone changed.
Root cause: `ConnectContext.getLiteralForUserVar` did not handle
`DateLiteral` and fell back to string conversion. This change uses the
existing legacy literal conversion path to preserve the TIMESTAMPTZ
type, scale, and instant value.
@hello-stephen

hello-stephen commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hello-stephen

hello-stephen commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

run buildall

@hello-stephen

hello-stephen commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

FE Regression Coverage Report

Increment line coverage 100.00% (2/2) 🎉
Increment coverage report
Complete coverage report

@hello-stephen

hello-stephen commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

FE UT Coverage Report

Increment line coverage 50.00% (1/2) 🎉
Increment coverage report
Complete coverage report

@github-actions

github-actionsBot commented Aug 28, 2026

Copy link
Copy Markdown
ContributorAuthor

PR approved by anyone and no changes requested.

@yiguolei
yiguolei merged commit a4ea51f into branch-4.1Aug 28, 2026
30 of 32 checks passed
@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Aug 28, 2026
@github-actions

github-actionsBot commented Aug 28, 2026

Copy link
Copy Markdown
ContributorAuthor

PR approved by at least one committer and no changes requested.

@morrySnow
morrySnow deleted the auto-pick-66833-branch-4.1 branch August 31, 2026 07:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguoleiyiguoleiyiguolei approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hello-stephen@yiguolei@Mryange