Skip to content

branch-4.1:[fix](mtmv) Avoid invalid slot cast in MV null-reject compensation (#66613)#67266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yiguolei merged 1 commit into from
Aug 28, 2026
Merged

branch-4.1:[fix](mtmv) Avoid invalid slot cast in MV null-reject compensation (#66613) #67266

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...main/java/org/apache/doris/nereids/rules/exploration/mv/AbstractMaterializedViewRule.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -973,7 +973,9 @@ private Set<Set<Slot>> getShuttledRequireNoNullableViewSlots(Set<Set<Slot>> requ
for (Set<Slot> requireNullableSlots : requireNoNullableViewSlot) {
shuttledRequireNoNullableViewSlot.add(
ExpressionUtils.shuttleExpressionWithLineage(new ArrayList<>(requireNullableSlots),
viewStructInfo.getTopPlan()).stream().map(Slot.class::cast)
viewStructInfo.getTopPlan()).stream()
.filter(Slot.class::isInstance)
.map(Slot.class::cast)
.collect(Collectors.toSet()));
}
return shuttledRequireNoNullableViewSlot;
Expand Down
47 changes: 47 additions & 0 deletions .../src/test/java/org/apache/doris/nereids/rules/exploration/mv/NullRejectInferenceTest.java
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -184,6 +184,53 @@ void testNullRejectCompensationForInnerJoinFullJoinRewriteOnRightSide() {
.anyMatch(expression -> isNotNullOnSlot(expression, "o_orderdate")));
}

@Test
void testNullRejectCompensationWithCastJoinConditionFallsBack() {
connectContext.getSessionVariable().setDisableNereidsRules("INFER_PREDICATES,PRUNE_EMPTY_PARTITION");
CascadesContext queryContext = createCascadesContext(
"select lineitem.l_orderkey, orders.o_orderkey, orders.o_orderdate from lineitem "
+ "inner join orders on cast(lineitem.l_orderkey as bigint) "
+ "= cast(orders.o_orderkey as bigint)",
connectContext
);
Plan queryPlan = PlanChecker.from(queryContext)
.analyze()
.rewrite()
.applyExploration(RuleSet.BUSHY_TREE_JOIN_REORDER)
.getAllPlan().get(0).child(0);

CascadesContext viewContext = createCascadesContext(
"select lineitem.l_orderkey, orders.o_orderkey, orders.o_orderdate from lineitem "
+ "left outer join orders on cast(lineitem.l_orderkey as bigint) "
+ "= cast(orders.o_orderkey as bigint)",
connectContext
);
Plan viewPlan = PlanChecker.from(viewContext)
.analyze()
.rewrite()
.applyExploration(RuleSet.BUSHY_TREE_JOIN_REORDER)
.getAllPlan().get(0).child(0);

StructInfo queryStructInfo = StructInfo.of(queryPlan, queryPlan, queryContext);
StructInfo viewStructInfo = StructInfo.of(viewPlan, viewPlan, viewContext);
RelationMapping relationMapping = RelationMapping.generate(
queryStructInfo.getRelations(), viewStructInfo.getRelations(), 8).get(0);
SlotMapping queryToView = SlotMapping.generate(relationMapping);
SlotMapping viewToQuery = queryToView.inverse();
LogicalCompatibilityContext compatibilityContext = LogicalCompatibilityContext.from(
relationMapping, viewToQuery, queryStructInfo, viewStructInfo);
ComparisonResult comparisonResult = StructInfo.isGraphLogicalEquals(
queryStructInfo, viewStructInfo, compatibilityContext);

Assertions.assertFalse(comparisonResult.isInvalid());
Assertions.assertFalse(comparisonResult.getViewNoNullableSlot().isEmpty());

SplitPredicate compensatePredicates = Assertions.assertDoesNotThrow(
() -> TEST_RULE.predicatesCompensateForTest(
queryStructInfo, viewStructInfo, viewToQuery, comparisonResult, queryContext));
Assertions.assertTrue(compensatePredicates.isInvalid());
}

private static boolean isNotNullOnSlot(Expression expression, String slotName) {
if (!(expression instanceof Not) || ((Not) expression).isGeneratedIsNotNull()
|| !(((Not) expression).child() instanceof IsNull)) {
Expand Down
Loading