branch-4.1: [fix](exec) Retain sliding window rows during eviction #67274 by github-actions[bot] · Pull Request #67329 · apache/doris

github-actions · 2026-08-31T06:22:42Z

Cherry-picked from #67274

Problem Summary: Streaming `ROWS` window aggregates retain state across frame evaluations. The eviction path previously considered only whether buffered blocks had been emitted, so it could erase either the outgoing row needed by a bounded sliding frame or the next unread row needed by an `UNBOUNDED PRECEDING ... N PRECEDING` frame. After rebasing, negative partition and outgoing positions could allow a nullable aggregate to access its null map out of bounds. Evicting either kind of required row could also produce incorrect aggregate results. Root cause: `_remove_unused_rows()` did not account for the earliest row required by the next ROWS frame evaluation, and `BoundaryPose::remove_unused_rows()` allowed retained-column coordinates to become negative. This change defers block-aligned eviction when the candidate prefix contains either `frame_start - 1`, the outgoing row required by a bounded sliding update, or the next unread row required by an `UNBOUNDED PRECEDING ... N PRECEDING` frame. It also rebases partition and order boundaries to nonnegative physical-column coordinates. The BE unit coverage exercises both ROWS executors across eviction boundaries and verifies boundary rebasing. Observed ASAN failure before this change (`output/be/log/be.out`): ```text ERROR: AddressSanitizer: heap-buffer-overflow READ of size 1 #0 doris::AggregateFunctionNullUnaryInlineV2<...>::execute_function_with_incremental(...) be/src/exprs/aggregate/aggregate_function_null_v2.h:595 #1 doris::AggFnEvaluator::execute_function_with_incremental(...) be/src/exprs/vectorized_agg_fn.cpp:334 #2 doris::AnalyticSinkLocalState::_execute_for_function<true>(...) be/src/exec/operator/analytic_sink_operator.cpp:385 #3 doris::AnalyticSinkLocalState::_get_next_for_sliding_rows(...) be/src/exec/operator/analytic_sink_operator.cpp:203 #4 doris::AnalyticSinkLocalState::_execute_impl(...) be/src/exec/operator/analytic_sink_operator.cpp:358 #5 doris::AnalyticSinkOperatorX::sink_impl(...) be/src/exec/operator/analytic_sink_operator.cpp:757 SUMMARY: AddressSanitizer: heap-buffer-overflow in doris::AggregateFunctionNullUnaryInlineV2<...>::execute_function_with_incremental(...) ``` ### Release note None ### Check List (For Author) - Test  - [ ] Regression test - [ ] Unit Test - [ ] Manual test (add detailed scripts or steps below) - [ ] No need to test or manual test. Explain why: - [ ] This is a refactor/code format and no logic has been changed. - [ ] Previous test can cover this change. - [ ] No code files have been changed. - [ ] Other reason  - Behavior changed: - [ ] No. - [ ] Yes.  - Does this need documentation? - [ ] No. - [ ] Yes.  ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label

hello-stephen · 2026-08-31T06:22:49Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

hello-stephen · 2026-08-31T06:23:03Z

run buildall

github-actions · 2026-09-05T14:01:44Z

PR approved by anyone and no changes requested.

github-actions · 2026-09-05T14:01:46Z

PR approved by at least one committer and no changes requested.

yiguolei · 2026-09-05T14:01:53Z

run buildall

hello-stephen · 2026-09-05T18:17:05Z

BE UT Coverage Report