Uh oh!
There was an error while loading. Please reload this page.
branch-4.1: [fix](fe) Use service-specific Ranger select access types #67206 - #67414
Open
github-actions[bot] wants to merge 1 commit into
Open
branch-4.1: [fix](fe) Use service-specific Ranger select access types #67206#67414github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
hello-stephen
commented
Sep 2, 2026
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
hello-stephen
commented
Sep 2, 2026
Contributor
run buildall |
### What problem does this PR solve? Problem Summary: `RangerAccessController` hardcoded the Doris uppercase `SELECT` access type for row-filter and data-mask requests. Ranger-Hive defines this access type as lowercase `select`. Ordinary authorization could initially succeed, but after Ranger initialized its optimized exact-match evaluator, row-filter and data-mask lookups using uppercase `SELECT` skipped the lowercase policies. This was reproduced against the unmodified `apache/doris:all-in-one-4.1.3` image. The query was authorized but returned unfiltered and unmasked rows: ```text expected: [[2, NULL]] actual: [[1, first], [2, second]] ``` This PR: - delegates SELECT mapping to each Ranger service while retaining a concrete uppercase default, preserving compatibility with existing external subclasses; - uses lowercase `select` consistently for Ranger-Hive authorization, row filters, and data masks; - keeps Ranger connection and process settings in the existing `ranger-<serviceName>-security.xml` configuration; - adds unit coverage and an end-to-end `ranger_p2` case covering lowercase access entries, row filtering, data masking, and a warmed-up policy evaluator. ### Validation - `./run-fe-ut.sh --run org.apache.doris.catalog.authorizer.ranger.hive.RangerHiveAccessControllerTest`: 2 tests passed, 0 failures/errors/skips. - `./run-regression-test.sh --run --conf <local-ranger-conf> -d ranger_p2 -s test_ranger_hive_lowercase_access_type`: 1 suite passed, 0 failed, 0 skipped. The FE loaded `ranger-doris_hive-security.xml`, the catalog did not provide a Ranger URL, and both first and warmed-up queries returned the filtered and masked result.
yiguoleiforce-pushed
the
auto-pick-67206-branch-4.1
branch
from
September 5, 2026 14:03
b8c18de to
1509634Compareyiguolei
commented
Sep 5, 2026
Contributor
run buildall |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked from #67206