Skip to content

[fix](build) write the hms-hive-shade artifact via explicit outputFile#67461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
damokelis wants to merge 1 commit into
base:master
Choose a base branch
from
Open

[fix](build) write the hms-hive-shade artifact via explicit outputFile #67461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions fe/fe-connector/fe-connector-hms-hive-shade/pom.xml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -314,6 +314,15 @@ under the License.
</goals>
<phase>process-classes</phase>
<configuration>
<!-- Write the shaded jar straight to the module's artifact path instead of
going through shade's replace-the-main-artifact step. That step reads
project.getArtifact().getFile(), which Maven only populates in the
package phase — but this shade runs in process-classes (see the
maven-jar-plugin comment above for why it must). Without this the build
fails with "Failed to create shaded artifact, project main artifact does
not exist" even though maven-jar-plugin did create the jar. The path is
the default artifact path, so downstream consumers are unaffected. -->
<outputFile>${project.build.directory}/${project.artifactId}-${project.version}.jar</outputFile>
<!-- WHITELIST, not blacklist. The fat hive-catalog-shade used a short
exclude list and tolerated a huge tail of transitive junk (hadoop-yarn,
curator, jersey, jetty, kerby, ehcache, nimbus-jose, mssql-jdbc, guice,
Expand Down