Uh oh!
There was an error while loading. Please reload this page.
[improvement](ci) Accept Astra and Fable 5.1 review receipts - #67561
Merged
shuke987 merged 2 commits intoSep 7, 2026
Conversation
### What problem does this PR solve? Issue Number: N/A Related PR: apache#66959 Problem Summary: A converged local review using GPT-6 Astra or Claude Fable 5.1 is rejected by the PASS receipt validator with "model is not allowed", even when the review meets the existing effort, commit, reviewer, and findings requirements. Extend the exact model allowlist: - `gpt-6-astra`: `xhigh`, `max`, or `ultra`. - `claude-fable-5-1` and its Claude Code `[1m]` form: `xhigh` or `max`. Existing model eligibility and receipt checks are preserved. The hosted runner continues to use GPT-5.6 Sol. The `apache/doris-skills` allowlist needs a companion update; land the receiver support first. Model references: - [GPT-6 Astra](https://developers.openai.com/api/docs/guides/latest-model) - [Fable 5.1 migration and effort levels](https://platform.claude.com/docs/en/models/fable-5-1/migration-guide) - [Claude Code model configuration](https://code.claude.com/docs/en/model-config) ### Release note None ### Check List (For Author) - Test - [ ] Regression test - [x] Unit Test - [x] Manual test (add detailed scripts or steps below) - `python3 .github/scripts/test_validate_review_pass_comment.py` — 25 tests passed, including the expanded model/effort subcases. - Expanded tests fail against the previous validator and pass with the allowlist extension. - Negative cases cover insufficient effort, Claude `ultra`, unlisted model aliases, and an unlisted future Fable version. - Whitespace checks passed for both changed files. - [ ] No need to test or manual test. Explain why: - Behavior changed: - [ ] No. - [x] Yes. Qualified Astra and Fable 5.1 receipts can satisfy the existing code-review check. - Does this need documentation? - [x] No. - [ ] Yes. ### Check List (For Reviewer who merge this PR) - [ ] Confirm the release note - [ ] Confirm test cases - [ ] Confirm document - [ ] Add branch pick label
hello-stephen
commented
Sep 7, 2026
Contributor
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
shuke987
commented
Sep 7, 2026
ContributorAuthor
Local pipeline review — ✅ PASSschema: doris-repo-review/v1status: PASSpr: apache/doris#67561commit: 62665deda5ca0a2473a479cc2036022b99bb5419base: f75e66f8810b1fa369c2f4d4003593be67fdd887reviewed_at: 2026-09-07T11:43+08:00reviewer: shuke987model: gpt-5.6-soleffort: xhighfindings: {blocker: 0, major: 0, minor: 1, nit: 0}rounds: 1converged: trueNotes for maintainers None. Reviewed locally with the |
morningman
approved these changes
Sep 7, 2026
shuke987
commented
Sep 7, 2026
ContributorAuthor
skip buildall |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: N/A
Related PR: #66959
Problem Summary:
A converged local review using GPT-6 Astra or Claude Fable 5.1 is rejected by the PASS receipt validator with "model is not allowed", even when the review meets the existing effort, commit, reviewer, and findings requirements.
Extend the exact model allowlist:
gpt-6-astra:xhigh,max, orultra.claude-fable-5-1and its Claude Code[1m]form:xhighormax.Existing model eligibility and receipt checks are preserved. The hosted runner continues to use GPT-5.6 Sol. The
apache/doris-skillsallowlist needs a companion update; land the receiver support first.Model references:
Release note
None
Check List (For Author)
Test
python3 .github/scripts/test_validate_review_pass_comment.py— 25 tests passed, including the expanded model/effort subcases.ultrarejection cases; existing insufficient-effort and unlisted-model tests remain unchanged.Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)