Skip to content

[feat](lateral-view) Support execution of lateral view stmt - #7255

Merged
morningman merged 11 commits into
apache:masterfrom
morningman:table_func
Dec 16, 2021
Merged

[feat](lateral-view) Support execution of lateral view stmt#7255
morningman merged 11 commits into
apache:masterfrom
morningman:table_func

Conversation

@morningman

@morningmanmorningman commented Nov 30, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Proposed changes

  1. Add table function node
  2. Add 3 table functions: explode_split, explode_bitmap and explode_json_array

Design can be found in #6746

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • Code refactor (Modify the code structure, format the code, etc...)
  • Optimization. Including functional usability improvements and performance improvements.
  • Dependency. Such as changes related to third-party components.
  • Other.

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If these changes need document changes, I have updated the document
  • Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morningmanmorningman added kind/feature Categorizes issue or PR as related to a new feature. area/sql/execution Issues or PRs related to the execution engine labels Nov 30, 2021
@morningman
morningmanforce-pushed the table_func branch 2 times, most recently from 7d2ee28 to 9f74ec5CompareDecember 6, 2021 04:14
@morningman
morningman marked this pull request as draft December 6, 2021 04:14
@morningman
morningman marked this pull request as ready for review December 9, 2021 03:03
EmmyMiao87
EmmyMiao87 reviewed Dec 9, 2021
View reviewed changes
Comment threadbe/src/exec/table_function_node.cpp Outdated
Comment threadbe/src/exec/table_function_node.cpp
Comment threadbe/src/exprs/table_function/table_function_factory.h
Comment threadfe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java Outdated
Comment threadfe/fe-core/src/main/java/org/apache/doris/analysis/FunctionCallExpr.java
Comment threadfe/fe-core/src/main/java/org/apache/doris/analysis/LateralViewRef.java Outdated
Comment threadfe/fe-core/src/main/java/org/apache/doris/qe/Coordinator.java
Comment threadfe/fe-core/src/test/java/org/apache/doris/planner/TableFunctionPlanTest.java
import java.io.File;
import java.util.UUID;

public class TableFunctionPlanTest {

@EmmyMiao87EmmyMiao87Dec 9, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some UT about explode_bitmap, explode_json_array_xxx

@morningmanmorningmanDec 15, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Comment threadfe/fe-core/src/main/java/org/apache/doris/analysis/LateralViewRef.java
@EmmyMiao87EmmyMiao87 linked an issue Dec 9, 2021 that may be closed by this pull request
[Feature] Support Lateral view syntax #6746
Closed
3 tasks
@EmmyMiao87EmmyMiao87 self-assigned this Dec 9, 2021
EmmyMiao87
EmmyMiao87 reviewed Dec 10, 2021
View reviewed changes
Comment threadbe/src/exec/table_function_node.cpp

return true;
}

@EmmyMiao87EmmyMiao87Dec 10, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add examples of real data above two while(true)

@morningmanmorningmanDec 11, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Comment threadbe/src/exec/table_function_node.cpp
tuple_ptr = reinterpret_cast<Tuple*>(tuple_buffer);
}

pre_tuple_ptr = tuple_ptr;

@EmmyMiao87EmmyMiao87Dec 10, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic of constructing a new line can be abstracted separately into a function

@morningmanmorningmanDec 11, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried. But it has to pass a lot param to that new method, which seems not necessary.

EmmyMiao87
EmmyMiao87 approved these changes Dec 15, 2021
View reviewed changes

@EmmyMiao87EmmyMiao87 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Dec 15, 2021
@github-actions

github-actionsBot commented Dec 15, 2021

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Dec 15, 2021

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@morningman
morningman merged commit 0499b22 into apache:masterDec 16, 2021
zhengshiJ pushed a commit to zhengshiJ/incubator-doris that referenced this pull request Dec 24, 2021
@morningmanjianghaochen
[feat](lateral-view) Support execution of lateral view stmt (apache#7255
b4cebf2
)
1. Add table function node
2. Add 3 table functions: explode_split, explode_bitmap and explode_json_array
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EmmyMiao87EmmyMiao87EmmyMiao87 approved these changes

Assignees

@EmmyMiao87EmmyMiao87

Labels

approvedIndicates a PR has been approved by one committer.area/sql/executionIssues or PRs related to the execution enginekind/featureCategorizes issue or PR as related to a new feature.reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature] Support Lateral view syntax

3 participants

@morningman@EmmyMiao87@morningman-cmy