Skip to content

[refactor](storage) VGenericIterator to reuse Schema - #7858

Merged
morningman merged 2 commits into
apache:masterfrom
zuochunwei:VGenericIteratorRefactor
Feb 9, 2022
Merged

[refactor](storage) VGenericIterator to reuse Schema#7858
morningman merged 2 commits into
apache:masterfrom
zuochunwei:VGenericIteratorRefactor

Conversation

@zuochunwei

Copy link
Copy Markdown
Contributor

Proposed changes

  1. reuse Schema to avoid copying, because clone Schema will generate a lot of sub Field object
  2. call interface provided by Block to reduce code lines

Issue Number: close #xxx

Problem Summary:

Describe the overview of changes.

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@wangbowangbo changed the title (refactor)(vectorized)(olap) refactor VGenericIterator to reuse Schema[refactor](storage) VGenericIterator to reuse SchemaJan 26, 2022
@wangbowangbo self-assigned this Jan 27, 2022
@HappenLee

Copy link
Copy Markdown
Contributor

please resolve confict first

@zuochunwei
zuochunweiforce-pushed the VGenericIteratorRefactor branch from ed6e958 to cf42fbcCompareFebruary 8, 2022 04:20

@HappenLeeHappenLee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added approved Indicates a PR has been approved by one committer. reviewed labels Feb 8, 2022
@github-actions

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@morningman
morningman merged commit db20e1f into apache:masterFeb 9, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approvedIndicates a PR has been approved by one committer.reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@zuochunwei@HappenLee@morningman@wangbo