Uh oh!
There was an error while loading. Please reload this page.
[fix] fix ltrim result may incorrect in some case - #7963
Merged
Conversation
xinghuayu007
commented
Feb 7, 2022
Contributor
please add some unit tests for case: __builtin_cl/tz (0) |
amosbird
commented
Feb 7, 2022
Contributor
Similar fixes has been done in #7712 , which was caught by current unit tests. It's an indication that test coverage should be improved. |
yangzhg
commented
Feb 7, 2022
MemberAuthor
Unit test has already contained this situation |
yangzhg
commented
Feb 7, 2022
MemberAuthor
I see, this is in another function, we may merge the those implements together |
xinghuayu007
commented
Feb 8, 2022
Contributor
LGTM |
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Summary:
fix ltrim result may incorrect in some case
according to https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html
Built-in Function: int __builtin_cl/tz (unsigned int x)
If x is 0, the result is undefined.
So we handle the case of 0 separately
this function return different between gcc and clang when x is 0
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...