Uh oh!
There was an error while loading. Please reload this page.
[Bug](Variables) Fix bug that execute showVariablesStmt with where expression return empty resultset - #8094
Merged
Conversation
…pression return empty resultset
yiguolei
commented
Feb 17, 2022
Contributor
Why change connection id from long to int? |
caiconghui
commented
Feb 17, 2022
ContributorAuthor
the original type of connection id in connect context in is int, |
caiconghui
commented
Feb 17, 2022
ContributorAuthor
The value range of connection id is from int_min to int_max, I think it is enough, so I don't change the connection id type in connection context |
yiguolei
commented
Feb 18, 2022
Contributor
LGTM |
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close#8093
Problem Summary:
This Bug is introduced by PR #7936 , which change key type of connectionMap from Long to Integer, which cause connectionMap could not find connectContext by connectionId
Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...