Skip to content

[Feature] CSV import and export support header - #8765

Merged
morningman merged 7 commits into
apache:masterfrom
chenlinzhong:csv_with_header_v2
Apr 18, 2022
Merged

[Feature] CSV import and export support header#8765
morningman merged 7 commits into
apache:masterfrom
chenlinzhong:csv_with_header_v2

Conversation

@chenlinzhong

@chenlinzhongchenlinzhong commented Mar 30, 2022

Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: open #8487

Problem Summary:

  • Add two new types to stream load boker load: csv_with_names and csv_with_name_sand_types
  • Add two new types to export: csv_with_names and csv_with_names_and_types

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

cambyzju
cambyzju reviewed Apr 2, 2022
View reviewed changes
Comment threadbe/src/http/action/stream_load.cpp Outdated
cambyzju
cambyzju reviewed Apr 2, 2022
View reviewed changes
Comment threadfe/fe-core/src/main/java/org/apache/doris/load/BrokerFileGroup.java Outdated
yinzhijian
yinzhijian reviewed Apr 2, 2022
View reviewed changes
Comment threadbe/src/runtime/export_sink.cpp Outdated
yinzhijian
yinzhijian reviewed Apr 2, 2022
View reviewed changes
Comment threadbe/src/runtime/export_sink.cpp Outdated
Comment threadbe/src/runtime/export_sink.h Outdated
Comment threaddocs/zh-CN/sql-reference/sql-statements/Data Manipulation/STREAM LOAD.md Outdated
Comment threadfe/fe-core/src/main/java/org/apache/doris/load/ExportJob.java Outdated
Comment threadfe/fe-core/src/main/java/org/apache/doris/planner/ExportSink.java Outdated
yinzhijian
yinzhijian reviewed Apr 8, 2022
View reviewed changes

@yinzhijianyinzhijian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cambyzju
cambyzju reviewed Apr 8, 2022
View reviewed changes
Comment threadbe/src/runtime/file_result_writer.cpp Outdated
@cambyzju

cambyzju commented Apr 11, 2022

Copy link
Copy Markdown
Contributor

+1

morningman
morningman previously approved these changes Apr 11, 2022
View reviewed changes

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningmanmorningman added kind/improvement kind/feature Categorizes issue or PR as related to a new feature. area/outfile area/export dev/backlog waiting to be merged in future dev branch kind/need-regression-test Need to add regression test for this case labels Apr 11, 2022
@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Apr 11, 2022
@github-actions

github-actionsBot commented Apr 11, 2022

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Apr 11, 2022

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@chenlinzhongchenlinzhong mentioned this pull request Apr 13, 2022
Merged
@github-actionsgithub-actionsBot added area/load Issues or PRs related to all kinds of load area/planner Issues or PRs related to the query planner area/routine load labels Apr 14, 2022
@github-actionsgithub-actionsBot added kind/docs Categorizes issue or PR as related to documentation. and removed approved Indicates a PR has been approved by one committer. labels Apr 14, 2022
morningman
morningman approved these changes Apr 18, 2022
View reviewed changes

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman
morningman merged commit afce993 into apache:masterApr 18, 2022
@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Apr 18, 2022
@github-actions

github-actionsBot commented Apr 18, 2022

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

weizhengte pushed a commit to weizhengte/incubator-doris that referenced this pull request Apr 22, 2022
@chenlinzhong
[feature](load)(csv) CSV import and export support header (apache#8765)
4ec774b
- Add two new types to stream load boker load: **csv_with_names** and **csv_with_name_sand_types**
- Add two new types to export: **csv_with_names** and **csv_with_names_and_types**
zhengshiJ pushed a commit to zhengshiJ/incubator-doris that referenced this pull request Apr 27, 2022
@chenlinzhongjianghaochen
[feature](load)(csv) CSV import and export support header (apache#8765)
331341a
- Add two new types to stream load boker load: **csv_with_names** and **csv_with_name_sand_types**
- Add two new types to export: **csv_with_names** and **csv_with_names_and_types**
starocean999 pushed a commit to starocean999/incubator-doris that referenced this pull request May 19, 2022
@chenlinzhong@starocean999
[feature](load)(csv) CSV import and export support header (apache#8765)
ee58425
- Add two new types to stream load boker load: **csv_with_names** and **csv_with_name_sand_types**
- Add two new types to export: **csv_with_names** and **csv_with_names_and_types**
englefly pushed a commit to englefly/incubator-doris that referenced this pull request May 23, 2022
@chenlinzhongminghong.zhou
[feature](load)(csv) CSV import and export support header (apache#8765)
1381610
- Add two new types to stream load boker load: **csv_with_names** and **csv_with_name_sand_types**
- Add two new types to export: **csv_with_names** and **csv_with_names_and_types**
GoGoWen pushed a commit to GoGoWen/incubator-doris that referenced this pull request Jun 13, 2022
@chenlinzhong@GoGoWen
[feature](load)(csv) CSV import and export support header (apache#8765)
f4a7e87
- Add two new types to stream load boker load: **csv_with_names** and **csv_with_name_sand_types**
- Add two new types to export: **csv_with_names** and **csv_with_names_and_types**
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yinzhijianyinzhijianyinzhijian left review comments
@cambyzjucambyzjucambyzju left review comments
@morningmanmorningmanmorningman approved these changes

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.area/exportarea/loadIssues or PRs related to all kinds of loadarea/outfilearea/plannerIssues or PRs related to the query plannerarea/routine loaddev/backlogwaiting to be merged in future dev branchkind/docsCategorizes issue or PR as related to documentation.kind/featureCategorizes issue or PR as related to a new feature.kind/improvementkind/need-regression-testNeed to add regression test for this casereviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chenlinzhong@cambyzju@morningman@yinzhijian