Skip to content

[Vectorized][Function] Support geolocation functions on vectorized engine - #8790

Merged
morningman merged 2 commits into
apache:masterfrom
Gabriel39:st_functions
Apr 3, 2022
Merged

[Vectorized][Function] Support geolocation functions on vectorized engine#8790
morningman merged 2 commits into
apache:masterfrom
Gabriel39:st_functions

Conversation

@Gabriel39

@Gabriel39Gabriel39 commented Mar 31, 2022

Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close#8788

Problem Summary:

Describe the overview of changes.

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@zbtzbtzbt

zbtzbtzbt commented Apr 1, 2022

Copy link
Copy Markdown
Contributor

good job!
in addition, please update document in

  • docs/en/administrator-guide/vectorized-execution-engine.md
  • docs/zh-CN/administrator-guide/vectorized-execution-engine.md

delete following the statement:
The geolocation function is not supported, including all functions starting with ST_ in the function. For details, please refer to the section on SQL functions in the official documentation

@Gabriel39

Gabriel39 commented Apr 1, 2022

Copy link
Copy Markdown
ContributorAuthor

good job! in addition, please update document in

  • docs/en/administrator-guide/vectorized-execution-engine.md
  • docs/zh-CN/administrator-guide/vectorized-execution-engine.md

delete following the statement: The geolocation function is not supported, including all functions starting with ST_ in the function. For details, please refer to the section on SQL functions in the official documentation

Thanks @zbtzbtzbt I plan to do this in next PR because I will implement all geolocation functions in next PR which is described in #8788

zenoyang
zenoyang reviewed Apr 1, 2022
View reviewed changes

@zenoyangzenoyang left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and it's best to provide function UT

Comment threadbe/src/vec/functions/functions_geo.cpp Outdated
Comment threadbe/src/vec/functions/functions_geo.cpp Outdated
HappenLee
HappenLee reviewed Apr 2, 2022
View reviewed changes
Comment threadbe/src/geo/geo_types.cpp
HappenLee
HappenLee reviewed Apr 2, 2022
View reviewed changes
Comment threadbe/src/geo/geo_types.h
Comment threadbe/src/vec/functions/functions_geo.h Outdated
@Gabriel39

Gabriel39 commented Apr 2, 2022

Copy link
Copy Markdown
ContributorAuthor

and it's best to provide function UT

@zenoyang Thanks for reminding! I have added UTs for these functions and push again

@Gabriel39
Gabriel39 requested a review from HappenLeeApril 2, 2022 09:55
@morningmanmorningman added kind/feature Categorizes issue or PR as related to a new feature. dev/backlog waiting to be merged in future dev branch labels Apr 2, 2022
HappenLee
HappenLee approved these changes Apr 2, 2022
View reviewed changes

@HappenLeeHappenLee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions

github-actionsBot commented Apr 2, 2022

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Apr 2, 2022
@HappenLeeHappenLee added dev/1.0.1-deprecated should be merged into dev-1.0.1 branch and removed approved Indicates a PR has been approved by one committer. labels Apr 2, 2022
@github-actions

github-actionsBot commented Apr 2, 2022

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@morningman
morningman merged commit f3c6ddf into apache:masterApr 3, 2022
@xinyiZzzxinyiZzz mentioned this pull request Apr 3, 2022
Merged
morningman pushed a commit that referenced this pull request Apr 6, 2022
@Gabriel39@morningman
[feature](function) Support geolocation functions on vectorized engine (
4ba208f
#8790)
@morningmanmorningman added dev/merged-1.0.1-deprecated PR has been merged into dev-1.0.1 and removed dev/1.0.1-deprecated should be merged into dev-1.0.1 branch labels Apr 6, 2022
BiteTheDDDDt pushed a commit to BiteTheDDDDt/incubator-doris that referenced this pull request Apr 6, 2022
@Gabriel39@BiteTheDDDDt
[feature](function) Support geolocation functions on vectorized engine (
9e397e4
apache#8790)
@Gabriel39
Gabriel39 deleted the st_functions branch April 11, 2022 05:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zenoyangzenoyangzenoyang left review comments
@HappenLeeHappenLeeHappenLee approved these changes

Assignees

No one assigned

Labels

dev/backlogwaiting to be merged in future dev branchdev/merged-1.0.1-deprecatedPR has been merged into dev-1.0.1kind/featureCategorizes issue or PR as related to a new feature.reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature] Support geolocation functions on vectorized engine

5 participants

@Gabriel39@zbtzbtzbt@HappenLee@zenoyang@morningman