Skip to content

[Vectorized][Function] Support all geolocation functions on vectorized engine - #8846

Merged
morningman merged 4 commits into
apache:masterfrom
Gabriel39:st_functions_final
Apr 11, 2022
Merged

[Vectorized][Function] Support all geolocation functions on vectorized engine#8846
morningman merged 4 commits into
apache:masterfrom
Gabriel39:st_functions_final

Conversation

@Gabriel39

@Gabriel39Gabriel39 commented Apr 5, 2022

Copy link
Copy Markdown
Contributor

Proposed changes

Issue Number: close#8788

Problem Summary:

Describe the overview of changes.

Checklist(Required)

  1. Does it affect the original behavior: (Yes/No/I Don't know)
  2. Has unit tests been added: (Yes/No/No Need)
  3. Has document been added or modified: (Yes/No/No Need)
  4. Does it need to update dependencies: (Yes/No)
  5. Are there any changes that cannot be rolled back: (Yes/No)

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

HappenLee
HappenLee reviewed Apr 6, 2022
View reviewed changes
Comment threadbe/src/vec/functions/functions_geo.cpp Outdated
Comment threadbe/src/vec/functions/functions_geo.cpp Outdated
Comment threadbe/src/vec/functions/functions_geo.cpp Outdated
Comment threadbe/src/vec/functions/functions_geo.cpp Outdated
@Gabriel39
Gabriel39 requested a review from HappenLeeApril 6, 2022 04:06
HappenLee
HappenLee reviewed Apr 7, 2022
View reviewed changes
Comment threadbe/src/vec/functions/functions_geo.cpp Outdated
@Gabriel39
Gabriel39 requested a review from HappenLeeApril 8, 2022 01:37
morningman
morningman approved these changes Apr 10, 2022
View reviewed changes

@morningmanmorningman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actionsgithub-actionsBot added the approved Indicates a PR has been approved by one committer. label Apr 10, 2022
@github-actions

github-actionsBot commented Apr 10, 2022

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions

github-actionsBot commented Apr 10, 2022

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@morningmanmorningman added the dev/1.0.1-deprecated should be merged into dev-1.0.1 branch label Apr 11, 2022
@morningman
morningman merged commit 7f71728 into apache:masterApr 11, 2022
BiteTheDDDDt pushed a commit to BiteTheDDDDt/incubator-doris that referenced this pull request Apr 11, 2022
@Gabriel39@BiteTheDDDDt
[feature](function)(vectorized) Support all geolocation functions on …
dff18e3
…vectorized engine (apache#8846)
@Gabriel39
Gabriel39 deleted the st_functions_final branch April 11, 2022 05:24
morningman pushed a commit that referenced this pull request Apr 11, 2022
@Gabriel39@morningman
[feature](function)(vectorized) Support all geolocation functions on …
d003cc7
…vectorized engine (#8846)
@morningmanmorningman added dev/merged-1.0.1-deprecated PR has been merged into dev-1.0.1 and removed dev/1.0.1-deprecated should be merged into dev-1.0.1 branch labels Apr 11, 2022
weizhengte pushed a commit to weizhengte/incubator-doris that referenced this pull request Apr 22, 2022
@Gabriel39
[feature](function)(vectorized) Support all geolocation functions on …
b148099
…vectorized engine (apache#8846)
zhengshiJ pushed a commit to zhengshiJ/incubator-doris that referenced this pull request Apr 27, 2022
@Gabriel39jianghaochen
[feature](function)(vectorized) Support all geolocation functions on …
ca20361
…vectorized engine (apache#8846)
starocean999 pushed a commit to starocean999/incubator-doris that referenced this pull request May 19, 2022
@Gabriel39@starocean999
[feature](function)(vectorized) Support all geolocation functions on …
60df00d
…vectorized engine (apache#8846)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morningmanmorningmanmorningman approved these changes
@HappenLeeHappenLeeAwaiting requested review from HappenLee

Assignees

No one assigned

Labels

approvedIndicates a PR has been approved by one committer.area/vectorizationdev/merged-1.0.1-deprecatedPR has been merged into dev-1.0.1reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Feature] Support geolocation functions on vectorized engine

4 participants

@Gabriel39@morningman@HappenLee@jackwener