Uh oh!
There was an error while loading. Please reload this page.
[refactor] Unify all unit tests into one binary file - #8958
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
| } else { | ||
| contains_ctx->shapes[i] = GeoShape::from_encoded(str->ptr, str->len); | ||
| contains_ctx->shapes[i] = | ||
| std::shared_ptr<GeoShape>(GeoShape::from_encoded(str->ptr, str->len)); |
Contributor
There was a problem hiding this comment.
Why using shared_ptr instead of unique_ptr?
Uh oh!
There was an error while loading. Please reload this page.
zbtzbtzbt
commented
Apr 11, 2022
Contributor
cool！ |
Uh oh!
There was an error while loading. Please reload this page.
yangzhgforce-pushed
the
speedup_test
branch
3 times, most recently
from
April 12, 2022 06:32
6665d8e to
8496f4cCompare1. solved the previous delayed unit test file size is too large (1.7G+) and the unit test link time is too long problem problems 2. Unify all unit tests into one file to significantly reduce unit test execution time to less than 3 mins 3. temporarily disable stream_load_test.cpp, metrics_action_test.cpp, load_channel_mgr_test.cpp because it will re-implement part of the code and affect other tests
Contributor
PR approved by at least one committer and no changes requested. |
Contributor
PR approved by anyone and no changes requested. |
weizhengte pushed a commit
to weizhengte/incubator-doris
that referenced
this pull request
Apr 22, 2022
1. solved the previous delayed unit test file size is too large (1.7G+) and the unit test link time is too long problem problems 2. Unify all unit tests into one file to significantly reduce unit test execution time to less than 3 mins 3. temporarily disable stream_load_test.cpp, metrics_action_test.cpp, load_channel_mgr_test.cpp because it will re-implement part of the code and affect other tests
zhengshiJ pushed a commit
to zhengshiJ/incubator-doris
that referenced
this pull request
Apr 27, 2022
1. solved the previous delayed unit test file size is too large (1.7G+) and the unit test link time is too long problem problems 2. Unify all unit tests into one file to significantly reduce unit test execution time to less than 3 mins 3. temporarily disable stream_load_test.cpp, metrics_action_test.cpp, load_channel_mgr_test.cpp because it will re-implement part of the code and affect other tests
starocean999 pushed a commit
to starocean999/incubator-doris
that referenced
this pull request
May 19, 2022
1. solved the previous delayed unit test file size is too large (1.7G+) and the unit test link time is too long problem problems 2. Unify all unit tests into one file to significantly reduce unit test execution time to less than 3 mins 3. temporarily disable stream_load_test.cpp, metrics_action_test.cpp, load_channel_mgr_test.cpp because it will re-implement part of the code and affect other tests
yangzhg added a commit
to yangzhg/doris
that referenced
this pull request
Oct 12, 2022
1. solved the previous delayed unit test file size is too large (1.7G+) and the unit test link time is too long problem problems 2. Unify all unit tests into one file to significantly reduce unit test execution time to less than 3 mins 3. temporarily disable stream_load_test.cpp, metrics_action_test.cpp, load_channel_mgr_test.cpp because it will re-implement part of the code and affect other tests (cherry picked from commit 5a44eea)
yangzhg added a commit
to yangzhg/doris
that referenced
this pull request
Oct 12, 2022
1. solved the previous delayed unit test file size is too large (1.7G+) and the unit test link time is too long problem problems 2. Unify all unit tests into one file to significantly reduce unit test execution time to less than 3 mins 3. temporarily disable stream_load_test.cpp, metrics_action_test.cpp, load_channel_mgr_test.cpp because it will re-implement part of the code and affect other tests (cherry picked from commit 5a44eea) Change-Id: I67a162912a35273804bc6d026acc9bd9ccc3ca3d
yangzhg added a commit
to yangzhg/doris
that referenced
this pull request
Oct 12, 2022
1. solved the previous delayed unit test file size is too large (1.7G+) and the unit test link time is too long problem problems 2. Unify all unit tests into one file to significantly reduce unit test execution time to less than 3 mins 3. temporarily disable stream_load_test.cpp, metrics_action_test.cpp, load_channel_mgr_test.cpp because it will re-implement part of the code and affect other tests (cherry picked from commit 5a44eea) Change-Id: I67a162912a35273804bc6d026acc9bd9ccc3ca3d
yangzhg added a commit
to yangzhg/doris
that referenced
this pull request
Oct 12, 2022
1. solved the previous delayed unit test file size is too large (1.7G+) and the unit test link time is too long problem problems 2. Unify all unit tests into one file to significantly reduce unit test execution time to less than 3 mins 3. temporarily disable stream_load_test.cpp, metrics_action_test.cpp, load_channel_mgr_test.cpp because it will re-implement part of the code and affect other tests (cherry picked from commit 5a44eea) Change-Id: I67a162912a35273804bc6d026acc9bd9ccc3ca3d
yangzhg added a commit
to yangzhg/doris
that referenced
this pull request
Oct 13, 2022
1. solved the previous delayed unit test file size is too large (1.7G+) and the unit test link time is too long problem problems 2. Unify all unit tests into one file to significantly reduce unit test execution time to less than 3 mins 3. temporarily disable stream_load_test.cpp, metrics_action_test.cpp, load_channel_mgr_test.cpp because it will re-implement part of the code and affect other tests (cherry picked from commit 5a44eea) Change-Id: I67a162912a35273804bc6d026acc9bd9ccc3ca3d
yiguolei pushed a commit
that referenced
this pull request
Oct 13, 2022
…13329) 1. solved the previous delayed unit test file size is too large (1.7G+) and the unit test link time is too long problem problems 2. Unify all unit tests into one file to significantly reduce unit test execution time to less than 3 mins 3. temporarily disable stream_load_test.cpp, metrics_action_test.cpp, load_channel_mgr_test.cpp because it will re-implement part of the code and affect other tests (cherry picked from commit 5a44eea) Change-Id: I67a162912a35273804bc6d026acc9bd9ccc3ca3d
wyxxxcat pushed a commit
to wyxxxcat/doris
that referenced
this pull request
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
stream_load_test.cpp,metrics_action_test.cpp,load_channel_mgr_test.cppbecause it will re-implement part of the code and affect other testsChecklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...