build(deps): remove unused j2objc-annotations and curator-test dependencies - #20329
Open
ashwintumma23 wants to merge 1 commit into
Open
build(deps): remove unused j2objc-annotations and curator-test dependencies#20329ashwintumma23 wants to merge 1 commit into
ashwintumma23 wants to merge 1 commit into
Conversation
ashwintumma23
force-pushed
the
remove-unused-j2objc-curator-test-deps
branch
2 times, most recently
from
September 11, 2026 21:38
abea43b to
2b7860a
Compare
…encies - Remove com.google.j2objc:j2objc-annotations from root dependencyManagement (redundant; already pinned by the Guava BOM) - Remove org.apache.curator:curator-test from embedded-tests, rabbit-stream-indexing-service, druid-catalog, and lookups-cached-global (zero source usage in all four modules) - Remove j2objc-annotations entries from licenses.yaml
ashwintumma23
force-pushed
the
remove-unused-j2objc-curator-test-deps
branch
from
September 11, 2026 21:41
2b7860a to
a1169bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes two unused third-party dependencies (
com.google.j2objc:j2objc-annotationsand
org.apache.curator:curator-test) from modules where static analysis confirmedzero source usage, reducing attack surface and license exposure.
Release note
Removed unused
com.google.j2objc:j2objc-annotationsfrom rootdependencyManagementand
org.apache.curator:curator-testfrom 4 modules (embedded-tests,rabbit-stream-indexing-service,druid-catalog,lookups-cached-global) whereno source usage was found.
Key changed/added classes in this PR
pom.xmlembedded-tests/pom.xmlextensions-contrib/rabbit-stream-indexing-service/pom.xmlextensions-core/druid-catalog/pom.xmlextensions-core/lookups-cached-global/pom.xmllicenses.yamlReason for change
Keeping unused third-party dependencies increases attack surface and license exposure
without benefit. Static analysis flagged both artifacts as unused, and manual
investigation confirmed zero source imports in the affected modules.
curator-testremains declared in the 4 modules that actively use it (server,indexing-service,kafka-indexing-service,kafka-extraction-namespace) and inroot
dependencyManagementfor version pinning.j2objc-annotationsis already managed by the Guava BOM (already imported), so theexplicit
dependencyManagementpin was a redundant no-op.Changes
1. pom.xml (1 entry removed)
com.google.j2objc:j2objc-annotationsversion3.1fromdependencyManagement— redundant, as the Guava BOM already pins this artifactat the same version.
2. embedded-tests/pom.xml (1 entry removed)
org.apache.curator:curator-testtest-scope dependency — zerocurator.test/TestingServer/TestingClusterimports in source.3. extensions-contrib/rabbit-stream-indexing-service/pom.xml (1 entry removed)
org.apache.curator:curator-testtest-scope dependency — zerocurator.testimports in source.4. extensions-core/druid-catalog/pom.xml (1 entry removed)
org.apache.curator:curator-testtest-scope dependency — zerocurator.testimports in source.5. extensions-core/lookups-cached-global/pom.xml (1 entry removed)
org.apache.curator:curator-testtest-scope dependency (includingits stale
javassistexclusion) — zerocurator.testimports in source.6. licenses.yaml (2 sections removed)
j2objcentry forcoremodule.j2objcentry forextensions/protobuf-extensionsmodule.Tests
com.google.j2objcandcurator.testimports in all affectedmodule source trees
curator-testremains declared and available in the modules that actively use itaffected modules